收到错误(C#Tic Tac Toe程序)

时间:2016-12-04 10:48:16

标签: c# visual-studio visual-studio-2010

关于该计划:

我已经编写了一个用于制作Tic Tac Toe的C#代码。它是在Windows窗体应用程序(Visual Studio)中制作的。 在玩这个游戏时,当X或O获胜时,方法=>调用 checkForwinner()进行水平,垂直和对角线检查以确定获胜者。变量 there_is_a_winner 设置为true,并显示消息“获胜者胜利”。否则它会检查抽奖。

错误:

当我遵守此代码时,它显示0错误/警告/消息。但是,尽管如此,此代码无法正常工作。它无法确定获胜者。弹出框,显示谁赢得/ draw..never执行,除此之外,此代码工作正常。我希望有人可以提供帮助。

提前致谢。

using System;
using System.Collections.Generic;
using System.ComponentModel;
using System.Data;
using System.Drawing;
using System.Linq;
using System.Text;
using System.Windows.Forms;

namespace WindowsFormsApplication1
{
public partial class Form1 : Form
{
    bool turn = true;//(To check turn) True means X's turn, False=Y turn
    int turn_count = 0;
    public Form1()
    {
        InitializeComponent();
    }

    private void Form1_Load(object sender, EventArgs e)
    {

    }

    private void aboutToolStripMenuItem_Click(object sender, EventArgs e)/*About Section*/
    {
        MessageBox.Show("This Program is of Tic Tac Toe. It was created by Me for his C# project.","Tic Tac Toe -About");
    }

    private void exitToolStripMenuItem_Click(object sender, EventArgs e)/*Exit Section*/
    {
        Application.Exit();
    }

    private void button_click(object sender, EventArgs e)
    {
        Button b = (Button)sender;
        if(turn)
            b.Text="x";
        else
        b.Text="o";
        turn=!turn;
        b.Enabled = false;//disable the button, to prevent double entering.
        turn_count++;
    }
    private void checkForwinner()
    {
        bool there_is_a_winner= false;

        //horizontal check

         if ((A1.Text == A2.Text) && (A2.Text == A3.Text) && (!A1.Enabled))
            there_is_a_winner = true;//if above conditions are true, then bool variable=true.
        else if ((B1.Text == B2.Text) && (B2.Text == B3.Text) && (!B1.Enabled))
            there_is_a_winner = true;

        else if ((C1.Text == C2.Text) && (C2.Text == C3.Text) && (!C1.Enabled))
            there_is_a_winner = true;

        //Vertical Check
        else if ((A1.Text == B1.Text) && (B1.Text == C1.Text) && (!A1.Enabled))
            there_is_a_winner = true;

        else if ((A2.Text == B2.Text) && (B2.Text == C2.Text) && (!A2.Enabled))
            there_is_a_winner = true;

        else if ((A3.Text == B3.Text) && (B3.Text == C3.Text) && (!A3.Enabled))
            there_is_a_winner = true;

        //Diagonal Check
        else if ((A1.Text == B2.Text) && (B2.Text == C3.Text) && (!A1.Enabled))
            there_is_a_winner = true;

        else if ((A3.Text == B2.Text) && (B2.Text == C1.Text) && (!C1.Enabled))
            there_is_a_winner = true;

         if (there_is_a_winner)
         {
             dissableButtons();// If there is a winner call for buttons to be disbaled.

             String winner = "";
             if (turn)
                 winner = "0";
             else
                 winner = "x";
             MessageBox.Show(winner + "Wins!", "Congratulations!");
         }
        else
        {
            if (turn_count == 9)
                MessageBox.Show("Match Draw", "Result");
        }


    }
        private void dissableButtons()
        {
            try
            {
                foreach (Control c in Controls)
                {
                    Button b = (Button)c;
                    b.Enabled = false;//If there is a winner, disable all the buttons on the form
                }

            }
            catch { }
        }
    // New Game//Need to Reset Everything
        private void toolStripMenuItem2_Click(object sender, EventArgs e)
        {
            turn = true;
            turn_count = 0;
            try
            {
                foreach (Control c in Controls)
                {
                    Button b = (Button)c;
                    b.Enabled = true;
                    b.Text = "";//Initially we want blank Text

                }
            }
            catch { }
        }
    }
}

1 个答案:

答案 0 :(得分:2)

问题是函数checkForwinner()永远不会在程序中的任何地方被调用。

我希望button_click函数在适当的单元格中放置一个X或O,所以当单击该按钮时,它还需要检查是否有胜利者。我建议你将checkForwinner()作为button_click函数的最后一行,这样每次点击它时都会执行检查。

另外,作为样式注释,请使用大写字母W将其重命名为checkForWinner。另外,您应该缩进b.Text =" o&#34 ;;像这样:

    if(turn)
        b.Text="x";
    else
        b.Text="o";

话虽如此,我更喜欢在单线上使用花括号,所以我更喜欢这个:

    if(turn) 
    {
        b.Text="x";
    }
    else
    {
        b.Text="o";
    }

即使这会占用更多的行,但是当你在"中添加另一行时,它确实可以避免将来出现问题。条款或进入"否则"子句并忘记添加那些非常重要的花括号。这是一个很好的习惯 - 到处都是花括号。