我对C ++很陌生。
我刚刚完成了我的第一次＆＃34;真实＆＃34;程序
这是一个Tic Tac Toe游戏。
有人愿意通过我的代码阅读，告诉我在哪里可以优化某些内容吗？
#include <iostream>
using namespace std;
/**< Board variables */
string a1 = "_"; string a2 = "_"; string a3 = "_";
string b1 = "_"; string b2 = "_"; string b3 = "_";
string c1 = "_"; string c2 = "_"; string c3 = "_";
string showboard (){
cout << '\t' << ""<< '\t' << "1" << '\t' << "2" << '\t' << "3" << "\n";
cout << '\t' << "a"<< '\t' << a1 << '\t' << a2 << '\t' << a3 << "\n";
cout << '\t' << "b"<< '\t' << b1 << '\t' << b2 << '\t' << b3 << "\n";
cout << '\t' << "c"<< '\t' << c1 << '\t' << c2 << '\t' << c3 << "\n\n";
return "";
};
/**< Turn */
int turn;
/**< useless variable */
int x =1;
/**< "tiles" for example "X" or "O" */
string boardvalue;
/**< Checks if Turn is valid/legal */
string turnvalidation (string boardvalue){
if(turn==1 && a1!="_"){
cout << "Invalid option. Choose again! \n\n";
x=1;
} else if(turn==2 && a2!="_"){
cout << "Invalid option. Choose again! \n\n";
x=1;
} else if(turn==3 && a3!="_"){
cout << "Invalid option. Choose again! \n\n";
x=1;
} else if(turn==4 && b1!="_"){
cout << "Invalid option. Choose again! \n\n";
x=1;
} else if(turn==5 && b2!="_"){
cout << "Invalid option. Choose again! \n\n";
x=1;
} else if(turn==6 && b3!="_"){
cout << "Invalid option. Choose again! \n\n";
x=1;
} else if(turn==7 && c1!="_"){
cout << "Invalid option. Choose again! \n\n";
x=1;
} else if(turn==8 && c2!="_"){
cout << "Invalid option. Choose again! \n\n";
x=1;
} else if(turn==9 && c3!="_"){
cout << "Invalid option. Choose again! \n\n";
x=1;
} else if(turn==10){
cout << "Invalid option. Choose again! \n\n";
x=1;
} else {
x=0;
switch (turn){
case 1: a1=boardvalue; break;
case 2: a2=boardvalue; break;
case 3: a3=boardvalue; break;
case 4: b1=boardvalue; break;
case 5: b2=boardvalue; break;
case 6: b3=boardvalue; break;
case 7: c1=boardvalue; break;
case 8: c2=boardvalue; break;
case 9: c3=boardvalue; break;
}
}
return"";
};
/**< Checks if the game is won */
int wincheck(string boardvalue){
// Rows
if(a1==boardvalue && a2==boardvalue && a3==boardvalue){return 0;}else
if(b1==boardvalue && b2==boardvalue && b3==boardvalue){return 0;}else
if(c1==boardvalue && c2==boardvalue && c3==boardvalue){return 0;}else
// Columns
if(a1==boardvalue && b1==boardvalue && c1==boardvalue){return 0;}else
if(a2==boardvalue && b2==boardvalue && c2==boardvalue){return 0;}else
if(a3==boardvalue && b3==boardvalue && c3==boardvalue){return 0;}else
// Diagonals
if(c1==boardvalue && b2==boardvalue && a3==boardvalue){return 0;}else
if(a1==boardvalue && b2==boardvalue && c3==boardvalue){return 0;}else
{return 1;};
}
int main()
{
string player1;
string player2;
cout << "Player 1 enter your name \n";
cin >> player1;
cout << "\nPlayer 2 enter your name \n";
cin >> player2;
cout << endl;
cout << "Input example: a1 [enter]\n\n";
string turni; /**< Converts Input in switch value! */
while(1){ /**< Play again */
string a1 = "_"; string a2 = "_"; string a3 = "_";
string b1 = "_"; string b2 = "_"; string b3 = "_";
string c1 = "_"; string c2 = "_"; string c3 = "_";
while(1){
/**< Player 1s turn */
x=1;
while(1){
cout << player1 << " place your X \n\n";
showboard();
cin >> turni;
if(turni=="a1"){turn=1;} else if(turni=="a2"){turn=2;} else if(turni=="a3"){turn=3;} else if(turni=="b1"){turn=4;} else if(turni=="b2"){turn=5;} else if(turni=="b3"){turn=6;} else if(turni=="c1"){turn=7;} else if(turni=="c2"){turn=8;} else if(turni=="c3"){turn=9;} else{turn=10;};
/**< Checks if Turn is valid/legal */
turnvalidation("X");
break;
}
/**< Win Check */
if(wincheck("X") == 0){
showboard();
cout << "Congratulations " << player1 << " you won!";
break;
};
/**< Player 1s turn is over */
/**< Player 2s turn */
x=1;
while(1){
cout << player2 << " place your 0 \n\n";
showboard();
cin >> turni;
if(turni=="a1"){turn=1;} else if(turni=="a2"){turn=2;} else if(turni=="a3"){turn=3;} else if(turni=="b1"){turn=4;} else if(turni=="b2"){turn=5;} else if(turni=="b3"){turn=6;} else if(turni=="c1"){turn=7;} else if(turni=="c2"){turn=8;} else if(turni=="c3"){turn=9;} else{turn=10;};
/**< Checks if Turn is valid/legal */
turnvalidation("O");
break;
}
/**< Win Check */
if(wincheck("O")==0){
showboard();
cout << "Congratulations " << player2 << " you won!";
break;
};
/**< Player 1s turn is over */
}
/**< Play again and clear board */
cout << "\n\nIf you want to play again type ""1""! \n";
cin >> x;
if(x==1){
a1 = "_"; a2 = "_"; a3 = "_";
b1 = "_"; b2 = "_"; b3 = "_";
c1 = "_"; c2 = "_"; c3 = "_";
} else {break;}
}
}
游戏本身有效。
但
在本节中是一个错误：
cout << "\n\nIf you want to play again type ""1""! \n";
cin >> x;
if(x==1){
a1 = "_"; a2 = "_"; a3 = "_";
b1 = "_"; b2 = "_"; b3 = "_";
c1 = "_"; c2 = "_"; c3 = "_";
} else {break;}
你可以通过获胜来达到这一部分。
如果您键入＆＃34; 1＆＃34;游戏将重新开始，并应该清除棋盘。
其他所有输入都将关闭该程序。
比赛将重新启动，但董事会不会清楚。
答案 0 :(得分：1)
你的错误就在这里
while(1){ /**< Play again */
string a1 = "_"; string a2 = "_"; string a3 = "_";
string b1 = "_"; string b2 = "_"; string b3 = "_";
string c1 = "_"; string c2 = "_"; string c3 = "_";
当您已将它们声明为全局时，不应再次声明它们。
您应该将此部分更改为此。因此，您的变量值将随处更新。
while (1){ /**< Play again */
a1 = "_"; a2 = "_"; a3 = "_";
b1 = "_"; b2 = "_"; b3 = "_";
c1 = "_"; c2 = "_"; c3 = "_";
答案 1 :(得分：0)
Mohammad Tayyab的答案对于修复错误是正确的。给他赢，但如果以下也有帮助，那么upvote会很好。你在游戏开始时设置了棋盘，你不需要在任何其他时间设置它。将原始语句更改为：
/* Board variables */
string a1, a2, a3, b1, b2, b3, c1, c2, c3;
再次播放代码：
/**< Play again and clear board */
cout << "\n\nIf you want to play again type ""1""! \n";
cin >> x;
if (x != 1)
{
break;
}
此外，您最好为您的电路板使用矢量/阵列，例如在一个简单的程序中完全摆脱a1 - c3并使用：
int board[9]; // a1 now = board[0], a2 now = board[1] and so on
您现在可以大大简化“转弯验证”功能。
你也在两个玩家的代码中重复这段代码：
if (turni == "a1") { turn = 1; }
else if (turni == "a2") { turn = 2; }
else if (turni == "a3") { turn = 3; }
else if (turni == "b1") { turn = 4; }
else if (turni == "b2") { turn = 5; }
else if (turni == "b3") { turn = 6; }
else if (turni == "c1") { turn = 7; }
else if (turni == "c2") { turn = 8; }
else if (turni == "c3") { turn = 9; }
else { turn = 10; };
使用board [9]数组并将该代码组合到验证函数中（也将名称更改为“movevalidation”），您可以这样做：
bool movevalidation(string move_string, string player_symbol)
{
string moves[9] = { "a1", "a2", "a3", "b1", "b2", "b3", "c1", "c2", "c3" };
int move_int = -1; // -1 means invalid
for (int i = 0; i < 9; ++i)
{
if (move_string == moves[i])
move_int = i;
}
if (moves < 0 || board[move_int] != "_")
{
cout << "Invalid option. Choose again! \n\n";
return false;
}
board[move_int] = player_symbol;
return true;
}
玩家选择 - 移动循环变为：
while (1) {
cout << player1 << " place your X \n\n";
showboard();
cin >> turni;
if(movevalidation(turni))
break;
}
对于两位球员。使用数组，您还需要将明目板代码更改为循环：
while (1) { /**< Play again */
for(int i = 0; i < 9 ++i)
board[i] = "_";
您必须更改您的wincheck以解释使用数组名称替换名称的原因。您可以简单地用板[0]替换a1，用板[1]替换a2，等等。