Question

下面我已经将代码发布到了一个非工作的分而治之的＆＃34; ruby中的乘法方法（带调试打印）。我无法判断它的代码是否破碎，或者Ruby中的怪癖，就像L-shift（＆lt;＆lt;＆lt;＆lt;＆lt;＆lt;＆lt;＆lt;＆quot;）运算符不会将位推入位桶一样;与C ++中的类似操作相比，这是出乎意料的。

代码是否损坏（与原始算法不匹配）或意外行为？

Pseudo code for original algorithm

def multiply(x,y,n, level)
    #print "Level #{level}\n"
    if n == 1
        #print "\tx[#{x.to_s(2)}][#{y.to_s(2)}]\n\n"
        return x*y
    end
    mask = 2**n - 2**(n/2)

    xl = x >> (n / 2)
    xr = x & ~mask
    yl = y >> (n / 2)
    yr = y & ~mask


    print "  #{n} | x =  #{x.to_s(2)} = L[#{xl.to_s(2)}][#{xr.to_s(2)}]R \n"
    print "  #{n} | y =  #{y.to_s(2)} = L[#{yl.to_s(2)}][#{yr.to_s(2)}]R \n"
    #print "\t[#{xl.to_s(2)}][#{yr.to_s(2)}]\n"
    #print "\t[#{xr.to_s(2)}][#{yr.to_s(2)}]\n"
    #print "\t([#{xl.to_s(2)}]+[#{xr.to_s(2)}])([#{yl.to_s(2)}]+[#{yr.to_s(2)}])\n\n"

    p1 = multiply(  xl,     yl,     n/2,    level+1)
    p2 = multiply(  xr,     yr,     n/2,    level+1)
    p3 = multiply(  xl+xr,  yl+yr,  n/2,    level+1)

    return p1 * 2**n + (p3 - p1 - p2) * 2**(n/2) + p2
end


x = 21
y = 22
print "x = #{x} = #{x.to_s(2)}\n"
print "y = #{y} = #{y.to_s(2)}\n"

print "\nDC_multiply\t#{x}*#{y} = #{multiply(x,y,8, 1)} \nregular\t#{x}*#{y} = #{x*y}\n\n "

Answer 1

我不熟悉分而治之算法，但我认为它不包含你在Ruby中可以做的部分。

这是一个快速尝试：

def multiplb(a,b)
  #Break recursion when a or b has one digit
  if a < 10 || b < 10
    a * b
  else
    #Max number of digits of a and b
    n = [a.to_s.length, b.to_s.length].max

    # Steps to split numbers to high and low digits sub-numbers
    # (1) to_s.split('') => Converting digits to string then arrays to ease splitting numbers digits 
    # (2) each_slice => Splitting both numbers to high(left) and low(right) digits groups
    # (3) to_a , map, join, to_i => Simply returning digits to numbers
    al, ar = a.to_s.split('').each_slice(n/2).to_a.map(&:join).map(&:to_i)
    bl, br = b.to_s.split('').each_slice(n/2).to_a.map(&:join).map(&:to_i) 

    #Recursion
    p1 = multiplb(al, bl)
    p2 = multiplb(al + ar, bl + br)
    p3 = multiplb(ar, br)

    p1 * (10**n) + (p2 - p1 - p3) * (10**(n/2)) + p3
  end

end
#Test
puts multiplb(1980, 2315)
# => 4583700  yeah that's correct :)

以下是一些参考资料，以进一步解释部分代码：

查找最多数字=＆gt; How do you find a min / max with Ruby?
将数组拆分为half =＆gt; Splitting an array into equal parts in ruby
将fixnum转换为array =＆gt; Turning long fixed number to array Ruby

希望它能够结束！

乘以分而治之

1 个答案: