Question

int shell (int argc, char *argv[]) {
  char *s = malloc(INPUT_STRING_SIZE+1);            /* user input string */
  tok_t *t;         /* tokens parsed from input */
  int lineNum = 0;
  int fundex = -1;
  pid_t pid = getpid();     /* get current processes PID */
  pid_t ppid = getppid();   /* get parents PID */
  pid_t cpid, tcpid, cpgid;

  init_shell();

  printf("%s running as PID %d under %d\n",argv[0],pid,ppid);

  lineNum=0;

  const int BUF_SIZE = 200;
  char buf[BUF_SIZE];
  getcwd(buf, BUF_SIZE);

  fprintf(stdout, "%d %s: ", lineNum++, buf);
  while ((s = freadln(stdin))){
    char *ptrA, *ptrB;
    ptrA = strstr(s, "<");
    ptrB = strstr(s, ">");
    if (ptrA) {
      *ptrA = '\0';
      ptrA++;
    }
    if (ptrB) {
      *ptrB = '\0';
      ptrB++;
    }
    if (ptrA && ptrB) {

    } else if (ptrA) {

    } else if (ptrB) {
      size_t ln = strlen(ptrB) - 1;
      if (ptrB[ln] == '\n') // get rid of the trailing newline
          ptrB[ln] = '\0';
      int newfd;  /* new file descriptor */
      if ((newfd = open(ptrB, O_CREAT|O_TRUNC|O_WRONLY, S_IRUSR|S_IWUSR|S_IXUSR)) < 0) {
        perror("Can't open outfile file\n");  /* open failed */
        exit(1);
      }
      printf("newfd: %d\n", newfd);
      dup2(newfd, 1);
      printf("Here\n");
    }
    printf("%s\n", s);
    t = getToks(s); /* break the line into tokens */
    fundex = lookup(t[0]); /* Is first token a shell literal */
    if(fundex >= 0) {
      cmd_table[fundex].fun(&t[1]);
    } else {
      char *bin;
      if (get_binary(t[0], &bin) == 0) {
        t[0] = bin;
      }
      pid_t child_pid = fork();
      int exit_code;
      if (child_pid == 0) {
        execv(t[0], &t[0]);
      } else {
        wait(&exit_code);
      }
    }
    getcwd(buf, BUF_SIZE);
    fprintf(stdout, "%d %s: ", lineNum++, buf);
  }
  return 0;
}

我用wc shell.c>test测试我的shell，结果是我在终端上得到一个空行，好像它正在等待我的输入。当我按Enter键时，会出现段错误。如果我注释掉dup2行，那么shell工作正常（但当然没有重定向）。我在Windows上使用Cygwin，如果有帮助的话。

Answer 1

我把错误放在了错误的地方。我分叉后需要复制，但是在我执行之前。

dup2导致程序停止

1 个答案: