ThreadPool中的死锁

Question

我找不到适合Ruby的ThreadPool实现，所以我写了我的（部分基于此处的代码：http://web.archive.org/web/20081204101031/http://snippets.dzone.com:80/posts/show/3276，但改为等待/信号和ThreadPool关闭的其他实现。但是过了一段时间在运行（拥有100个线程并处理大约1300个任务）时，它会在第25行死机 - 它等待那里的新工作。任何想法，为什么会发生？

require 'thread'
begin
  require 'fastthread'
rescue LoadError
  $stderr.puts "Using the ruby-core thread implementation"
end 

class ThreadPool
  class Worker
    def initialize(callback)
      @mutex = Mutex.new
      @cv = ConditionVariable.new
      @callback = callback
      @mutex.synchronize {@running = true}
      @thread = Thread.new do
        while @mutex.synchronize {@running}
          block = get_block
          if block
            block.call
            reset_block
            # Signal the ThreadPool that this worker is ready for another job
            @callback.signal
          else
            # Wait for a new job
            @mutex.synchronize {@cv.wait(@mutex)} # <=== Is this line 25?
          end
        end
      end
    end

    def name
      @thread.inspect
    end

    def get_block
      @mutex.synchronize {@block}
    end

    def set_block(block)
      @mutex.synchronize do
        raise RuntimeError, "Thread already busy." if @block
        @block = block
        # Signal the thread in this class, that there's a job to be done
        @cv.signal
      end
    end

    def reset_block
      @mutex.synchronize {@block = nil}
    end

    def busy?
      @mutex.synchronize {!@block.nil?}
    end

    def stop
      @mutex.synchronize {@running = false}
      # Signal the thread not to wait for a new job
      @cv.signal
      @thread.join
    end
  end

  attr_accessor :max_size

  def initialize(max_size = 10)
    @max_size = max_size
    @workers = []
    @mutex = Mutex.new
    @cv = ConditionVariable.new
  end

  def size
    @mutex.synchronize {@workers.size}
  end

  def busy?
    @mutex.synchronize {@workers.any? {|w| w.busy?}}
  end

  def shutdown
    @mutex.synchronize {@workers.each {|w| w.stop}}
  end
  alias :join :shutdown

  def process(block=nil,&blk)
    block = blk if block_given?
    while true
      @mutex.synchronize do
         worker = get_worker 
         if worker
           return worker.set_block(block)
         else
           # Wait for a free worker
           @cv.wait(@mutex)
         end
      end
    end
  end

  # Used by workers to report ready status
  def signal
    @cv.signal
  end

  private
  def get_worker
    free_worker || create_worker
  end

  def free_worker
    @workers.each {|w| return w unless w.busy?}; nil
  end

  def create_worker
    return nil if @workers.size >= @max_size
    worker = Worker.new(self)
    @workers << worker
    worker
  end
end

Answer 1

好的，所以实现的主要问题是：如何确保没有信号丢失并避免死锁？

根据我的经验，使用条件变量和互斥量很难实现，但使用信号量很容易。事实上，ruby实现了一个名为Queue（或SizedQueue）的对象，可以解决问题。这是我建议的实施：

require 'thread'
begin
  require 'fasttread'
rescue LoadError
  $stderr.puts "Using the ruby-core thread implementation"
end

class ThreadPool
  class Worker
    def initialize(thread_queue)
      @mutex = Mutex.new
      @cv = ConditionVariable.new
      @queue = thread_queue
      @running = true
      @thread = Thread.new do
        @mutex.synchronize do
          while @running
            @cv.wait(@mutex)
            block = get_block
            if block
              @mutex.unlock
              block.call
              @mutex.lock
              reset_block
            end
            @queue << self
          end
        end
      end
    end

    def name
      @thread.inspect
    end

    def get_block
      @block
    end

    def set_block(block)
      @mutex.synchronize do
        raise RuntimeError, "Thread already busy." if @block
        @block = block
        # Signal the thread in this class, that there's a job to be done
        @cv.signal
      end
    end

    def reset_block
      @block = nil
    end

    def busy?
      @mutex.synchronize { !@block.nil? }
    end

    def stop
      @mutex.synchronize do
        @running = false
        @cv.signal
      end
      @thread.join
    end
  end

  attr_accessor :max_size

  def initialize(max_size = 10)
    @max_size = max_size
    @queue = Queue.new
    @workers = []
  end

  def size
    @workers.size
  end

  def busy?
    @queue.size < @workers.size
  end

  def shutdown
    @workers.each { |w| w.stop }
    @workers = []
  end

  alias :join :shutdown

  def process(block=nil,&blk)
    block = blk if block_given?
    worker = get_worker
    worker.set_block(block)
  end

  private

  def get_worker
    if !@queue.empty? or @workers.size == @max_size
      return @queue.pop
    else
      worker = Worker.new(@queue)
      @workers << worker
      worker
    end
  end

end

这是一个简单的测试代码：

tp = ThreadPool.new 500
(1..1000).each { |i| tp.process { (2..10).inject(1) { |memo,val| sleep(0.1); memo*val }; print "Computation #{i} done. Nb of tasks: #{tp.size}\n" } }
tp.shutdown

Answer 2

您可以尝试work_queue gem，用于协调生产者和工作线程池之间的工作。

Answer 3

我在这里略有偏见，但我建议用一些过程语言和模型检查它。例如，可自由使用的工具是mCRL2工具集（使用基于ACP的语言），Mobility Workbench（pi-calculus）和Spin（PROMELA）。

否则我建议删除对问题不重要的每一段代码，并找出发生死锁的最小情况。我怀疑它是100个线程和1300个任务对于解决僵局至关重要。对于较小的情况，您可以添加一些调试打印，提供足够的信息来解决问题。

Answer 4

好的，问题似乎出现在你的ThreadPool＃signal方法中。可能发生的事情是：

1 - 你的所有工人都很忙，你试图处理一份新工作

2 - 第90行得到一个零工人

3 - 一个工人被释放并发出信号，但由于ThreadPool没有等待它，信号就会丢失

4 - 即使有一名自由工作人员，你也会排在第95行，等待。

这里的错误是，即使没有人在听，也可以向自由工作者发出信号。这个ThreadPool＃signal方法应该是：

def signal
     @mutex.synchronize { @cv.signal }
end

并且Worker对象中的问题是相同的。可能会发生的是：

1 - 工人刚刚完成了一份工作

2 - 检查（第17行）是否有作业等待：没有

3 - 线程池发送新作业并发出信号......但信号丢失

4 - 工作人员等待信号，即使它被标记为忙碌

您应该将初始化方法设为：

def initialize(callback)
  @mutex = Mutex.new
  @cv = ConditionVariable.new
  @callback = callback
  @mutex.synchronize {@running = true}
  @thread = Thread.new do
    @mutex.synchronize do
      while @running
        block = get_block
        if block
          @mutex.unlock
          block.call
          @mutex.lock
          reset_block
          # Signal the ThreadPool that this worker is ready for another job
          @callback.signal
        else
          # Wait for a new job
          @cv.wait(@mutex)
        end
      end
    end
  end
end

接下来，不应再同步Worker＃get_block和Worker＃reset_block方法。这样，您就不能在块测试和等待信号之间为工作人员分配块。

Answer 5

多年来，顶级评论者的代码提供了很多帮助。在这里，它针对ruby 2.x进行了更新，并通过线程识别进行了改进。那有什么改善？当每个线程都有一个ID时，可以用存储任意信息的数组组成ThreadPool。一些想法：

• 无数组：典型ThreadPool用法。即使使用GIL，它也可以使死代码易于编码，并且对于诸如高容量Web爬网之类的高延迟应用程序非常有用，
• 线程池和数组的大小取决于CPU的数量：易于派生进程以使用所有CPU，
• 线程池和数组的大小取决于资源数量：例如，每个数组元素代表一个实例池中的一个处理器，因此，如果您有10个实例，每个实例具有4个CPU，则TP可以管理40个子进程的工作。

对于这最后两个，不要考虑线程在做工作，而要考虑ThreadPool管理正在工作的子流程。管理任务是轻量级的，并且与关心GIL的子流程结合在一起时。

使用此类，您可以用大约一百行代码来编写基于集群的MapReduce！这段代码很简短，虽然有点让人费解。希望对您有所帮助。

# Usage:
#
#   Thread.abort_on_exception = true # help localize errors while debugging
#   pool = ThreadPool.new(thread_pool_size)
#   50.times {|i|
#     pool.process { ... }
#     or
#     pool.process {|id| ... } # worker identifies itself as id
#   }
#   pool.shutdown()

class ThreadPool

  require 'thread'

  class ThreadPoolWorker

    attr_accessor :id

    def initialize(thread_queue, id)
      @id = id # worker id is exposed thru tp.process {|id| ... }
      @mutex = Mutex.new
      @cv = ConditionVariable.new
      @idle_queue = thread_queue
      @running = true
      @block = nil
      @thread = Thread.new {
        @mutex.synchronize {
          while @running
            @cv.wait(@mutex) # block until there is work to do
            if @block
              @mutex.unlock
              begin
                @block.call(@id)
              ensure
                @mutex.lock
              end
              @block = nil
            end
            @idle_queue << self
          end
        }
      }
    end

    def set_block(block)
      @mutex.synchronize {
        raise RuntimeError, "Thread is busy." if @block
        @block = block
        @cv.signal # notify thread in this class, there is work to be done
      }
    end

    def busy?
      @mutex.synchronize { ! @block.nil? }
    end

    def stop
      @mutex.synchronize {
        @running = false
        @cv.signal
      }
      @thread.join
    end

    def name
      @thread.inspect
    end
  end


  attr_accessor :max_size, :queue

  def initialize(max_size = 10)
    @process_mutex = Mutex.new
    @max_size = max_size
    @queue = Queue.new # of idle workers
    @workers = []      # array to hold workers

    # construct workers
    @max_size.times {|i| @workers << ThreadPoolWorker.new(@queue, i) }

    # queue up workers (workers in queue are idle and available to
    # work).  queue blocks if no workers are available.
    @max_size.times {|i| @queue << @workers[i] }

    sleep 1 # important to give threads a chance to initialize
  end

  def size
    @workers.size
  end

  def idle
    @queue.size
  end

  # are any threads idle

  def busy?
    # @queue.size < @workers.size
    @queue.size == 0 && @workers.size == @max_size
  end

  # block until all threads finish

  def shutdown
    @workers.each {|w| w.stop }
    @workers = []
  end

  alias :join :shutdown

  def process(block = nil, &blk)
    @process_mutex.synchronize {
      block = blk if block_given?
      worker = @queue.pop # assign to next worker; block until one is ready
      worker.set_block(block) # give code block to worker and tell it to start
    }
  end


end