Question

所以我是编码方面的新手，这是我的第一个项目，有人可以审查一下，并告诉我可以在哪里改进代码吗？

username = input("Please insert your username ") # enter username

password = input("Please insert your password ") #Enter password

tries = 0 #The number of tries the user gets

print("Please re-login")

while tries < 3 :

  input_username = input("Please re-input your username: ")

  input_password = input("Please re-input your password: ")

  if input_username == username and input_password == password :
    print("You have logged in !") 
    break

  if input_username != username or input_password != password :

    if input_password != password :
      print("Wrong password, please re-enter your password")

    elif input_username != username :
      print("Wrong username, please re-enter your username")

    else :
      print("Please enter your username and password")

 tries += 1

if not tries < 3 :
  print("Out of tries, please try again later")

这是我的第一个项目，对此我非常陌生，非常感谢您的评论

Answer 1

此程序一切正常。但是您可以使其变得更好，更快，更易读。

即使我的代码看起来很大，您也应该能够了解发生了什么。

这是代码：

def login(username, password):
    """
    Attempts to Verify Account.
    parameters:
        - username: get stored Username entered in Create Account.
        - password: get stored Password entered in Create Account.
    """
    print("\n--Please Login to Your Account!--\n")
    _username = input("Username: ") # Asks user to enter username to verify.
    _password = input("Password: ") # Asks user to enter password to verify.

    if username == _username and password == _password: # Checks if username and password matches.
        return True

    return False # if not verifed, returns False by default.

def main():
    """
    Main function for program, Handles 'Create Account' and 'Login'.
    """
    print("--Create Account--\n")
    username = input("Your Name: ")
    password = input("Password: ")

    for i in range(5): # Run 'login' 5 times using 'for' Loop to allow total 5 attempts.
        if login(username, password): # If successfull, the 'main' function returns this and breaks the Loop.
            return print("Logged In Successfully!")
        else:
            print("Woops, Wrong Username or Password!")
        
    # If failed to login/run out of Attempts.
    return print("\nSorry, We Can't Verify it's you!\n")

# Calling the main function. 
main()

不要只是看它而感到压力！要理解此代码，您需要了解的只是详细的基本python（在本例中为“条件和函数”）。

使用用户名和密码登录

1 个答案: