我有一个简单的C代码。
main.c
int main() {
FILE *stream = fopen("../input.txt", "r");
cube test_cube;
cube_initialization(&test_cube, stream);
/* and some code with free memory which is not needed to understand the situation */
}
cube.c
/* just the function valgrind complains about */
void cube_initialization(cube *cube, FILE *input_file) {
int side_length;
char buffer[BUF_SIZE];
char waste_buffer[BUF_SIZE];
fgets(buffer, BUF_SIZE, input_file);
fgets(waste_buffer, BUF_SIZE, input_file); /* empty line */
side_length = (int) strtol(buffer, NULL, 10);
cube->side_length = side_length;
cube->cube_array = malloc(side_length * sizeof(int **));
int z;
for (z = 0; z < side_length; z++) {
cube->cube_array[z] = malloc(side_length * sizeof(int *));
int y;
for (y = 0; y < side_length; y++) {
cube->cube_array[z][y] = malloc(side_length * sizeof(int));
}
}
}
和valgrind输出
==8251== Invalid read of size 4
==8251== at 0x48F3727: fgets (iofgets.c:47)
==8251== by 0x1093C2: cube_initialization (cube.c:11)
==8251== by 0x10928D: main (main.c:11)
==8251== Address 0x0 is not stack'd, malloc'd or (recently) free'd
==8251==
==8251==
==8251== Process terminating with default action of signal 11 (SIGSEGV)
==8251== Access not within mapped region at address 0x0
==8251== at 0x48F3727: fgets (iofgets.c:47)
==8251== by 0x1093C2: cube_initialization (cube.c:11)
==8251== by 0x10928D: main (main.c:11)
==8251== If you believe this happened as a result of a stack
==8251== overflow in your program's main thread (unlikely but
==8251== possible), you can try to increase the size of the
==8251== main thread stack using the --main-stacksize= flag.
==8251== The main thread stack size used in this run was 8388608.
==8251==
==8251== HEAP SUMMARY:
==8251== in use at exit: 0 bytes in 0 blocks
==8251== total heap usage: 1 allocs, 1 frees, 488 bytes allocated
==8251==
==8251== All heap blocks were freed -- no leaks are possible
==8251==
==8251== For lists of detected and suppressed errors, rerun with: -s
==8251== ERROR SUMMARY: 1 errors from 1 contexts (suppressed: 0 from 0)
Segmentation fault (core dumped)
我不明白为什么Valgrind抱怨fgets()
。我从文件中读取数据,并使用fgets
和指向大缓冲区(256)的指针,但它仅需要我读取大约1-6个符号的短行(我需要fgets,因为它在找到\ n时会停止行结束)。也许问题出在事实fgets()尝试读取256个符号的行,并且在1-5和'\ n'之后停止?
答案 0 :(得分:3)
Valgrind抱怨非法访问地址0x0
:
地址0x0未堆栈,未分配或(最近)未释放
在您的fgets()
通话中
fgets(buffer, BUF_SIZE, input_file);
buffer
参数很好,因为它是在堆栈中分配的。唯一负责的是来自input_file
的{{1}}参数。该参数是从main()
调用获得的流。在传递给fopen()
之前,您没有检查它!
检查它,然后了解为什么它返回NULL(可能您尝试打开一个不存在的路径)。
cube_initialization()
答案 1 :(得分:3)
Valgrind抱怨fgets()
中的读取无效。问题不太可能是目标数组的大小,这可能会触发无效写入,但实际上是BUF_SIZE
个字节的数组,您将其记录为合理的256值。问题很可能与流指针,根据Valgrind报告,该指针可以为空:
Address 0x0 is not stack'd, malloc'd or (recently) free'd`
您应该在代码中修复潜在的未定义行为:
fopen()
是否返回有效的FILE*
,以避免当您尝试从input_file
读取内容时发生未定义的行为。fgets()
成功(不返回NULL
),以避免从目标数组读取数据时出现未定义的行为。