“无效的比较器”:重载“ <”运算符时发生错误

时间:2019-06-20 06:48:19

标签: c++ sorting operator-overloading

我有一个需要排序的课程。使用此类的向量,排序时会出现错误“无效比较器”。

我在课堂上超载了“ <”运算符,并且遵循了严格的弱排序

如本post中所述。

sort需要严格的弱排序。您的comparator不是一个。除其他外,对于严格的弱排序,comp(x, x)必须为 false

这是我的代码:

bool outlierScore::operator<(const outlierScore& other) {
    if (score < other.score)
        return score < other.score;
    else if (coreDistance < other.coreDistance)
        return coreDistance < other.coreDistance;
    else if (id < other.id)
        return id < other.id;
    else
        return false;
}

这是重载的运算符函数,它的作用实际上是尝试按离群分数按升序排序,其中核心距离用于中断 离群值得分关系和用于打破核心距离关系的ID。

堆栈跟踪显示了此阶段出现的错误。

template <class _Pr, class _Ty1, class _Ty2>
constexpr bool _Debug_lt_pred(_Pr&& _Pred, _Ty1&& _Left, _Ty2&& _Right) _NOEXCEPT_COND(
    noexcept(_Pred(_Left, _Right))
    && noexcept(_Pred(_Right, _Left))) { // test if _Pred(_Left, _Right) and _Pred is strict weak ordering
    const auto _Result = static_cast<bool>(_Pred(_Left, _Right));
    if (_Result) {
        _STL_VERIFY(!_Pred(_Right, _Left), "invalid comparator");
    }

    return _Result;
}

我找不到问题。任何帮助都会很棒。

最小可复制示例

class outlierScore
{
private:
    double coreDistance;
public:
    double score;
    int id;
}
vector <vector<double>> x = {
                {0,0.889528896739179,0.536626916823739},
                {1,1.30766765703343,0.684794721931497},
                {2,0.936505261432846,0.559870334496815}
            };
vector<outlierScore> test;
test.push_back(outlierScore(x[0][2], x[0][1], x[0][0]));
test.push_back(outlierScore(x[1][2], x[1][1], x[1][0]));
test.push_back(outlierScore(x[2][2], x[2][1], x[2][0]));

包含看起来像如下的outlierScore对象 {id, coreDistance, score}

出现错误的地方: sort(test.begin(), test.end());

2 个答案:

答案 0 :(得分:10)

您的实现不正确。

android {
  ...
  ...
  dexOptions {
    incremental true
    javaMaxHeapSize "4G"
  }
  ...
  ...
}

bool outlierScore::operator<(const outlierScore& other) const {
    return (score < other.score) ||
           (score == other.score && coreDistance < other.coreDistance) ||
           (score == other.score && coreDistance == other.coreDistance && id < other.id);
}

答案 1 :(得分:10)

除了方法不是const之外,此运算符不满足严格的弱排序。

bool outlierScore::operator<(const outlierScore& other) {
    if (score < other.score)
        return score < other.score;
    else if (coreDistance < other.coreDistance)
        return coreDistance < other.coreDistance;
    else if (id < other.id)
        return id < other.id;
    else
        return false;
}

例如,如果所有字段都是整数。

a.score = 0 ; a.coreDistance = 1
b.score = 1 ; b.coreDistance = 0

对于这些值,以下应该为false,但返回true:

a < b && b < a

您还应该检查是否相等:

bool outlierScore::operator<(const outlierScore& other) {
    if (score != other.score)
        return score < other.score;
    else if (coreDistance != other.coreDistance)
        return coreDistance < other.coreDistance;
    else 
        return id < other.id;
}