我有以下rest控制器,该控制器接收请求,将请求转换为JSON字符串,然后将它们放入并发队列。
我想从此队列中创建一个Flux并订阅它。
不幸的是,它不起作用。
我在这里做什么错了?
@RestController
public class EventController {
private final ObjectMapper mapper = new ObjectMapper();
private final FirehosePutService firehosePutService;
private ConcurrentLinkedQueue<String> events = new ConcurrentLinkedQueue<>();
private int batchSize = 10;
@Autowired
public EventController(FirehosePutService firehosePutService) {
this.firehosePutService = firehosePutService;
Flux<String> eventFlux = Flux.create((FluxSink<String> sink) -> {
String next;
while (( next = events.poll()) != null) {
sink.next(next);
}
});
eventFlux.publish().autoConnect().subscribe(new BaseSubscriber<String>() {
int consumed;
List<String> batchOfEvents = new ArrayList<>(batchSize);
@Override
protected void hookOnSubscribe(Subscription subscription) {
request(batchSize);
}
@Override
protected void hookOnNext(String value) {
batchOfEvents.add(value);
consumed++;
if (consumed == batchSize) {
batchOfEvents.addAll(events);
log.info("Consume {} elements. Size of batchOfEvents={}", consumed, batchOfEvents.size());
firehosePutService.saveBulk(batchOfEvents);
consumed = 0;
batchOfEvents.clear();
events.clear();
request(batchSize);
}
}
});
}
@GetMapping(value = "/saveMany", produces = "text/html")
public ResponseEntity<Void> saveMany(@RequestParam MultiValueMap<String, String> allRequestParams) throws JsonProcessingException {
Map<String, String> paramValues = allRequestParams.toSingleValueMap();
String reignnEvent = mapper.writeValueAsString(paramValues);
events.add(reignnEvent);
return new ResponseEntity<>(HttpStatus.OK);
}
}
答案 0 :(得分:1)
首先,您使用poll
方法。它没有阻塞,如果队列为空,则返回null
。您会循环收集直到第一个null
(即while (next != null)
),所以您的代码几乎立即退出循环,因为开始时队列为空。您必须将poll
替换为take
,这会阻塞并将等到元素可用。
第二,从队列中删除事件时,将调用hookOnNext
。但是,您尝试使用batchOfEvents.addAll(events);
再次读取事件。此外,您还清除了所有未决事件events.clear();
我建议您从events
方法中删除对hookOnNext
集合的所有直接访问。
您为什么在这里完全使用Flux?似乎过于复杂。您可以在这里使用普通线程
@Autowired
public EventController(FirehosePutService firehosePutService) {
this.firehosePutService = firehosePutService;
Thread persister = new Thread(() -> {
List<String> batchOfEvents = new ArrayList<>(batchSize);
String next;
while (( next = events.take()) != null) {
batchOfEvents.add(value);
if (batchOfEvents.size() == batchSize) {
log.info("Consume {} elements. Size of batchOfEvents={}", consumed, batchOfEvents.size());
firehosePutService.saveBulk(batchOfEvents);
batchOfEvents.clear();
}
}
});
persister.start();
}