在检查程序中的内存泄漏时出现valgrind错误。 在分配/重新分配内存时,该错误发生在我的cutString函数中的某个位置,但是我不确定自己在做什么错。
我分配的内存不正确吗?
这是valgrind的输出:
$ valgrind --leak-check=full --track-origins=yes ./cutstring
==7017== Memcheck, a memory error detector
==7017== Copyright (C) 2002-2017, and GNU GPL'd, by Julian Seward et al.
==7017== Using Valgrind-3.14.0 and LibVEX; rerun with -h for copyright info
==7017== Command: ./cutstring
==7017==
Hell
==7017==
==7017== HEAP SUMMARY:
==7017== in use at exit: 5 bytes in 1 blocks
==7017== total heap usage: 3 allocs, 2 frees, 1,042 bytes allocated
==7017==
==7017== 5 bytes in 1 blocks are definitely lost in loss record 1 of 1
==7017== at 0x4839D7B: realloc (vg_replace_malloc.c:826)
==7017== by 0x109205: cutString (in cutstring)
==7017== by 0x109228: main (in cutstring)
==7017==
==7017== LEAK SUMMARY:
==7017== definitely lost: 5 bytes in 1 blocks
==7017== indirectly lost: 0 bytes in 0 blocks
==7017== possibly lost: 0 bytes in 0 blocks
==7017== still reachable: 0 bytes in 0 blocks
==7017== suppressed: 0 bytes in 0 blocks
==7017==
==7017== For counts of detected and suppressed errors, rerun with: -v
==7017== ERROR SUMMARY: 1 errors from 1 contexts (suppressed: 0 from 0)
这是我的代码:
#include <string.h>
#include <stdio.h>
#include <stdlib.h>
char *cutString(char *str, char del)
{
char *new_string = (char*) malloc(strlen(str) * sizeof(char) + 1);
int i = 0;
while (str[i] != del)
{
new_string[i] = str[i];
i++;
}
new_string[i] = '\0';
new_string = (char*) realloc(new_string, strlen(new_string) + 1);
return new_string;
free(new_string);
}
int main()
{
printf("%s\n", cutString("Hello World!", 'o'));
return 0;
}
我猜我没有正确使用realloc,但我不知道为什么。
一些帮助将不胜感激,谢谢!
答案 0 :(得分:1)
cutString
必须分配内存并返回它。当然(幸运的是)没有到达无条件return
之后的所有语句。
return new_string;
free(new_string); // never executed
}
幸运的是!因为否则您将返回未分配的内存:未定义的行为。
这里的问题是,您要将返回的值传递给printf
,但是在调用之后,指针丢失了。您必须存储它才能释放它,但是仅在打印后。
int main()
{
char *s = cutString("Hello World!", 'o'));
printf("%s\n", s);
free(s);
return 0;
}
在C语言中,无法在不产生内存泄漏的情况下流水线向printf
分配内存的函数。其他语言具有垃圾收集器或对象析构函数,但没有C。