为什么sinon不能代替实际的函数调用?

时间:2018-09-19 22:45:33

标签: node.js unit-testing twilio sinon stub

我的功能是:

const PhoneNumber = require('awesome-phonenumber');
const twilio = require('twilio')(process.env.TWILIO_ACCOUNT_SID, process.env.TWILIO_AUTH_TOKEN);
const { twiml } = require('twilio');

exports.incoming = (requestBody) => {
  const MessagingResponse = twiml.MessagingResponse;
  const VoiceResponse = twiml.VoiceResponse;
  const pn = new PhoneNumber(requestBody.Body, 'US');
    return global.db.Conference.create({})
      .then((dbCreate) => {
        conferenceId = dbCreate.id;
        // Call originator
        return twilio.calls.create({
          to: requestBody.From,
          from: requestBody.To,
          url: `${process.env.API_URL}/calls/conference?id=${conferenceId}`
        });
      })

我的测试是:

const _ = require('lodash');
const sinon = require('sinon');
const twilio = require('twilio')(process.env.TWILIO_ACCOUNT_SID, process.env.TWILIO_AUTH_TOKEN);
const { twiml } = require('twilio');

const SmsController = require('../../../controllers/sms');
const twilioIncomingSmsReq = require('../../mocks/twilioIncomingSmsReq');

describe.only('Sms Controller', () => {
  let messagingResponseMessageStub;
  let conferenceCreateStub;

  beforeEach(() => {
    messagingResponseMessageStub = sinon.stub(twiml.MessagingResponse.prototype, 'message').returns(true);
    conferenceCreateStub = sinon.stub(global.db.Conference, 'create').resolves({ id: 1 });

    return;
  });

  afterEach(() => {
    messagingResponseMessageStub.restore();
    conferenceCreateStub.restore();
    return;
  });

  it.only('should call the originator and recipient', () => {
    let requestBody = _.clone(twilioIncomingSmsReq);
    console.log(twilio.calls);
    let twilioDialStub = sinon.stub(twilio.calls, 'create').resolves(true);
    console.log(twilio.calls);

    return SmsController.incoming(requestBody)
      .then(() => {
        sinon.assert.calledWith(twilioDialStub, {
          to: requestBody.From,
          from: requestBody.To,
          url: `${process.env.API_URL}/calls?id=1`
        });

        sinon.assert.calledWith(twilioDialStub, {
          to: '+number',
          from: requestBody.From,
          url: `${process.env.API_URL}/calls?id=1`
        });

        twilioDialStub.restore();

        return;
      });
  });
});

但是在我的代码中,实际的twilion.calls.create函数被调用。不是存根。我在做什么错了?

1 个答案:

答案 0 :(得分:1)

twilio引用这些模块中的不同对象。 require('twilio')是出厂功能。即使使用相同的参数require('twilio')(...) !== require('twilio')(...)调用它,也有望创建一个新对象。

考虑导出twilio实例,至少出于测试目的:

const twilio = require('twilio')(process.env.TWILIO_ACCOUNT_SID, 
...
exports.twilio = twilio;