Question

我为练习Java技能而编写的代码有问题。我正在尝试写象棋游戏。无论如何，在我的项目中，我有一个名为ChessGUI的类，其中包含GUI和我需要玩的方法（多人游戏）。我愿意稍后将代码更改为MVC模式，以便于阅读/编辑/理解。我有一个名为Figure的抽象类，并将其扩展为12个类（每种颜色6个图）：

但是，在我的ChessGui类中，我有一个称为CheckAvailableSquares（）的方法，只要在板上选择了一块（通过鼠标单击）时，就会调用该方法，以在板上向我显示可以移动所选块的可用正方形

 private void CheckAvailableSquares(Figure figure){
    for (int row = 0; row < 8; row++){
        for (int col = 0; col < 8; col++){
            if (row == figure.getRowPos() && col == figure.getColPos()) //bypass the actual square where my piece stands
                continue;
            if (figure.isValidMove(board,figure.getRowPos(), figure.getColPos(),row,col)){
                board[row][col].setBackground(Color.GREEN);
            }
        }
    }
}

在每个图形子类中，都有一个名为isValidMove（）的方法，该方法将成为零件的当前位置和所需位置，并在移动有效时返回布尔值。

您知道pawn的第一次移动每次可以移动2个正方形，这就是为什么我向WhitePawn＆BlackPawn类中添加了一个名为firstMovePlayed的布尔属性的原因。它具有错误的值，并且每当调用isMoveValid（）方法且所需的移动有效时，都应将其更改为true。像这样：

public class WhitePawn extends Figure {
private boolean firstMovePlayed = false;

public WhitePawn(){
    super.setColor(Color.WHITE);
}

@Override
public boolean isValidMove(Square[][] board, int currentRow, int currentCol, int wantedRow, int wantedCol){
    int rowDelta = currentRow - wantedRow; //no Math.abs because a pawn can't move backwards.
    int colDelta = Math.abs(wantedCol - currentCol);

    //if we have an own piece on the wanted square
    if (!board[wantedRow][wantedCol].isEmpty() && board[wantedRow][wantedCol].getFigure().getColor().equals(Color.WHITE)) {
        return false;
    }
    //on the first move a pawn can move 2 square at a time, and when moving 2 square he can't capture. A pawn can't move two square if there is another piece in the way. TODO: en passant ??????
    if (rowDelta == 2 && colDelta == 0 && board[wantedRow][wantedCol].isEmpty() && board[wantedRow + 1][wantedCol].isEmpty() && !firstMovePlayed) {
        firstMovePlayed = true;
        return true;
    }
    else if (rowDelta == 1 && colDelta == 1 && !board[wantedRow][wantedCol].isEmpty()) { //capture
        if (board[wantedRow][wantedCol].getFigure().getColor() != board[currentRow][currentCol].getFigure().getColor())
            firstMovePlayed = true;
        return true;
    }
    else if (rowDelta == 1 && colDelta == 0 && board[wantedRow][wantedCol].isEmpty()) { //moving one square forward without a capture
        firstMovePlayed = true;
        return true;
    }
    //those were the only possibilities to move a pawn
    return false;
}}

问题是： 每当我调用CheckAvailableSquares（）方法来检查正方形的可用性时，firstMovePlayed布尔值都将设置为true！

很抱歉您花了太多时间，但我真的不明白：/

下面是ChessGui类中的其余相关代码：

 public void actionPerformed(ActionEvent e) {
    //looking for the square which fired the ActionListener:
    for (int i = 0; i < 8; i++){
        for (int j = 0; j < 8; j++){
            if(board[i][j] == e.getSource()){
                processClick(i, j);
            }
        }
    }
}
private void processClick(int i, int j){
    if(bufRow == 99 && bufCol == 99){                        //select a figure to move and wait for the next click
        if (board[i][j].isEmpty()) {                              //if there is no figure on the square that has benn clicked
            System.out.println("no Figures on this square");
            return;
        }
        else {//save the chosen square (button) in buffers so that we can move it later.
            //decide who's turn it is:
            if (board[i][j].getFigure().getColor().equals(Color.WHITE) && !whiteToPlay)
                System.out.println("It's black's turn to play!");
            else if (board[i][j].getFigure().getColor().equals(Color.BLACK) && !blackToPlay)
                System.out.println("It's white's turn to play!");
            if ((board[i][j].getFigure().getColor().equals(Color.WHITE) && whiteToPlay) || board[i][j].getFigure().getColor().equals(Color.BLACK) && blackToPlay) {
                board[i][j].setHighleightedIcon(board[i][j].getFigure().getHilightedIcon()); //change the icon of the chosen square
                bufRow = i;     //save the chosen figure to move it later
                bufCol = j;
                System.out.println("Selectd figure on Raw: " + bufRow + " Column: " + bufCol);
                switchTurns();
                CheckAvailableSquares(board[bufRow][bufCol].getFigure());
            }
        }
    }
    else
        moveFigure(i, j);
}
private void moveFigure(int wantedRow, int wantedCol) {
    if (board[bufRow][bufCol].getFigure().isValidMove(board, bufRow, bufCol, wantedRow, wantedCol)) {            // check if the move is valid for the figure
        // if (board[wantedRow][wantedCol].isEmpty()) {                                                                                 //if the wanted square is empty (not a capture)
        //move the figure to the wanted square after deleting it from the old square
        board[wantedRow][wantedCol].setFigure(board[bufRow][bufCol].getFigure());
        board[wantedRow][wantedCol].setSquareIcon(board[bufRow][bufCol].getFigure().getIcon());
        board[bufRow][bufCol].emptySquare();
        //update the location of the piece
        board[wantedRow][wantedCol].getFigure().setNewPos(wantedRow,wantedCol);
        System.out.println("Moved [" + bufRow + ", " + bufCol + "] To: [" + wantedRow + ", " + wantedCol + "].");
        //reset the buffers
        bufRow = 99;
        bufCol = 99;
        resetSquaresColors();
        /*}
        else if (!board[wantedRow][wantedCol].isEmpty()){                                                                                         //if it's a capture
            if(board[wantedRow][wantedCol].getFigure().getColor() != board[bufRow][bufCol].getFigure().getColor()) {      //can't capture own pieces!
                board[wantedRow][wantedCol].setFigure(board[bufRow][bufCol].getFigure());
                board[wantedRow][wantedCol].setSquareIcon(board[wantedRow][wantedCol].getFigure().getIcon());
                board[bufRow][bufCol].emptySquare();
                //update the location of the piece
                board[wantedRow][wantedCol].getFigure().setRowPos(wantedRow);
                board[wantedRow][wantedCol].getFigure().setColPos(wantedCol);
                System.out.println("Moved [" + bufRow + ", " + bufCol + "] To: [" + wantedRow + ", " + wantedCol + "].");
                //reset the buffers
                bufRow = 99;
                bufCol = 99;
            }
        }*/
    } else {      //if it's not a valid move
        board[bufRow][bufCol].setIcon(board[bufRow][bufCol].getFigure().getIcon());
        //reset the buffers
        bufRow = 99;
        bufCol = 99;
        resetSquaresColors();
        System.out.println("Not a valid move");
        switchTurns();
    }
}
private void CheckAvailableSquares(Figure figure){
    for (int row = 0; row < 8; row++){
        for (int col = 0; col < 8; col++){
            if (row == figure.getRowPos() && col == figure.getColPos()) //bypass the actual square where my piece stands
                continue;
            if (figure.isValidMove(board,figure.getRowPos(), figure.getColPos(),row,col)){
                Square sqr = board[row][col];
                if (sqr.isEmpty()) //if the square is empty
                    sqr.setAvailableIcon(new ImageIcon("Icons/available_square.png"));
                else //if there is a piece on the square
                    sqr.setAvailableIcon(sqr.getFigure().getAvailableIcon());
            }
        }
    }
}

非常感谢并原谅我的英语不好！

Java下国际象棋游戏设计对OOP的误解

0 个答案: