TclOO:类记录器mixin

时间:2018-05-15 14:07:34

标签: class logging tcl mixins

请推荐TclOO类记录器mixin / trait。

当用作类记录器时,tcllib 1.19中包含记录器:

#!/usr/bin/env tclsh
package require logger
package require logger::utils
::oo::class create Main {
    variable log
    constructor {} {
        set this_inst [namespace current]
        set this_klaz [info object class $this_inst]
        set log [::logger::init $this_klaz]
        ::logger::utils::applyAppender \
        -appender "console" \
        -appenderArgs {-conversionPattern {%d \[%p\] \[%M\] %m}} \
        -serviceCmd $log
    }
    method invoke {} {
        ${log}::info "hello"
    }
}
set main [Main new]
$main invoke

生成对象命名空间:

2018/05/15 08:54:43 [info] [::oo::Obj12] hello

而不是类/方法命名空间:

2018/05/15 08:54:43 [info] [::Main::invoke] hello

2 个答案:

答案 0 :(得分:1)

这是loggerUtils.tcl::logger::utils::createLogProc中的错误,因为%M替换不知道TclOO。如果是,它将不会使用调用该方法的对象的名称,而是使用该方法的名称。 (似乎它被设计为与[incr Tcl]一起使用, 命名方法就像你想要的那样。)

理想情况下,您每个类都要设置一次记录器,而不是每个实例设置一次。以下是您的表现方式:

package require logger
package require logger::utils
::oo::class create Main {
    variable log
    self {
        variable log
        method init {} {
            set log [::logger::init [self]]
            ::logger::utils::applyAppender \
                -appender "console" \
                -appenderArgs {-conversionPattern {%d \[%p\] \[%M\] %m}} \
                -serviceCmd $log
        }
        method logger {} {return $log}
    }
    constructor {} {
        set log [[self class] logger]
    }
    method invoke {} {
        ${log}::info "hello"
    }
}
Main init
set main [Main new]
$main invoke

但这并没有解决这个问题。这实际上是因为它查找%M替换的值,如下所示:

    if {[info level] < 2} {
        set method "global"
    } else {
        set method [lindex [info level -1] 0]
    }

虽然它可能应该做更像这样的事情:

    if {[info level] < 2} {
        set method "global"
    } elseif {[uplevel 1 {namespace which self}] == "::oo::Helpers::self"} {
        set method [uplevel 1 {string cat [self class] "::" [self method]}]
    } else {
        set method [lindex [info level -1] 0]
    }

答案 1 :(得分:0)

模式#1:提供命令到方法的转发器。

密新:

::oo::class create WithLogger {
    self {
        variable klaz_log
        method init_log {} {
             variable klaz_log [::logger::init [self]]
            ::logger::utils::applyAppender ... $klaz_log
        }
        method klaz_log {} {
            return $klaz_log
        }
    }
    method withLogger {} {
        set this_klaz [self class]
        $this_klaz init_log
        set klaz_log [$this_klaz klaz_log]
        {*}"proc log {level args} {tailcall ${klaz_log}::\${level} {*}\$args}"
    }
}

用法:

::oo::class create Main {
    mixin -append WithLogger
    constructor {} {
        my withLogger ; # needs setup
    }
    method invoke {} {
        log info "hello" ; # uses command-to-method forwarder
    }
}

set main [Main new]
$main invoke

输出:

2018/05/16 15:08:59 [info] [::Main::invoke] hello