Question

我有一个ASP.NET Core应用程序，其中包含从BaseController继承的各种控制器。我需要实现一些基本的基准测试，使用秒表，它将从动作方法的开始处开始并在结束时完成。我可以通过appsettings.json打开和关闭此功能。 ILogger中有一个Startup.cs工厂：

public void Configure ( IApplicationBuilder app, IHostingEnvironment env,     ILoggerFactory loggerFactory ) {
        loggerFactory.AddConsole( Configuration.GetSection( "Logging" ) );
        loggerFactory.AddDebug();
        loggerFactory.AddFile(@"C:\Logs\Portal\portal-{Date}.txt");

我已将ILogger添加到我的BaseController（下方），我希望这将通过DI提供。鉴于上述情况，我是否可以使用此命令将我的基准测试结果记录到与启动文件不同的位置？我想要一个包含某些列的.csv文件，我可以在其中填充结果。这可能吗？

public class BaseController : Controller {
    protected AppSettings AppSettings;
    protected IMapper Mapper;
    protected IPortalApiService PortalApiService;
    protected ILogger Logger;
    protected UserManager<ApplicationUser> UserManager;
    private static Stopwatch _stopWatch = new Stopwatch();
    private static long _seconds;

    public BaseController ( IMapper mapper,
                            IOptions<AppSettings> appSettings,
                            UserManager<ApplicationUser> userManager,
                            IPortalApiService PortalApiService,
                            ILogger logger) {
        Mapper = mapper;
        AppSettings = appSettings.Value;
        UserManager = userManager;
        PortalApiService = PortalApiService;
        Logger = logger;
    }

    public BaseController ( IMapper mapper,
                            IOptions<AppSettings> appSettings,
                            UserManager<ApplicationUser> userManager,
                            ILogger logger) {
        Mapper = mapper;
        AppSettings = appSettings.Value;
        UserManager = userManager;
        Logger = logger;
    }

    protected Task<ApplicationUser> GetCurrentUserAsync () {
        return UserManager.GetUserAsync( HttpContext.User );
    }

    public void StartBenchmark()
    {

        if (AppSettings.EnableBenchmarkLogging)
        {
            _stopWatch = Stopwatch.StartNew();
        }

    }

    public void EndBenchmark()
    {
        if (_stopWatch.IsRunning)
        {
            _stopWatch.Stop();
            _seconds = _stopWatch.ElapsedMilliseconds;
            //logging to do
        }
    }
}

Answer 1

是not a good idea to use a BaseController in MVC。有更好的方法来实现crosscutting concerns。在这种特殊情况下，您可以使用global filter。

public class BenchmarkFilter : IActionFilter
{
    private readonly ILogger Logger;

    // DON'T DECLARE STATIC!! 
    private Stopwatch _stopWatch = new Stopwatch();

    public BenchmarkFilter(ILogger logger)
    {
        _logger = logger ?? 
            throw new ArgumentNullException(nameof(logger));
    }

    public void OnActionExecuting(ActionExecutingContext context)
    {
        _stopWatch = Stopwatch.StartNew();
    }

    public void OnActionExecuted(ActionExecutedContext context)
    {
        if (_stopWatch.IsRunning)
        {
            _stopWatch.Stop();
            var seconds = _stopWatch.ElapsedMilliseconds;
            //logging to do
        }
    }
}

这允许您通过构造函数通过DI注入服务，而无需将这些参数添加到子类常见BaseController 的每个控制器中，从而完全将基准测试的关注点与控制器分开。

用法

在Startup.cs中，使用ConfigureServices方法添加过滤器。

public void ConfigureServices(IServiceCollection services)
{
    services.AddMvc(options =>
    {
        options.Filters.Add(typeof(BenchmarkFilter)); // runs on every action method call
    });

    services.AddScoped<BenchmarkFilter>();
    // ....
}

如何在MVC控制器中将基准测试记录到CSV文件？

1 个答案:

用法