代码运行速度太慢

时间:2017-06-13 04:49:45

标签: javascript optimization google-apps-script google-sheets copy

我正在尝试运行一个代码,该代码可以复制一个电子表格中的值并将它们复制到另一个电子表格中,但顺序并不相同(很难将其作为数组)。在某些情况下,它还打印“未知”,在某些情况下,它还会格式化一些单元格。然而,它让很多时间完成。有没有办法改善它?

function move() {

  var sss = SpreadsheetApp.openById('xx');
  var sourceSheet = sss.getSheetByName('CJ_Products');
  var destinationSheet = sss.getSheetByName('Product2');

  var lastRow = sourceSheet.getRange(sourceSheet.getLastRow(), 1,1,1).getRow()

  var i = 1

  while(i<=lastRow){
  var rowInt = destinationSheet.getRange(destinationSheet.getLastRow()+1, 4,1,1).getRow() //get row number
  destinationSheet.getRange('A' + rowInt).setFormula('=Month(D'+rowInt+')')
  destinationSheet.getRange('B' + rowInt).setFormula('=Weekday(D'+rowInt+')')
  destinationSheet.getRange('C' + rowInt).setFormula('=Day(D'+rowInt+')')
  destinationSheet.getRange('D' + rowInt).setValue(sourceSheet.getRange('A'+i).getValues()) //move from the source to destination
  destinationSheet.getRange('E' + rowInt+':F'+rowInt).setValue('Unknown') //set to Unknown
  destinationSheet.getRange('H' + rowInt+':J'+rowInt).setValue('Unknown')
  destinationSheet.getRange('J' + rowInt).setValue('CJ')
  destinationSheet.getRange('K' + rowInt).setValue(sourceSheet.getRange('B' +i).getValues())
  destinationSheet.getRange('L' + rowInt).setValue(sourceSheet.getRange('E' +i).getValues())
  destinationSheet.getRange('M' + rowInt).setValue(sourceSheet.getRange('F' +i).getValues())
  destinationSheet.getRange('N' + rowInt).setValue(sourceSheet.getRange('J' +i).getValues())
  destinationSheet.getRange('S' + rowInt).setValue(sourceSheet.getRange('G' +i).getValues())
  destinationSheet.getRange('T' + rowInt).setValue(sourceSheet.getRange('H' +i).getValues())
  destinationSheet.getRange('O' + rowInt).setFormula('=S'+rowInt+'*GOOGLEFINANCE("currency:EURUSD")')
  destinationSheet.getRange('P' + rowInt).setFormula('=T'+rowInt+'*GOOGLEFINANCE("currency:EURUSD")')
  destinationSheet.getRange('Q' + rowInt).setFormula('=P'+rowInt+'/T'+rowInt)
  destinationSheet.getRange('O' + rowInt+':Q'+rowInt).setNumberFormat('0.00$')

  i = i+1
  }
  }

1 个答案:

答案 0 :(得分:4)

应优化代码:

  1. 您在循环中完成所有计算
  2. 您使用getValuesetValue代替更快的功能getValuessetValues
  3. 而不是集中你的循环来做一个电话:

    var rowInt = destinationSheet.getRange(destinationSheet.getLastRow()+1, 4,1,1).getRow()

    尝试弄清楚如何找到循环外的第一行,然后递增该值:

    var rowStart = destinationSheet.getRange(destinationSheet.getLastRow()+1, 4,1,1).getRow();
    
    for (var row = rowStart; row <= lastRow, row++)
    {
      // some code...
    }
    

    使用数组,然后将数组中的值复制到范围中:

    var formulas = [];
    
    for (var row = rowStart; row <= lastRow, row++)
    {
      // some code...
      formulas.push(['=Month(D'+ row + ')']);
    }
    var rangeToPateFormulas = destinationSheet.getRange('A' + rowStart + ':A' + lastRow);
    rangeToPateFormulas.setFormulas(formulas);
    

    等等。查看更多信息:

    https://developers.google.com/apps-script/reference/spreadsheet/range

    https://developers.google.com/apps-script/guides/support/best-practices