Ecto:Repo.preload无效,协议Ecto.Queryable未实现

时间:2017-05-25 10:03:30

标签: elixir phoenix-framework ecto

我已经安装了新的Phoenix 1.3并生成了Blog上下文,其中包含一些模式Post和Comment。我的测试项目名为NewVersion(因为我正在测试Phoenix框架的新版本)。

因此,我的模式非常标准,主要由phx.gen.html生成:

Post.ex

defmodule NewVersion.Blog.Post do
  use Ecto.Schema
  import Ecto.Changeset
  alias NewVersion.Blog.Post


  schema "blog_posts" do
    field :body, :string
    field :title, :string
    has_many :comments, NewVersion.Blog.Comment, on_delete: :delete_all, foreign_key: :blog_post_id

    timestamps()
  end

  @doc false
  def changeset(%Post{} = post, attrs) do
    post
    |> cast(attrs, [:title, :body])
    |> validate_required([:title, :body])
    |> cast_assoc(:comments)
  end
end

comment.ex

defmodule NewVersion.Blog.Comment do
  use Ecto.Schema
  import Ecto.Changeset
  alias NewVersion.Blog.Comment


  schema "blog_comments" do
    field :body, :string
    belongs_to :blog_post, NewVersion.Blog.Post, foreign_key: :blog_post_id

    timestamps()
  end

  @doc false
  def changeset(%Comment{} = comment, attrs) do
    comment
    |> cast(attrs, [:body])
    |> validate_required([:body])
  end
end

blog.ex

defmodule NewVersion.Blog do
  @moduledoc """
  The boundary for the Blog system.
  """

  import Ecto.Query, warn: false
  alias NewVersion.Repo

  alias NewVersion.Blog.Post

  def list_posts do
    Repo.all(Post)
  end

  def get_post!(id), do: Repo.get!(Post, id)

  def create_post(attrs \\ %{}) do
    %Post{}
    |> Post.changeset(attrs)
    |> Repo.insert()
  end

  def update_post(%Post{} = post, attrs) do
    post
    |> Post.changeset(attrs)
    |> Repo.update()
  end

  def delete_post(%Post{} = post) do
    Repo.delete(post)
  end

  def change_post(%Post{} = post) do
    Post.changeset(post, %{})
  end

  alias NewVersion.Blog.Comment

  def list_comments do
    Repo.all(Comment)
  end

  def get_comment!(id), do: Repo.get!(Comment, id)

  def create_comment(attrs \\ %{}) do
    %Comment{}
    |> Comment.changeset(attrs)
    |> Repo.insert()
  end

  def update_comment(%Comment{} = comment, attrs) do
    comment
    |> Comment.changeset(attrs)
    |> Repo.update()
  end

  def delete_comment(%Comment{} = comment) do
    Repo.delete(comment)
  end

  def change_comment(%Comment{} = comment) do
    Comment.changeset(comment, %{})
  end    

end

一切正常,但我想创建嵌套表单,用于创建和编辑带有评论的帖子,为此我想将评论预加载到帖子。在指南(https://github.com/elixir-ecto/ecto/blob/master/guides/Associations.md)中,我找到了一个帖子和标签的示例,如下所示:

tag = Repo.get(Tag, 1) |> Repo.preload(:posts)

但是当我更改函数get_post时!在我的blog.ex中类似于:

  def get_post!(id), do: Repo.get!(Post, id)

为:

  def get_post!(id), do: Repo.get!(Post, id) |> Repo.preload(:comments)

我收到错误:协议Ecto.Queryable未实现%NewVersion.Blog.Post { meta :#Ecto.Schema.Metadata<:loaded," blog_posts"> ;,正文:"这是第二篇帖子",评论:[%NewVersion.Blog.Comment { meta :...

为什么?我似乎严格遵循文档,但缺少某些东西。 我只是没有看到我的代码和那里提供的代码之间的区别,当然我知道实现协议的方法是什么。

顺便说一句,如果我将我的功能更改为:

def get_post!(id), do: Repo.get!(Post |> preload(:comments), id) 

错误消失了。但我仍然想知道为什么第一种方法对我不起作用。

stacktrace的完整错误消息是:

[error] #PID<0.8148.0> running NewVersion.Web.Endpoint terminated
Server: localhost:4000 (http)
Request: GET /posts/2/edit
** (exit) an exception was raised:
    ** (Protocol.UndefinedError) protocol Ecto.Queryable not implemented for %Ne
wVersion.Blog.Post{__meta__: #Ecto.Schema.Metadata<:loaded, "blog_posts">, body:
 "Blog post 2", comments: [%NewVersion.Blog.Comment{__meta__: #
Ecto.Schema.Metadata<:loaded, "blog_comments">, blog_post: #Ecto.Association.Not
Loaded<association :blog_post is not loaded>, blog_post_id: 2, body: "third comm
ent", id: 3, inserted_at: ~N[2017-05-22 12:49:37.506000], title: "Comment 3", up
dated_at: ~N[2017-05-22 12:49:37.506000], votes: 1}, %NewVersion.Blog.Comment{__
meta__: #Ecto.Schema.Metadata<:loaded, "blog_comments">, blog_post: #Ecto.Associ
ation.NotLoaded<association :blog_post is not loaded>, blog_post_id: 2, body: "Comment for blog post 2", id: 2, inserted_at: ~N[2
017-05-22 12:14:48.590000], title: "Comment 2 for post 2", updated_at: ~N[2017-0
5-22 12:14:48.590000]}], id: 2, inserted_at: ~N[2017-05-22 12:14:47.96
2000], title: "Post 2", updated_at: ~N[2017-05-22 12:14:47.962000]}
        (ecto) lib/ecto/queryable.ex:1: Ecto.Queryable.impl_for!/1
        (ecto) lib/ecto/queryable.ex:9: Ecto.Queryable.to_query/1
        (ecto) lib/ecto/query/builder/preload.ex:154: Ecto.Query.Builder.Preload
.apply/3
        (new_version) lib/new_version/web/controllers/post_controller.ex:33: New
Version.Web.PostController.edit/2
        (new_version) lib/new_version/web/controllers/post_controller.ex:1: NewV
ersion.Web.PostController.action/2
        (new_version) lib/new_version/web/controllers/post_controller.ex:1: NewV
ersion.Web.PostController.phoenix_controller_pipeline/2
        (new_version) lib/new_version/web/endpoint.ex:1: NewVersion.Web.Endpoint
.instrument/4
        (phoenix) lib/phoenix/router.ex:278: Phoenix.Router.__call__/1
        (new_version) lib/new_version/web/endpoint.ex:1: NewVersion.Web.Endpoint
.plug_builder_call/2
        (new_version) lib/plug/debugger.ex:123: NewVersion.Web.Endpoint."call (o
verridable 3)"/2
        (new_version) lib/new_version/web/endpoint.ex:1: NewVersion.Web.Endpoint
.call/2
        (plug) lib/plug/adapters/cowboy/handler.ex:15: Plug.Adapters.Cowboy.Hand
ler.upgrade/4
        (cowboy) d:/test/new_version/deps/cowboy/src/cowboy_protocol.erl:442: :c
owboy_protocol.execute/4

从PostController编辑函数:

  def edit(conn, %{"id" => id}) do
    post = Blog.get_post!(id)
    IO.inspect post
    changeset = Blog.change_post(post)
    render(conn, "edit.html", post: post, changeset: changeset)
  end

1 个答案:

答案 0 :(得分:1)

正如我已经在我的问题的评论中写的那样,最初的错误是我没有准确地遵循Ecto文档而不是函数

def get_post!(id), do: Repo.get!(Post, id) |> preload(:comments)

我应该(注意缺少回购。)

def get_post!(id), do: Repo.get!(Post, id) |> Repo.preload(:comments)

但更糟糕的是,我的问题并未提供具有误导性的错误的实际代码。

结论:问题没有价值,预加载协会没有问题。凤凰社区支持很棒,新手友好,谢谢你们!因为你,我觉得凤凰框架对我来说真是个不错的选择。

修改

经过一番思考后来

def get_post!(id), do: Repo.get!(Post |> preload(:comments), id) 

工作,

def get_post!(id), do: Repo.get!(Post, id) |> preload(:comments)

没有,我决定为任何人的缘故详细说明答案。

原因是因为preload函数来自Ecto.Query模块,而不是来自NewVersion.Repo模块(NewVersion只是我项目的名称)。

此函数希望将Ecto.Queryable作为第一个参数。在第一种情况下,提供了原子Post(它只是NewVersion.Blog.Post的别名),如果你查看https://github.com/elixir-ecto/ecto/blob/master/lib/ecto/queryable.ex,你可以看到为原子提供了Ecto.Queryable协议。对于第二个表达式,Repo.get!(Post,id)返回Post结构而不是Post atom,并且没有为它提供Ecto.Queryable协议。