Question

我必须在下面的 internal.h 中实现这些功能：

#ifndef STUDENT_INTERNAL_H
#define STUDENT_INTERNAL_H

#include "student.h"

/** Allocate memory for a new @ref student object. */
struct student *student_alloc(void);

/*** Initialize an already-allocated @ref student object.
* @returns   NULL on failure but does not free the memory
*/

struct student *student_init(struct student *, const char *name, size_t namelen, 
                             struct student_id, student_complete);

#endif /* STUDENT_INTERNAL_H */

这是我到目前为止所得到的，但我很困惑，而且它不起作用：

#include <sys/types.h>
#include "common.h"
#include "student.h"
#include "transcript.h"
#include "internal.h"

/**
* Initialize an already-allocated @ref student object.
* @returns   NULL on failure but does not free the memory
*/
struct student *student_init(struct student *student, const char *name, size_t namelen,
                             struct student_id stud_id, student_complete stud_complete) {

    struct student *initialized_student;

    name = malloc(sizeof(namelen));
    initialized_student = malloc(sizeof (student));

    if (student_alloc()) {
        initialized_student->s_name = name;
        initialized_student->s_id = stud_id;
        initialized_student->s_complete = stud_complete;

        return initialized_student;
    } else {
        return 0;
    }
}

stud_complete这是一个函数指针，它在传递头文件 student.h 中声明，如typedef int (*student_complete)(struct student *);

Answer 1

API令人困惑：

什么是namelen？

是学生姓名name的初始前缀的长度吗？在这种情况下，您应该为null终止符分配一个额外的字节并适当地复制名称。
是学生姓名的最大长度吗？再次，如果这是一个长度，而不是大小，你需要一个额外的字节用于null终止符。
无论如何sizeof(namelen)都不合适。

student_alloc()做了什么？

类似地，传递给malloc()以分配student结构的大小应该是struct student的大小，或者更可靠地是目标指针所指向类型的大小。

以下是更正后的版本：

struct student *student_init(struct student *student, const char *name, size_t namelen,
                             struct student_id stud_id, student_complete stud_complete) {

    struct student *initialized_student = malloc(sizeof(*initialized_student));
    char *s_name = calloc(namelen + 1);

    if (initialized_student && s_name && student_alloc()) {
        strncat(s_name, name, namelen);
        initialized_student->s_name = s_name;
        initialized_student->s_id = stud_id;
        initialized_student->s_complete = stud_complete;
        return initialized_student;
    } else {
        free(initialized_student);
        free(s_name);
        return 0;
    }
}

学生结构中的C内存分配不起作用

1 个答案: