根据http响应更改警报频率

Question

我的代码完全可以发送http请求，如果网站关闭或响应代码不是200，它会发送一个松弛通知。我现在要弄清楚的是，在通知表中我有check_frequency和alert_frequence。如果网站关闭，而不是使用检查频率来计算经过时间，则应使用alert_frequence。

namespace App\Http\Controllers;


use GuzzleHttp\Client;
use App\Utilities\Reporter;
use GuzzleHttp\Exception\ClientException;
use App\Notification;
use App\Status;
use App\Setting;

class GuzzleController extends Controller
{
  private $default_check_frequency;

  protected $client;
  protected $reporter;


  public function __construct()
  {
    $this->client = new Client;

    $this->reporter = new Reporter;

    $this->default_check_frequency = Setting::defaultCheckFrequency();
  }

  public function status()
  {
    $notifications = Notification::where('active', 1)->get();

    $status = Status::where('name', 'health')->first();

    foreach ($notifications as $notification) {
      $this->updateStatus($notification, $status);


    }
  }

  private function updateStatus(Notification $notification, Status $status)
  {
    $status_health = $notification->status('health');



    $frequency = $this->getFrequency($notification);

    $elapsed_time = \Carbon\Carbon::parse($status_health['timestamp'])->diffInMinutes();

    if($elapsed_time >= $frequency) {

      $response = $this->client->get($notification->website_url, [
        'http_errors' => false
      ]);  


      $resCode = $response->getStatusCode();

      $notification->statuses()->attach($status, [
        'values' => $resCode === 200 ? 'up' : 'down'
      ]);

      if($resCode != 200){
        /* how to send slack to different slach channels, now it is sending only to one channel!*/

        $this->reporter->slack($notification->website_url.':'.'  is down'. ' please check your email for the status code!'.' @- '.$notification->email, 
                $notification->slack_channel);
        $this->reporter->mail($notification->email,$resCode );

      }
    }

  }

  private function getFrequency(Notification $notification)
  {
    return isset($notification->check_frequency) 
    ? intval($notification->check_frequency) 
    : $this->default_check_frequency;
  }
}

Answer 1

我不确定这是您所需要的，但是根据状态，您可以采取以下措施从表中选择不同的列：

<?php

class GuzzleController extends Controller
{
    private $default_check_frequency;

    protected $client;
    protected $reporter;

    public function __construct()
    {
        $this->client = new Client;

        $this->reporter = new Reporter;

        $this->default_check_frequency = Setting::defaultCheckFrequency();
    }

    public function status()
    {
        $notifications = Notification::where('active', 1)->get();

        $status = Status::where('name', 'health')->first();

        foreach ($notifications as $notification) {
            $this->updateStatus($notification, $status);
        }
    }

    private function updateStatus(Notification $notification, Status $status)
    {
        $status_health = $notification->status('health');

        /// move it here
        $response = $this->client->get($notification->website_url, [
            'http_errors' => false
        ]);
        $resCode = $response->getStatusCode();
        /// --- end

        $frequency = $this->getFrequency($notification, $resCode);

        $elapsed_time = \Carbon\Carbon::parse($status_health['timestamp'])->diffInMinutes();

        if($elapsed_time >= $frequency) {
            $notification->statuses()->attach($status, [
                'values' => $resCode === 200 ? 'up' : 'down'
            ]);

            if($resCode != 200){
                /* how to send slack to different slach channels, now it is sending only to one channel!*/
                $this->reporter->slack($notification->website_url.':'.'  is down'. ' please check your email for the status code!'.' @- '.$notification->email,
                $notification->slack_channel);
                $this->reporter->mail($notification->email,$resCode );
            }
        }
    }

    private function getFrequency(Notification $notification, $resCode)
    {
        /// -- select your column here
        $column = $resCode == '200' ? 'check_frequency' : 'alert_frequence';

        return isset($notification->{$column})
            ? intval($notification->{$column})
            : $this->default_check_frequency;
    }
}

我冒昧地重构它，分离方法问题：

<?php

use Carbon\Carbon;

class GuzzleController extends Controller
{
    private $default_check_frequency;

    protected $client;

    protected $reporter;

    public function __construct()
    {
        $this->client = new Client;

        $this->reporter = new Reporter;

        $this->default_check_frequency = Setting::defaultCheckFrequency();
    }

    private function addStatusToNotification(Notification $notification, Status $status, $resCode)
    {
        $notification->statuses()->attach($status, [
            'values' => $resCode === 200
                ? 'up'
                : 'down'
        ]);
    }

    private function report(Notification $notification, $resCode)
    {
        /* how to send slack to different slach channels, now it is sending only to one channel!*/
        $this->reporter->slack($notification->website_url . ':' . '  is down' . ' please check your email for the status code!' . ' @- ' . $notification->email,
                               $notification->slack_channel);

        $this->reporter->mail($notification->email, $resCode);
    }

    private function sendNotification(Notification $notification, Status $status, $status_health, $frequency, $resCode)
    {
        $elapsed_time = Carbon::parse($status_health['timestamp'])->diffInMinutes();

        if ($elapsed_time >= $frequency) {
            $this->addStatusToNotification($notification, $status, $resCode);

            if ($resCode != 200) {
                $this->report($notification, $resCode);
            }
        }
    }

    public function status()
    {
        $notifications = Notification::where('active', 1)->get();

        $status = Status::where('name', 'health')->first();

        foreach ($notifications as $notification) {
            $this->updateStatus($notification, $status);
        }
    }

    private function updateStatus(Notification $notification, Status $status)
    {
        $resCode = $this->getStatusCode($notification->website_url);

        $this->sendNotification(
            $notification,
            $status,
            $notification->status('health'),
            $this->getFrequency($notification, $resCode),
            $resCode
        );
    }

    private function getFrequency(Notification $notification, $resCode)
    {
        $column = $resCode == '200' ? 'check_frequency' : 'alert_frequence';

        return isset($notification->{$column})
            ? intval($notification->{$column})
            : $this->default_check_frequency;
    }

    private function getStatusCode($url)
    {
        $response = $this->client->get($url, [
            'http_errors' => false
        ]);

        return $response->getStatusCode();
    }
}