Gson类中的VerifyError

时间:2016-07-05 09:30:54

标签: java bytecode byte-buddy

我使用以下代码重新定义一个类:

DynamicType.Unloaded unloaded = new ByteBuddy().with(TypeValidation.DISABLED).rebase(typeDescription,
                ClassFileLocator.Simple.of(className, classBytes,
                        ClassFileLocator.ForClassLoader.of((ClassLoader) classLoader))).method(
                ElementMatchers.isPackagePrivate().and(ElementMatchers.not(ElementMatchers.isAbstract()))).intercept(
                MethodDelegation.to(PackagePrivateInterceptor.class)).transform(
                MethodTransformer.Simple.withModifiers(Visibility.PUBLIC)).make();
        return new ClassPair(unloaded.load((ClassLoader) classLoader,
                ClassLoadingStrategy.Default.INJECTION.withProtectionDomain(
                        classLoader.getClass().getProtectionDomain())).getLoaded(), unloaded.getBytes());

加载课程class com.google.gson.internal.ConstructorConstructor

它遍历构造函数,直到最终它到达com.google.gson.internal.LinkedTreeMap的类初始值设定项。

在初始化期间,我得到一个VerifyError:

1:24:20.227 [main] ERROR   [io.hakansson.dynamicjar.core.main.Bootstrap] - java.lang.RuntimeException: java.lang.VerifyError: Illegal type at constant pool entry 195 in class com.google.gson.internal.LinkedTreeMap$1
Exception Details:
  Location:
    com/google/gson/internal/LinkedTreeMap$1.thenComparing$accessor$vT023QbO(Ljava/util/function/Function;)Ljava/util/Comparator; @2: invokespecial
  Reason:
    Constant pool index 195 is invalid
  Bytecode:
    0x0000000: 2a2b b700 c3b0                         

    at io.hakansson.dynamicjar.core.api.util.ReflectionUtil.invokeMethod(ReflectionUtil.java:52)
    at io.hakansson.dynamicjar.core.main.Bootstrap.main(Bootstrap.java:42)
Caused by: java.lang.VerifyError: Illegal type at constant pool entry 195 in class com.google.gson.internal.LinkedTreeMap$1
Exception Details:
  Location:
    com/google/gson/internal/LinkedTreeMap$1.thenComparing$accessor$vT023QbO(Ljava/util/function/Function;)Ljava/util/Comparator; @2: invokespecial
  Reason:
    Constant pool index 195 is invalid
  Bytecode:
    0x0000000: 2a2b b700 c3b0                         

    at com.google.gson.internal.LinkedTreeMap.classInitializer$oNOjADym(LinkedTreeMap.java:40)
    at com.google.gson.internal.LinkedTreeMap.(LinkedTreeMap.java)
    at com.google.gson.internal.ConstructorConstructor$13.construct$original$gt92dwVY(ConstructorConstructor.java:207)
    at com.google.gson.internal.ConstructorConstructor$13.construct$original$gt92dwVY$accessor$lof1omy8(ConstructorConstructor.java)
    at com.google.gson.internal.ConstructorConstructor$13$auxiliary$oB71rVyd.call(Unknown Source)
    at io.hakansson.dynamicjar.nestedjarclassloader.PackagePrivateInterceptor.intercept(PackagePrivateInterceptor.java:29)
    at com.google.gson.internal.ConstructorConstructor$13.construct(ConstructorConstructor.java)
    at com.google.gson.internal.bind.MapTypeAdapterFactory$Adapter.read(MapTypeAdapterFactory.java:167)
    at com.google.gson.internal.bind.MapTypeAdapterFactory$Adapter.read(MapTypeAdapterFactory.java:145)
    at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$1.read$original$ZTjOtCtb(ReflectiveTypeAdapterFactory.java:116)
    at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$1.read$original$ZTjOtCtb$accessor$WgRdwpwl(ReflectiveTypeAdapterFactory.java)
    at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$1$auxiliary$41HBhnNS.call(Unknown Source)
    at io.hakansson.dynamicjar.nestedjarclassloader.PackagePrivateInterceptor.intercept(PackagePrivateInterceptor.java:29)
    at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$1.read(ReflectiveTypeAdapterFactory.java)
    at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$Adapter.read(ReflectiveTypeAdapterFactory.java:216)
    at com.google.gson.internal.bind.TypeAdapterRuntimeTypeWrapper.read$original$bOjIYDn5(TypeAdapterRuntimeTypeWrapper.java:40)
    at com.google.gson.internal.bind.TypeAdapterRuntimeTypeWrapper.read$original$bOjIYDn5$accessor$hMWEZRZS(TypeAdapterRuntimeTypeWrapper.java)
    at com.google.gson.internal.bind.TypeAdapterRuntimeTypeWrapper$auxiliary$U1tyihKy.call(Unknown Source)
    at io.hakansson.dynamicjar.nestedjarclassloader.PackagePrivateInterceptor.intercept(PackagePrivateInterceptor.java:29)
    at com.google.gson.internal.bind.TypeAdapterRuntimeTypeWrapper.read(TypeAdapterRuntimeTypeWrapper.java)
    at com.google.gson.internal.bind.CollectionTypeAdapterFactory$Adapter.read(CollectionTypeAdapterFactory.java:82)
    at com.google.gson.internal.bind.CollectionTypeAdapterFactory$Adapter.read(CollectionTypeAdapterFactory.java:61)
    at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$1.read$original$ZTjOtCtb(ReflectiveTypeAdapterFactory.java:116)
    at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$1.read$original$ZTjOtCtb$accessor$WgRdwpwl(ReflectiveTypeAdapterFactory.java)
    at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$1$auxiliary$41HBhnNS.call(Unknown Source)
    at io.hakansson.dynamicjar.nestedjarclassloader.PackagePrivateInterceptor.intercept(PackagePrivateInterceptor.java:29)
    at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$1.read(ReflectiveTypeAdapterFactory.java)
    at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$Adapter.read(ReflectiveTypeAdapterFactory.java:216)
    at com.google.gson.Gson.fromJson(Gson.java:879)
    at com.google.gson.Gson.fromJson(Gson.java:817)

作为参考,拦截器基本上只是手动检查包私有访问(因为包私有方法是公开的),然后只调用superCall.call()。我不相信问题就在那里。

有什么想法吗?

编辑: 这是PackagePrivateInterceptor:     公共类PackagePrivateInterceptor {

@RuntimeType
@BindingPriority(1)
public static Object intercept(@SuperCall Callable<?> superCall, @Origin Class targetClass, @Origin String method) throws
        Exception
{

    Class callingClass = new InternalSecurityManager().getCallingClass();
    String targetPackage = targetClass.getPackage().getName();
    if (!callingClass.getPackage().getName().equals(targetPackage)) {
        throw new IllegalAccessError(callingClass + " cannot access method " + method + " of Class " + targetClass);
    }

    //Default:
    return superCall.call();
}

private static class InternalSecurityManager extends SecurityManager {
    Class getCallingClass() {
        Class[] classContext = getClassContext();
        for (Class current : classContext) {
            if (current.getName().startsWith("java.") ||
                    current.getName().equals(PackagePrivateInterceptor.class.getName()) ||
                    current.getName().equals(InternalSecurityManager.class.getName()))
            {
                continue;
            }
            return current;
        }
        throw new IllegalStateException("Failed to find calling Class");
    }
}

EDIT2: 以下代码不会触发此问题:

//Only package-private methods should be proxied.
            DynamicType.Unloaded unloaded = new ByteBuddy().with(TypeValidation.DISABLED).rebase(typeDescription,
                    ClassFileLocator.Simple.of(className, classBytes,
                            ClassFileLocator.ForClassLoader.of((ClassLoader) classLoader))).method(
                    ElementMatchers.isPackagePrivate().and(ElementMatchers.not(ElementMatchers.isAbstract()))).intercept(
                    MethodDelegation.to(PackagePrivateInterceptor.class)).transform(
                    MethodTransformer.Simple.withModifiers(Visibility.PUBLIC)).make();
            DynamicType.Loaded loaded = unloaded.load((ClassLoader) classLoader,
                    ClassLoadingStrategy.Default.INJECTION.withProtectionDomain(
                            classLoader.getClass().getProtectionDomain()));
            if (className.equals("com.google.gson.internal.LinkedTreeMap"))
                System.out.println(DatatypeConverter.printHexBinary(loaded.getBytes()));
            return new ClassPair(loaded.getLoaded(), unloaded.getBytes());

但是以下是:

//All non-private methods should be proxied
            //TODO: Actually, the class itself should be made visible and still only package-private methods should be proxied.
            DynamicType.Unloaded unloaded = new ByteBuddy().with(TypeValidation.DISABLED).rebase(typeDescription,
                    ClassFileLocator.Simple.of(className, classBytes,
                            ClassFileLocator.ForClassLoader.of((ClassLoader) classLoader))).method(
                    ElementMatchers.not(ElementMatchers.isPrivate()).and(
                            ElementMatchers.not(ElementMatchers.isAbstract()))).intercept(
                    MethodDelegation.to(PackagePrivateInterceptor.class)).transform(
                    MethodTransformer.Simple.withModifiers(Visibility.PUBLIC)).make();
            return new ClassPair(unloaded.load((ClassLoader) classLoader,
                    ClassLoadingStrategy.Default.INJECTION.withProtectionDomain(
                            classLoader.getClass().getProtectionDomain())).getLoaded(), unloaded.getBytes());

1 个答案:

答案 0 :(得分:2)

这确实是Byte Buddy的一个错误。问题是您在Java 8 VM上重新定义Java 6类,其中Comparable接口正在实现几种默认方法。您指示Byte Buddy覆盖这些方法,并且还指示库从重写的实现中调用这些默认方法。即使VM运行Java 8,这对Java 6类文件也不合法。

如果我把你的匹配器装到:

not(isPrivate().or(isAbstract()).or(isDefaultMethod()))

错误消失了。我将在未来版本的Byte Buddy中解决这个问题。

Byte Buddy或ASM目前没有捕获此错误,这会产生奇怪的错误消息。

更新:错误现在已在版本1.4.13中解决。