我已经更改了代码，现在程序正确地从students.txt读取文件，但仍然是根据用户输入而不是students.txt计算的。 ＃包括 ＃包括 ＃包括 ＃包括 ＃包括 ＃包括 ＃包括 #include
using namespace std;
//Declaring class Student
class Student
{
private:
string newName;
int newScore1;
int newScore2;
int newScore3;
float newFinal;
public:
// No argument constructors
Student ()
{
newName = " ";
newScore1 = 0;
newScore2 = 0;
newScore3 = 0;
newFinal = 0.00;
}
//all arguements constructors
Student (string name, int score1, int score2, int score3, float final)
{
newName = name;
newScore1 = score1;
newScore2 = score2;
newScore3 = score3;
newFinal = final;
}
//getters
string getName() const
{
return newName;
}
int getScore1() const
{
return newScore1;
}
int getScore2()const
{
return newScore2;
}
int getScore3()const
{
return newScore3;
}
float getFinal () const
{
return newFinal;
}
//Setters
void setName(string name)
{
newName = name;
}
void setScore1(int score1)
{
newScore1=score1;
}
void setScore2(int score2)
{
newScore2=score2;
}
void setScore3 (int score3)
{
newScore3 = score3;
}
void setFinal (float final)
{
newFinal = final;
}
};
//asks for number of students,
// function asks for input to fill in vector
//sorts the inputs to get max 2 scores out of 3
//puts the data in a vector of class Student
//Sends data to a text file students.txt
void fillvector(vector <Student>& newMyClass)
{
string name;
float score1;
float score2;
float score3;
float final;
float tmp;
cout << "Please enter the number of Students: " << endl;
int classSize;
cin >> classSize;
for (int i = 0; i < classSize; i ++)
{
cout << "Enter Student's name" << endl;
cin >> name;
cout << "Enter Student's Score 1" << endl;
cin >> score1;
cout << "Enter Student's Score 2" << endl;
cin >> score2;
cout << "Enter Student's Score 3" << endl;
cin >> score3;
if(score1>score2)
{
float tmp = score1;
score1 = score2;
score2 = tmp;
}
if(score1>score3)
{
float tmp = score1;
score1=score3;
score3 = tmp;
}
if(score2>score3)
{
float tmp = score2;
score2=score3;
score3=tmp;
}
final = (score2+score3)/2;
Student newStudent (name, score1, score2, score3, final);
newMyClass.push_back(newStudent);
cout << endl;
ofstream myfile;
myfile.open ("students.txt", std::ofstream::out |std::ofstream::app );
myfile << name<< setw(5)<< score1<< setw(5)<<score2<<setw(5) <<score3<<setw(5)<<final<<setw(5)<<endl;
myfile.close();
cout << "Copied to students.txt" << endl;
}
cout << endl;
}
//reads data from textfile students.txt
//calculated teh minimum scores and maximum scores
//sends the minimum and maximum scores to text file Results.txt
void readToVector(vector <Student>& newMyClass)
{
string name;
float score1;
float score2;
float score3;
float finalScore;
Student newStudent (name, score1, score2, score3, finalScore);
unsigned int size = newMyClass.size();
ifstream fin("students.txt");
if (fin.is_open())
{cout << "File open" << endl;
while(fin >> name >> score1 >> score2 >> score3 >> finalScore)
{
newStudent.setName(name);
newStudent.setScore1(score1);
newStudent.setScore2(score2);
newStudent.setScore3(score3);
newStudent.setFinal(finalScore);
newMyClass.push_back(newStudent);
//cout << newStudent.getName() << newStudent.getFinal() << endl;
}
fin.close();
cout << endl;
Student studWMaxScore = newMyClass[0];
float maxscore = studWMaxScore.getFinal();
for (unsigned int i =0; i < size; i++)
{
if (maxscore < newMyClass[i].getFinal())
{
maxscore = newMyClass[i].getFinal();
studWMaxScore = newMyClass[i];
}
}
cout << "Maximum Score is " << maxscore << endl;
ofstream myfile;
myfile.open ("Result.txt", std::ofstream::out );
myfile << "Maximum Score" << endl;
myfile << maxscore << endl;
myfile << "Name of the student with maximum score is " << endl;
myfile << studWMaxScore.getName() << endl << endl;
// myfile.close();
cout << "Copied to Results.txt" << endl;
Student stuWMinScore = newMyClass[0];
float minscore = stuWMinScore.getFinal();
for (unsigned int i =0; i < size; i++)
{
if (minscore > newMyClass[i].getFinal())
{
minscore = newMyClass[i].getFinal();
stuWMinScore = newMyClass[i];
}
}
cout << "Minimum Score is " << minscore << endl;
// ofstream myfile;
// myfile.open ("Result.txt", std::ofstream::out );
myfile << "Mimimum Score" << endl;
myfile << minscore << endl;
myfile << "Name of the student with minimum score is " << endl;
myfile << stuWMinScore.getName() << endl << endl;
// myfile.close();
cout << "Copied to Results.txt" << endl;
}
else
cout << "file in not open" << '\n';
}
//prints out the name and scores of each student
void printVector (const vector<Student>& newMyClass)
{
unsigned int size = newMyClass.size();
for (unsigned int i =0; i < size; i++)
{
cout << "Student name is: "<< newMyClass[i].getName() << endl;
cout << "Student Score 1 is "<< newMyClass[i].getScore1()<< endl;
cout << "Student Score 2 is "<< newMyClass[i].getScore2()<< endl;
cout << "Student Score 3 is "<< newMyClass[i].getScore3()<< endl;
cout << "Student Final Score is " << newMyClass[i].getFinal() << endl;
cout << endl;
}
}
int main ()
{
vector <Student> myClass;
fillvector (myClass);
readToVector(myClass);
printVector(myClass);
}
答案 0 :(得分：0)
bug的核心看起来就在这里：
while(fin >> name >> score1 >> score2 >> score3 >> finalScore)
{
newStudent.setName(name);
newStudent.setScore1(score1);
newStudent.setScore2(score2);
newStudent.setScore3(score3);
newStudent.setFinal(finalScore);
}
fin.close();
newMyClass.push_back(newStudent);
修正缩进后，很容易看到{<1}}仅在文件被完全读取后才被推入向量。 OP应该让最后一个学生进入矢量，但其他人都没有。由于OP可能希望文件中的所有学生都在向量中，
newStudent 无法验证代码的其余部分，因为似乎没有（OP已经解决了这个问题）while(fin >> name >> score1 >> score2 >> score3 >> finalScore)
{
newStudent.setName(name);
newStudent.setScore1(score1);
newStudent.setScore2(score2);
newStudent.setScore3(score3);
newStudent.setFinal(finalScore);
newMyClass.push_back(newStudent); <- moved push_back to here
}
fin.close(); <- probably not necessary
的定义或赋值 - Crom只知道那些for循环是否覆盖了正确的地面 - 或者输入的有效性，因为没有提供输入文件。如果解析规则错误，OP可能没有读取任何内容。调试器会比另一个Stack Overflow帖子快得多。
新东西。
我不明白为什么输入也不解析。首先确保文件编码为ASCII文本。我不知道你的计算机上有什么工具可以做到这一点。我使用十六进制编辑器，让您以字节值而不是字符查看文件，以查看字符是否与其预期的ASCII值不匹配。文本编辑器可能会为您转换并隐藏差异。
例如，通常UTF-8编码的文件看起来与ASCII文件完全相同，除了开头的一些二进制文件，通知读者程序它是UTF-8文件并且可能包含非ASCII
如果不是，则存在问题。将文件重新保存为ASCII文件。如果是ASCII文件，请最小化。编写一个小程序，除了打开文件之外什么也不做，按令牌读取令牌，然后查看哪个令牌无法解析。像这样：
size一旦您知道文件失败的位置，您就可以提出一个新问题了。这个太过分了。