试图使Nashorn线程安全

时间:2016-02-22 20:32:57

标签: java playframework playframework-2.0 nashorn

我最近一直在玩Play!框架和Nashorn试图渲染Redux应用程序。最初,我在ThreadPoolExecutor中实现了多个Nashorn引擎,并在运行engine.eval()时使用了future。性能非常糟糕,我假设由于高I / O和我使用的阻塞未来。

更熟悉Play之后!和他们的异步/承诺模式,我试图只用一个ScriptEngine重新开始;每https://stackoverflow.com/a/30159424/5956783,脚本引擎本身是线程安全的,但绑定不是。这是完整的课程:

package services;

import akka.actor.ActorSystem;

import play.libs.F;
import scala.concurrent.ExecutionContext;

import java.io.FileReader;


import javax.inject.Inject;
import javax.inject.Singleton;
import javax.script.*;

@Singleton
public class NashornEngine extends JSEngineAbstract {

    private NashornThread engine;
    private final ActorSystem actorSystem;


    protected class NashornThread {
        private ScriptEngine engine;
        private final ExecutionContext executionContext = actorSystem.dispatchers().lookup("js-engine-executor");
        private CompiledScript compiledScript;


        public NashornThread() {
            try {
                String dir = System.getProperty("user.dir");
                this.engine = new ScriptEngineManager(null).getEngineByName("nashorn");
                this.compiledScript = ((Compilable) this.engine).compile(new FileReader(dir + "/public/javascripts/bundle.js"));
            } catch (Exception e) {
                System.out.println(e.getMessage());
            }
        }

        public ScriptEngine getEngine() {
            return engine;
        }

        public F.Promise<String> getContent(String path, String globalCode) {
            return F.Promise.promise(() -> this.executeMethod(path, globalCode), this.executionContext);
        }

        private String executeMethod(String path, String json) throws ScriptException {
            Bindings newBinding = engine.createBindings();
            try {
                this.compiledScript.eval(newBinding);
                getEngine().setBindings(newBinding, ScriptContext.ENGINE_SCOPE);
                getEngine().eval("var global = this;");
                getEngine().eval("var console = {log: print, error: print, warn: print};");
                String result = getEngine().eval("App.renderApp('" + path + "', " + json + ")").toString();

                return result;
            } catch(Exception e) {
                e.printStackTrace();
                return null;
            }
        }
    }


    @Inject
    public NashornEngine(ActorSystem actorSystem) {
        this.actorSystem = actorSystem;
        this.engine = new NashornThread();
    }

    @Override
    public F.Promise<String> getContent(String path, String globalCode) {
        try {
            F.Promise<String> result = engine.getContent(path, globalCode);

            return result.map((String r) -> r);
        } catch (Exception e) {
            e.printStackTrace();
            return null;
        }
    }
}

我的JavaScript应用程序导出App对象,方法renderApp(path, state)可见。这实际上 工作,但只有16次(是的,总是16次)。从迭代17开始,我得到以下异常并伴随着堆栈跟踪:

java.lang.ClassCastException: jdk.nashorn.internal.objects.NativeRegExpExecResult cannot be cast to jdk.nashorn.internal.objects.NativeArray
    at jdk.nashorn.internal.objects.NativeArray.getContinuousArrayDataCCE(NativeArray.java:1900)
    at jdk.nashorn.internal.objects.NativeArray.popObject(NativeArray.java:937)
    at jdk.nashorn.internal.runtime.ScriptFunctionData.invoke(ScriptFunctionData.java:660)
    at jdk.nashorn.internal.runtime.ScriptFunction.invoke(ScriptFunction.java:228)
    at jdk.nashorn.internal.runtime.ScriptRuntime.apply(ScriptRuntime.java:393)
    at jdk.nashorn.internal.scripts.Script$Recompilation$23589$782286AA$\^eval\_.L:22918$L:22920$matchPattern(<eval>:23049)
    at jdk.nashorn.internal.scripts.Script$Recompilation$23588$816752AAAAAA$\^eval\_.L:24077$L:24079$matchRouteDeep(<eval>:24168)
    at jdk.nashorn.internal.scripts.Script$Recompilation$23587$820262DAA$\^eval\_.L:24077$L:24079$matchRoutes$L:24252$L:24253(<eval>:24254)
    at jdk.nashorn.internal.scripts.Script$Recompilation$23586$809060$\^eval\_.L:23848$loopAsync$next(<eval>:23869)
    at jdk.nashorn.internal.scripts.Script$Recompilation$23584$808906AAA$\^eval\_.L:23848$loopAsync(<eval>:23875)
    at jdk.nashorn.internal.scripts.Script$Recompilation$23583$820189$\^eval\_.L:24077$L:24079$matchRoutes$L:24252(<eval>:24253)
    at jdk.nashorn.internal.scripts.Script$Recompilation$23582$819862AAA$\^eval\_.L:24077$L:24079$matchRoutes(<eval>:24252)
    at jdk.nashorn.internal.scripts.Script$Recompilation$23580$789440AA$\^eval\_.L:23151$L:23153$useRoutes$L:23209$match(<eval>:23239)
    at jdk.nashorn.internal.scripts.Script$Recompilation$23518$847004AA$\^eval\_.L:25026$L:25028$match(<eval>:25084)
    at jdk.nashorn.internal.scripts.Script$Recompilation$23468$3872AA$\^eval\_.L:53$renderApp(<eval>:147)
    at jdk.nashorn.internal.scripts.Script$23467$\^eval\_.:program(<eval>:1)
    at jdk.nashorn.internal.runtime.ScriptFunctionData.invoke(ScriptFunctionData.java:640)
    at jdk.nashorn.internal.runtime.ScriptFunction.invoke(ScriptFunction.java:228)
    at jdk.nashorn.internal.runtime.ScriptRuntime.apply(ScriptRuntime.java:393)
    at jdk.nashorn.api.scripting.NashornScriptEngine.evalImpl(NashornScriptEngine.java:446)
    at jdk.nashorn.api.scripting.NashornScriptEngine.evalImpl(NashornScriptEngine.java:403)
    at jdk.nashorn.api.scripting.NashornScriptEngine.evalImpl(NashornScriptEngine.java:399)
    at jdk.nashorn.api.scripting.NashornScriptEngine.eval(NashornScriptEngine.java:155)
    at javax.script.AbstractScriptEngine.eval(AbstractScriptEngine.java:264)
    at services.NashornEngine$NashornThread.executeMethod(NashornEngine.java:62)
    at services.NashornEngine$NashornThread.lambda$getContent$0(NashornEngine.java:48)
    at play.core.j.FPromiseHelper$$anonfun$promise$2.apply(FPromiseHelper.scala:36)
    at scala.concurrent.impl.Future$PromiseCompletingRunnable.liftedTree1$1(Future.scala:24)
    at scala.concurrent.impl.Future$PromiseCompletingRunnable.run(Future.scala:24)
    at akka.dispatch.TaskInvocation.run(AbstractDispatcher.scala:40)
    at akka.dispatch.ForkJoinExecutorConfigurator$AkkaForkJoinTask.exec(AbstractDispatcher.scala:397)
    at scala.concurrent.forkjoin.ForkJoinTask.doExec(ForkJoinTask.java:260)
    at scala.concurrent.forkjoin.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1339)
    at scala.concurrent.forkjoin.ForkJoinPool.runWorker(ForkJoinPool.java:1979)
    at scala.concurrent.forkjoin.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:107)

我的印象是,使用已编译的脚本创建新绑定将被视为引擎的新网络,但似乎并非如此。如果有的话,我在这里做错了什么?

我也尝试使用Invocable来调用App对象上的方法,但这并没有任何区别。

修改 我是一台带有超线程的8核机器,因此可以解释在第17次尝试失败之前的16次成功尝试。另外,我已将executeMethod方法更新为:

private String executeMethod(String path, String json) throws ScriptException {
            Bindings newBinding = engine.createBindings();
            try {
                this.compiledScript.eval(newBinding);
                getEngine().eval("var global = this;", newBinding);
                getEngine().eval("var console = {log: print, error: print, warn: print};", newBinding);
                Object app = getEngine().eval("App", newBinding);
                Invocable invEngine = (Invocable) getEngine();
                String result = invEngine.invokeMethod(app, "renderApp", path, json).toString();
//              String result = getEngine().eval("App.renderApp('" + path + "', " + json + ")", newBinding).toString();

                return result;
            } catch(Exception e) {
                e.printStackTrace();
                return null;
            }
        }

2 个答案:

答案 0 :(得分:2)

更新到最新版本的Nashorn或Java 1.8u76可以解决问题。

答案 1 :(得分:1)

不幸的是你在Nashorn中遇到了bug。好消息是它已经修复,修复版可以在current early access releases中找到。