C#:如何在我的存储库类中包装我的工作单元代码

时间:2016-02-11 13:14:51

标签: c# ado.net repository-pattern unit-of-work

查看我的存储库代码

public abstract class AdoRepository<T> where T : class
    {
        private static SqlConnection _connection;

        public AdoRepository(string connectionString)
        {
            _connection = new SqlConnection(connectionString);
        }

        public virtual T PopulateRecord(SqlDataReader reader)
        {
            return null;
        }

        public virtual void GetDataCount(int count)
        {

        }

        protected IEnumerable<T> GetRecords(SqlCommand command)
        {
            var list = new List<T>();
            command.Connection = _connection;
            _connection.Open();
            try
            {
                var reader = command.ExecuteReader();
                try
                {
                    while (reader.Read())
                    {
                        list.Add(PopulateRecord(reader));
                    }

                    reader.NextResult();
                    if (reader.HasRows)
                    {
                        while (reader.Read())
                        {
                            GetDataCount(Convert.ToInt32(reader["Count"].ToString()));
                        }
                    }
                }
                finally
                {
                    // Always call Close when done reading.
                    reader.Close();
                }
            }
            catch(Exception ex)
            {
                string Msg = ex.Message;
            }
            finally
            {
                _connection.Close();
            }
            return list;
        }

        protected T GetRecord(SqlCommand command)
        {
            T record = null;
            command.Connection = _connection;
            _connection.Open();
            try
            {
                var reader = command.ExecuteReader();
                try
                {
                    while (reader.Read())
                    {
                        record = PopulateRecord(reader);
                        break;
                    }
                }
                finally
                {
                    // Always call Close when done reading.
                    reader.Close();
                }
            }
            finally
            {
                _connection.Close();
            }
            return record;
        }

        protected IEnumerable<T> ExecuteStoredProc(SqlCommand command)
        {
            var list = new List<T>();
            command.Connection = _connection;
            command.CommandType = CommandType.StoredProcedure;
            _connection.Open();
            try
            {
                var reader = command.ExecuteReader();
                try
                {
                    while (reader.Read())
                    {
                        var record = PopulateRecord(reader);
                        if (record != null) list.Add(record);
                    }
                }
                finally
                {
                    // Always call Close when done reading.
                    reader.Close();
                }
            }
            finally
            {
                _connection.Close();
            }
            return list;
        }
    }

   public class StudentRepository : AdoRepository<Student>
    {
        public int DataCounter { get; set; }

        public StudentRepository(string connectionString)
            : base(connectionString)
        {
        }
        public IEnumerable<Student> GetAll()
        {
            // DBAs across the country are having strokes 
            //  over this next command!
            using (var command = new SqlCommand("SELECT ID, FirstName,LastName,IsActive,StateName,CityName FROM vwListStudents"))
            {
                return GetRecords(command);
            }
        }
        public Student GetById(string id)
        {
            // PARAMETERIZED QUERIES!
            using (var command = new SqlCommand("SELECT ID, FirstName,LastName,IsActive,StateName,CityName FROM vwListStudents WHERE Id = @id"))
            {
                command.Parameters.Add(new ObjectParameter("id", id));
                return GetRecord(command);
            }
        }

        public IEnumerable<Student> GetStudents(int StartIndex, int EndIndex, string sortCol, string sortOrder)
        {
            string strSQL = "SELECT * FROM vwListStudents WHERE ID >=" + StartIndex + " AND ID <=" + EndIndex;
            strSQL += " ORDER BY " + sortCol + " " + sortOrder;
            strSQL += ";SELECT COUNT(*) AS Count FROM vwListStudents";
            var command = new SqlCommand(strSQL);
            return GetRecords(command);
        }

        public override Student PopulateRecord(SqlDataReader reader)
        {
            return new Student
            {
                ID = Convert.ToInt32(reader["ID"].ToString()),
                FirstName = reader["FirstName"].ToString(),
                LastName = reader["LastName"].ToString(),
                IsActive = Convert.ToBoolean(reader["IsActive"]),
                StateName = reader["StateName"].ToString(),
                CityName = reader["CityName"].ToString()
            };
        }

        public override void GetDataCount(int count)
        {
            DataCounter = count;
        }
    }

这样添加了工作单元代码

public class UnitOfWorkFactory
{
    public static IUnitOfWork Create()
    {
        var connection = new SqlConnection(ConfigurationManager.ConnectionStrings("MyDb").ConnectionString);
        connection.Open();

        return new AdoNetUnitOfWork(connection, true);
    }
}

public class AdoNetUnitOfWork : IUnitOfWork
{
    public AdoNetUnitOfWork(IDbConnection connection, bool ownsConnection)
    {
        _connection = connection;
        _ownsConnection=ownsConnection;
        _transaction = connection.BeginTransaction();
    }

    public IDbCommand CreateCommand()
    {
        var command = _connection.CreateCommand();
        command.Transaction = _transaction;
        return command;
    }

    public void SaveChanges()
    {
        if (_transaction == null)
            throw new InvalidOperationException("Transaction have already been commited. Check your transaction handling.");

        _transaction.Commit();
        _transaction = null;
    }

    public void Dispose()
    {
        if (_transaction != null)
        {
            _transaction.Rollback();
            _transaction = null;
        }

        if (_connection != null && _ownsConnection)
        {
            _connection.Close();
            _connection = null;
        }
    }
}

using (var uow = UnitOfWorkFactory.Create())
{
    var repos = new UserRepository(uow);

    uow.SaveChanges();
}

public class UserRepository
{
    private AdoNetUnitOfWork _unitOfWork;

    public UserRepository(IUnitOfWork uow)
    {
        if (uow == null)
            throw new ArgumentNullException("uow");

        _unitOfWork = uow as AdoNetUnitOfWork;
        if (_unitOfWork == null)
            throw new NotSupportedException("Ohh my, change that UnitOfWorkFactory, will you?");
    }

    public User Get(Guid id)
    {
        using (var cmd = _unitOfWork.CreateCommand())
        {
            cmd.CommandText = "SELECT * FROM Users WHERE Id = @id");
            cmd.AddParameter("id", id);

            // uses an extension method which I will demonstrate in a 
            // blog post in a couple of days
            return cmd.FirstOrDefault<User>();
        }
    }
}

但我想在我的存储库类中添加工作单元代码。可能在AdoRepository类或StudentRepository类中,因此我不必一次又一次地编写以下代码。

using (var uow = UnitOfWorkFactory.Create())
{
    var repos = new UserRepository(uow);

    uow.SaveChanges();
}

所以,当我将使用UserRepository这样的任何存储库时,我必须一次又一次地重复这行代码UnitOfWorkFactory.Create(),我不想要我想要一种嵌入单元的方法在一些集中的工作代码中,我可以减少重复的代码。

所以寻找想法和建议。如果可能的话,给我修改版本的代码。

感谢

1 个答案:

答案 0 :(得分:1)

我会直截了当地说:

包含存储库的UoW至少在涉及DDD时是反模式。如果它不是,那么您正在处理一个非常简单的应用程序,这样可以让您的生活更轻松,并使用实现您想要的ORM。

作为一个拇指规则,存储库可能包含一个UoW作为实现细节,您应该确定您确实需要一个存储库。 UoW中的存储库是一个非常具体的案例,仅对CRUD应用程序有效,您只需重新构建ORM的一小部分。

直接使用ado.net浪费时间(和金钱)。使用ORM或数据映射器aka micro-ORM。对于后一种选择,UoW是Db交易。

使用Ado.Net你不会获得任何重要的东西,性能提升很小,甚至不好笑(我知道,因为我已经对它进行了基准测试)。你唯一能得到的就是更长的时间和人为错误。

实际上,如果我更好地查看您的代码,您基本上是在构建一个微型ORM,而不知道它。它仍然不是一个存储库,因为抽象没有业务语义,而且它与实现细节紧密耦合。