Question

这是来自连接四游戏原型的验证，但似乎我做错了。我希望每当玩家进行移动时，该功能将通过垂直，水平和最终在对角线上进行验证来验证他是否赢了。但它似乎没有正确验证，因为在某些情况下，即使只进行了2次移动，函数返回1.

    int verifyGame(int gamePosition, int gameVariable, char gameArray[HEIGTH][WIDTH])
{

  if(gameArray[gamePosition][gameVariable] == gameArray[gamePosition + 1][gameVariable] == gameArray[gamePosition + 2][gameVariable] == gameArray[gamePosition + 3][gameVariable]) //verify vertically
        return 1;
      else
        if(gameArray[gamePosition][gameVariable] == gameArray[gamePosition][gameVariable - 3] == gameArray[gamePosition][gameVariable - 2] == gameArray[gamePosition][gameVariable - 1]) //verify horizontally
          return 1;
      else
         if(gameArray[gamePosition][gameVariable] == gameArray[gamePosition][gameVariable - 2] == gameArray[gamePosition][gameVariable - 1] == gameArray[gamePosition][gameVariable + 1])
          return 1;
      else
         if(gameArray[gamePosition][gameVariable] == gameArray[gamePosition][gameVariable - 1] == gameArray[gamePosition][gameVariable + 1] == gameArray[gamePosition][gameVariable + 2])
          return 1;
      else
         if(gameArray[gamePosition][gameVariable] == gameArray[gamePosition][gameVariable + 1] == gameArray[gamePosition][gameVariable+ 2] == gameArray[gamePosition][gameVariable + 3])
          return 1;
      //verify diagonally


      else return 0;
};

这是调用函数的地方。交换机验证用户输入，然后将值放在矩阵中，然后验证是否赢了

    printf("playerPick is : %d\n", playerPick);
  fflush(stdout);
  switch(playerPick)
  {
    case 1:
     if(gameVariables[0] >0 && gameVariables[0] < 7)
      {
        --gameVariables[0];
        gameArray[gameVariables[0]][0] = (char) 82;
       ifWon = verifyGame(gameVariables[0], 0, gameArray);
      }
      printArray(gameArray);
      break;
    case 2:

      if(gameVariables[1] >0 && gameVariables[1] < 7)
      {
        --gameVariables[1];
        gameArray[gameVariables[1]][1] = (char) 82;
        ifWon = verifyGame(gameVariables[1], 1, gameArray);
      }
      printArray(gameArray);
      break;
    case 3:
      if(gameVariables[2] >0 && gameVariables[2] < 7)
        {
          --gameVariables[2];
          gameArray[gameVariables[2]][2] = (char) 82;
          ifWon = verifyGame(gameVariables[2], 2, gameArray);
        }
      printArray(gameArray);
      break;
    case 4:
      if(gameVariables[3] >0 && gameVariables[3] < 7)
        {
          --gameVariables[3];
          gameArray[gameVariables[3]][3] = (char) 82;
          ifWon = verifyGame(gameVariables[3], 3, gameArray);
        }
      printArray(gameArray);
      break;
    case 5:
      if(gameVariables[4] >0 && gameVariables[4] < 7)
      {
        --gameVariables[4];
        gameArray[gameVariables[4]][4] = (char) 82;
        ifWon = verifyGame(gameVariables[4], 4, gameArray);
      }
      printArray(gameArray);
      break;
    case 6:
      if(gameVariables[5] >0 && gameVariables[5] < 7)
      {
        --gameVariables[5];
        gameArray[gameVariables[5]][5] = (char) 82;
        ifWon = verifyGame(gameVariables[5], 5, gameArray);
      }
      printArray(gameArray);
      break;
    case 7:
      if(gameVariables[6] >0 && gameVariables[6] < 7)
      {
        --gameVariables[6];
        gameArray[gameVariables[6]][6] = (char) 82;
        ifWon = verifyGame(gameVariables[6], 6, gameArray);
      }
      printArray(gameArray);
      break;

  }
  printf("%d %d %d %d %d %d %d\n", gameVariables[0], gameVariables[1], gameVariables[2], gameVariables[3], gameVariables[4], gameVariables[5], gameVariables[6]);
  printf("ifwon :  %d\n", ifWon);

Answer 1

@Weather Vane的回答是正确的。原始帖子中使用的逻辑对于验证不正确。

您自己可能没有抓住它的一个原因 可能是它编写的复杂方式。尝试简化用户输入验证码:(范围检查用户输入值是必要的。）

//User input range checking:
if((gamePosition >= x)&&    //where `x` is minimum for gamePosition
   (gamePosition <= y)&&    //where `y` is maximum for gamePosition
   (gameVariable >= z)&&    //where `z` is minimum for gameVariable
   (gameVariable <= w))     //where `w` is maximum for gameVariable
{//continue }
else 
{
    printf("Invalid value.  Please re-enter");
    return -1;
}

简化的另一个机会 是要注意每个case语句包含相同的代码，但大小写的值除外。因此，整个switch(...){...}可以替换为单个 if 语句：

//assuming playerPick >= 1
  if(gameVariables[playerPick-1] >0 && gameVariables[playerPick-1] < 7)
  {
    --gameVariables[playerPick-1];
    gameArray[gameVariables[playerPick-1]][playerPick-1] = (char) 82;
    ifWon = verifyGame(gameVariables[playerPick-1], playerPick-1, gameArray);
  }
  printArray(gameArray);

还要注意 ，但声明：

gameArray[gameVariables[0][0] = (char) 82; //what is 82?

是完全合法的，变量gameArray [0] [0]只是一个char，所以不需要输出值82。此外，C语法提供了一种方法，通过用graves符号包围它来提取角色的 ASCII 十进制值，允许以下形式，即更具可读性：

gameArray[gameVariables[0]][0] = `R`;       //intuitive

Answer 2

您无法在尝试时进行链接测试。代码将执行，但不是你想象的那样。你的代码

if(gameArray[gamePosition][gameVariable] == 
   gameArray[gamePosition + 1][gameVariable] == 
   gameArray[gamePosition + 2][gameVariable] == 
   gameArray[gamePosition + 3][gameVariable])

必须分成单独的测试，例如：

if(gameArray[gamePosition][gameVariable] == gameArray[gamePosition + 1][gameVariable] &&
   gameArray[gamePosition][gameVariable] == gameArray[gamePosition + 2][gameVariable] &&
   gameArray[gamePosition][gameVariable] == gameArray[gamePosition + 3][gameVariable])

以及其他方面。

C - 验证Connect Four游戏中的胜利条件

2 个答案: