成员函数指针作为模板参数的麻烦

时间:2015-10-11 18:52:53

标签: c++ templates c++11 variadic

下面代码中的注释掉的行不会编译,因为类型#include <memory> #include <functional> #include <map> #include <tuple> template <typename R, typename T, typename... Args> std::function<R(Args...)> memoizeMemberFunction (R T::*f(Args...), const T* t) { auto cache = std::make_shared<std::map<std::tuple<const T*, Args...>, R>>(); return ([f, cache](T* t, Args... args) { const std::tuple<const T*, Args...> tuple(t, args...); if (cache->find(tuple) == cache->end()) (*cache)[tuple] = (t->*f)(args...); // Insert 'tuple' as a new key in the map *cache. return (*cache)[tuple]; }); } template <typename Class, typename Fptr, Fptr> struct MemberFunctionMemoizer; template <typename Class, typename R, typename... Args, R Class::*F(Args...)> struct MemberFunctionMemoizer<Class, R (Class::*)(Args...) const, F> { static std::function<R(Class*, Args...)>& get (const Class* p) { static std::function<R (Args...)> memoizedF (memoizeMemberFunction(F, p)); return memoizedF; } }; struct FibonacciCalculator { unsigned long calculate(unsigned num) const { using F = MemberFunctionMemoizer<FibonacciCalculator, unsigned long (FibonacciCalculator::*)(unsigned) const, &FibonacciCalculator::calculate>; // return (num < 2) ? num : F::get(this)(num - 1) + F::get(this)(num - 2); // Won't compile because F does not meet the specialization. } }; #include <iostream> int main() { FibonacciCalculator fib; std::cout << fib.calculate(10) << '\n'; } 不符合专业化。有人可以解释原因吗?

F

我在这里遗漏了什么吗?如何让add_filter('sidebars_widgets', 'otw_sidebars_widgets', 100000); 满足专业化需求?我尝试从图片中删除const限定符,但同样的问题仍然存在。

我还想保持使用成员函数指针作为模板参数的设计,即使通过使用非成员函数指针解决了这个特定问题。

2 个答案:

答案 0 :(得分:0)

您遇到的最大问题是您尝试记住签名功能:

unsigned long calculate();

但是您使用F::get(this)num - 1调用了memoization缓存的返回函数num - 2

换句话说:memoization依赖于以下事实:使用相同参数调用的&#34;函数产生相同的返回值&#34;但是你记忆的功能并没有采取任何参数(本身没有任何问题),但你不应该将任何参数传递给它。

您当前的FibonacciCalculator类无法使用memoization,因为它目前已实现。

我做了一个实现,可能做你想做的事情;它计算Fibonacci数它会记住成员函数调用... 注意:有额外的噪音&#39;在memoizeMemberFunction()中,但该输出显示它正在工作 - 您将在输出中看到函数调用被使用两次并且只计算一次。

#include <iostream>
#include <memory>
#include <functional>
#include <map>
#include <tuple>

template <typename R, typename T, typename... Args>
std::function<R(Args...)> memoizeMemberFunction (R (T::*f)(Args...), T* t) {
    auto cache = std::make_shared<std::map<std::tuple<T*, Args...>, R>>();
    return [f, t, cache](Args... args) {
        const std::tuple<T*, Args...> tuple(t, args...);
        if (cache->find(tuple) == cache->end()) {
            (*cache)[tuple] = (t->*f)(args...);  // Insert 'tuple' as a new key in the map *cache.
            std::cout << "Computed f(";
            int dummy[sizeof...(Args)] = { (std::cout << args << ", ", 0)... };
            std::cout << ") = " << (*cache)[tuple] << std::endl;
        }
        std::cout << "Using f(";
        int dummy[sizeof...(Args)] = { (std::cout << args << ", ", 0)... };
        std::cout << ") = " << (*cache)[tuple] << std::endl;
        return (*cache)[tuple];
    };
}

struct FibonacciCalculator {
    unsigned long num;
    unsigned long calculate(unsigned long n = (unsigned long)-1) {
        static auto memoizedF (memoizeMemberFunction(&FibonacciCalculator::calculate, this));
        if( n==(unsigned long)-1 )
            return memoizedF(num);
        return (n < 2) ? n : memoizedF(n-1) + memoizedF(n-2);
    }
};

int main() {
    FibonacciCalculator fib{ 10 };
    std::cout << fib.calculate() << '\n';
}

答案 1 :(得分:0)

感谢dyp纠正了我对语法的可怕困难,我已经完成了我的目标:

#include <memory>
#include <functional>
#include <map>
#include <tuple>

template <typename R, typename T, typename... Args>
std::function<R(Args...)> memoizeMemberFunction (R (T::*f)(Args...), T* t) {
    auto cache = std::make_shared<std::map<std::tuple<T*, Args...>, R>>();
    return ([f, cache, t](Args... args) {
        const std::tuple<T*, Args...> tuple(t, args...);
        if (cache->find(tuple) == cache->end())
            (*cache)[tuple] = (t->*f)(args...);  // Insert 'tuple' as a new key in the map *cache.
        return (*cache)[tuple];
    });
}

template <typename R, typename T, typename... Args>
std::function<R(Args...)> memoizeConstMemberFunction (R (T::*f)(Args...) const, const T* t) {
    auto cache = std::make_shared<std::map<std::tuple<const T*, Args...>, R>>();
    return ([f, cache, t](Args... args) {
        const std::tuple<const T*, Args...> tuple(t, args...);
        if (cache->find(tuple) == cache->end())
            (*cache)[tuple] = (t->*f)(args...);  // Insert 'tuple' as a new key in the map *cache.
        return (*cache)[tuple];
    });
}

template <typename Class, typename Fptr, Fptr> struct MemberFunctionMemoizer;
template <typename Class, typename Fptr, Fptr> struct ConstMemberFunctionMemoizer;

template <typename Class, typename R, typename... Args, R (Class::*F)(Args...) const>
struct ConstMemberFunctionMemoizer<Class, R (Class::*)(Args...) const, F> {
    static std::function<R(Args...)>& get (const Class* p) {
        static std::function<R (Args...)> memoizedF (memoizeConstMemberFunction(F, p)); 
        return memoizedF;
    }
};

template <typename Class, typename R, typename... Args, R (Class::*F)(Args...)>
struct MemberFunctionMemoizer<Class, R (Class::*)(Args...), F> {
    static std::function<R(Args...)>& get (Class* p) {
        static std::function<R (Args...)> memoizedF (memoizeMemberFunction(F, p)); 
        return memoizedF;
    }
};

// Testing
#include <iostream>
#include <vector>

struct FibonacciCalculator {
    std::vector<unsigned long> computed;
    unsigned long calculate (unsigned num) const {
        using F = ConstMemberFunctionMemoizer<FibonacciCalculator, unsigned long (FibonacciCalculator::*)(unsigned) const, &FibonacciCalculator::calculate>;  // 'decltype(&FibonacciCalculator::calculate)' can be used in place of 'unsigned long (FibonacciCalculator::*)(unsigned) const'.
        return (num < 2) ? num : F::get(this)(num - 1) + F::get(this)(num - 2);
    }
    unsigned long calculateAndStore (unsigned num) {
        using F = MemberFunctionMemoizer<FibonacciCalculator, unsigned long (FibonacciCalculator::*)(unsigned), &FibonacciCalculator::calculateAndStore>;  // 'decltype(&FibonacciCalculator::calculateAndStore)' can be used in place of 'unsigned long (FibonacciCalculator::*)(unsigned)'.
        const unsigned long result = (num < 2) ? num : F::get(this)(num - 1) + F::get(this)(num - 2);
        computed.push_back(result);
        return result;
    }
};

int main() {
    FibonacciCalculator fib;
    for (unsigned i = 1; i < 20; i++)
        std::cout << fib.calculate(i) << ' ';  // 1 1 2 3 5 8 13 21 34 55 89 144 233 377 610 987 1597 2584 4181
    std::cout << '\n';

    for (unsigned i = 1; i < 20; i++)
        std::cout << fib.calculateAndStore(i) << ' ';  // 1 1 2 3 5 8 13 21 34 55 89 144 233 377 610 987 1597 2584 4181
    std::cout << '\n';
    for (unsigned long x : fib.computed)
        std::cout << x << ' ';  // 1 1 0 1 1 2 2 3 3 5 5 8 8 13 13 21 21 34 34 55 55 89 89 144 144 233 233 377 377 610 610 987 987 1597 1597 2584 2584 4181
    std::cout << '\n';  
}