无与伦比的井字游戏中的错误

时间:2015-08-11 22:16:21

标签: python function

我正在尝试按照我为绝对新手第3版购买Python编程的书。第6章挑战4,要求使游戏井字游戏无与伦比。通过修改computer_move()函数。我修改了它以使游戏无与伦比(当人类玩家在前两个动作中占据相反角落时是策略中的漏洞)。但我现在打破了计算机先行的部分。我不明白为什么。

我收到错误 TypeError: list indices must be integers, not NoneType

# Tic-Tac-Toe
# Plays the game of tic-tac-toe against a human opponent

# global constants
X = "X"
O = "O"
EMPTY = " "
TIE = "TIE"
NUM_SQUARES = 9


def display_instruct():
    """Display game instructions."""  
    print(
    """
    Welcome to the greatest intellectual challenge of all time: Tic-Tac-Toe.  
    This will be a showdown between your human brain and my silicon processor.  

    You will make your move known by entering a number, 0 - 8.  The number 
    will correspond to the board position as illustrated:

                    0 | 1 | 2
                    ---------
                    3 | 4 | 5
                    ---------
                    6 | 7 | 8

    Prepare yourself, human.  The ultimate battle is about to begin. \n
    """
    )

def ask_yes_no(question):
    """Ask a yes or no question."""
    response = None
    while response not in ("y", "n"):
        response = input(question).lower()
    return response

def ask_number(question, low, high):
    """Ask for a number within a range."""
    response = None
    while response not in range(low, high):
        response = int(input(question))
    return response

def pieces():
    """Determine if player or computer goes first."""
    go_first = ask_yes_no("Do you require the first move? (y/n): ")
    if go_first == "y":
        print("\nThen take the first move.  You will need it.")
        human = X
        computer = O
    else:
        print("\nYour bravery will be your undoing... I will go first.")
        computer = X
        human = O
    return computer, human

def new_board():
    """Create new game board."""
    board = []
    for square in range(NUM_SQUARES):
        board.append(EMPTY)
    return board

def display_board(board):
    """Display game board on screen."""
    print("\n\t", board[0], "|", board[1], "|", board[2])
    print("\t", "---------")
    print("\t", board[3], "|", board[4], "|", board[5])
    print("\t", "---------")
    print("\t", board[6], "|", board[7], "|", board[8], "\n")

def legal_moves(board):
    """Create list of legal moves."""
    moves = []
    for square in range(NUM_SQUARES):
        if board[square] == EMPTY:
            moves.append(square)
    return moves

def winner(board):
    """Determine the game winner."""
    WAYS_TO_WIN = ((0, 1, 2),
                   (3, 4, 5),
                   (6, 7, 8),
                   (0, 3, 6),
                   (1, 4, 7),
                   (2, 5, 8),
                   (0, 4, 8),
                   (2, 4, 6))

    for row in WAYS_TO_WIN:
        if board[row[0]] == board[row[1]] == board[row[2]] != EMPTY:
            winner = board[row[0]]
            return winner

    if EMPTY not in board:
        return TIE

    return None

def human_move(board, human):
    """Get human move."""  
    legal = legal_moves(board)
    move = None
    while move not in legal:
        move = ask_number("Where will you move? (0 - 8):", 0, NUM_SQUARES)
        if move not in legal:
            print("\nThat square is already occupied, foolish human.  Choose    another.\n")
    print("Fine...")
    return move

def computer_move(board, computer, human):
    """Make computer move."""
    # make a copy to work with since function will be changing list
    board = board[:]
    # the best positions to have, in order
    BEST_MOVES = (4, 0, 2, 6, 8, 1, 3, 5, 7)
    #INCLUDED FOR CHALLENGE 4 CHAPTER 6 TO MAKE THE GAME UNBEATABLE
    SMART_HUMAN = ((2, 0), (6, 8))
    print("I shall take square number", end=" ")

    # if computer can win, take that move
    for move in legal_moves(board):
        board[move] = computer
        if winner(board) == computer:
            print(move)
            return move
        # done checking this move, undo it
        board[move] = EMPTY

    # if human can win, block that move
    for move in legal_moves(board):
        board[move] = human
        if winner(board) == human:
            print(move)
            return move
        # done checkin this move, undo it
        board[move] = EMPTY

    # since no one can win on next move, pick best open square
    for move in BEST_MOVES:
        if move in legal_moves(board):
            print(move)
            return move
    #EXTENDED FOR CHALLENGE 4 CHAPTER 6 TO MAKE THE GAME UNBEATABLE
        elif move not in legal_moves(board):
            for position in SMART_HUMAN:
                for move in position:
                    board[move] = computer
                    if move in legal_moves(board):
                        print (move)
                        return move



def next_turn(turn):
    """Switch turns."""
    if turn == X:
        return O
    else:
        return X


def congrat_winner(the_winner, computer, human):
    """Congratulate the winner."""
    if the_winner != TIE:
        print(the_winner, "won!\n")
    else:
        print("It's a tie!\n")

    if the_winner == computer:
        print("As I predicted, human, I am triumphant once more.  \n" \
              "Proof that computers are superior to humans in all regards.")

    elif the_winner == human:
        print("No, no!  It cannot be!  Somehow you tricked me, human. \n" \
              "But never again!  I, the computer, so swear it!")

    elif the_winner == TIE:
        print("You were most lucky, human, and somehow managed to tie me.  \n" \
              "Celebrate today... for this is the best you will ever achieve.")

def main():
    display_instruct()
    computer, human = pieces()
    turn = X
    board = new_board()
    display_board(board)

    while not winner(board):
        if turn == human:
            move = human_move(board, human)
            board[move] = human
        else:
            move = computer_move(board, computer, human)
            board[move] = computer
        display_board(board)
        turn = next_turn(turn)

    the_winner = winner(board)
    congrat_winner(the_winner, computer, human)

# start the program
main()
input("\n\nPress the enter key to quit.")

我不太确定它是从哪里生产NoneType的,我已经工作了好几天了,我看不出错误。它在主函数中产生错误,但我没有在那里修改,我不应该。

我觉得我真的超出了我的深度,我认为这是因为我使用了SMART_HUMAN的元组我将其修改为列表,但是我得到了类似的错误。

任何帮助都会非常感激!

编辑:我得到的完整错误是:

I shall take square number Traceback (most recent call last):
File "\chapter_6_challenge_4_computer_move_amended.py", line 217, in <module>
main()
File "\chapter_6_challenge_4_computer_move_amended.py", line 208, in main
board[move] = computer
TypeError: list indices must be integers, not NoneType

2 个答案:

答案 0 :(得分:0)

问题在于:

move = computer_move(board, computer, human)

如果返回None(意味着计算机没有找到任何移动),则程序退出并在后面的行中出错,因为在从列表中检索元素时需要提供整数,但是而是None

computer_move()函数中有一个错误,或者更有可能只是None缺少检查 - 在后一种情况下,当计算机没有返回移动时,你应该结束比赛,宣布平局。

答案 1 :(得分:0)

感谢您对此提供的所有帮助,它让我回过头来重新思考我的方法,这就是答案。

我为自己创建了两个错误,这两个错误都是通过删除SMART_HUMAN嵌套元组解决的。我太聪明而且感到困惑,通过在一个元组中嵌入计数器播放,它在播放器播放时导致错误,我也有不必要的行。完全删除SMART_HUMAN嵌套元组,只需添加一个elif语句来播放位置1以对抗计数器。

这是现在的功能,最后的声明是工作解决方案。如果它是一个更大的更复杂的游戏,可能有一个更好的解决方案,但对于它的简单工作:P

def computer_move(board, computer, human):
"""Make computer move."""
# make a copy to work with since function will be changing list
board = board[:]
# the best positions to have, in order
BEST_MOVES = (4, 0, 2, 6, 8, 1, 3, 5, 7)

print("I shall take square number", end=" ")

# if computer can win, take that move
for move in legal_moves(board):
    board[move] = computer
    if winner(board) == computer:
        print(move)
        return move
    # done checking this move, undo it
    board[move] = EMPTY

# if human can win, block that move
for move in legal_moves(board):
    board[move] = human
    if winner(board) == human:
        print(move)
        return move
    # done checkin this move, undo it
    board[move] = EMPTY

# since no one can win on next move, pick best open square
for move in BEST_MOVES:
    if move in legal_moves(board):
        print(move)
        return move
#EXTENDED FOR CHALLENGE 4 CHAPTER 6 TO MAKE THE GAME UNBEATABLE
    elif move not in legal_moves(board):
        if BEST_MOVES[5] in legal_moves(board):
            print (BEST_MOVES[5])
            return BEST_MOVES[5]

我的游戏现在无与伦比:)