Question

我遇到了一个我似乎无法解决的问题。这是一个蒸汽交易机器人，它运作良好，除非两个人同时交易，因为class_id和other_id是全局变量，如果多个人使用它，它们将在交易中间发生变化。

我尝试在最后一个if语句中定义变量但是get_class_id没有找到变量。有没有什么方法async函数可以直接采用item.classid和convert_id_64（offer.accountid_other）而不将它们定义为变量？我感谢任何帮助。

var class_id
var other_id

function accept_all_trades(offers_recieved) {
offers_recieved.forEach( function(offer) {
    if (offer.trade_offer_state == 1) {
        if (typeof offer.items_to_give === "accept") {
            offers.acceptOffer({tradeOfferId: offer.tradeofferid}, function(error, response) {
                console.log('accepterat offer');
                offer.items_to_receive.forEach(function(item) {
                    if (item.appid === '420') {
                        class_id = item.classid;
                        other_id = convert_id_64(offer.accountid_other);
                        console.log(class_id);
                        async.waterfall([get_class_id, get_stack, get_name, get_save], add_names);
                    }
                });
            });
        }
    }
});
}

function get_class_id(callback) {
var test = class_id
callback(null, test)
}

更新

我已将代码更改为ben建议但仍然在调用get_class_id并尝试打印id时，它只是控制台中的空白行，是什么想法？

function get_class_id(callback) {
console.log(class_id);
var test = class_id;
callback(null, test)
}

Answer 1

The problem here is not aysnc.waterfall(). It's async calls (offers.acceptOffer(), get_class_id, get_stack, get_name, get_save, add_names) inside regular javascript forEach(). You need control-flow loops that can control the flow of those async calls. Here is the revised code using async.each():

function accept_all_trades(offers_recieved) {
    async.each(offers_recieved, function(offer, eachCb) {
        if (offer.trade_offer_state !== 1 || typeof offer.items_to_give !== "accept") {
            return eachCb(null);
        }
        offers.acceptOffer({tradeOfferId: offer.tradeofferid}, function(error, response) {
            console.log('accepterat offer');
            async.each(offer.items_to_receive, function(item, eachCb) {
                var class_id;
                var other_id;

                if (item.appid !== '420') {
                    return eachCb(null);
                }
                class_id = item.classid;
                other_id = convert_id_64(offer.accountid_other);
                console.log(class_id);
                async.waterfall([
                    function(waterfallCb) {
                        var test = class_id;
                        console.log(class_id);
                        waterfallCb(null, test);
                    },
                    get_stack,
                    get_name,
                    get_save,
                    add_names
                ], eachCb);
            }, function(err) {
                console.log(err);
                eachCb(null);
            });
        });
    });
}

make async.waterfall以另一个函数的参数开头

1 个答案: