ServiceNow脚本onSubmit无法正常工作

时间:2015-05-15 16:46:22

标签: javascript forms validation catalog servicenow

我正在使用ServiceNow平台。我正在编写一个目录客户端脚本来验证目录项记录生成器上的表单字段。

如果验证未通过检查,我将使用return false停止提交表单。

我通过输入无效数据(具有特殊字符的组名或已存在的组名)对此进行了测试,并且它捕获了问题并显示错误消息。我可以输入无效数据并多次提交并且有效。

然而,问题是:

在我首次输入无效数据并提交后,脚本似乎“停止”运行,然后我再次按下提交按钮更正数据。它只是坐在那里什么都不做。我必须重新加载表格,这是不可取的。

控制流程是怎么回事?如果数据无效,如何干净地停止表单,但是然后允许用户更正错误并再次按“提交”按钮继续?

我可以判断脚本没有再次运行,因为每次脚本运行时我都会弹出一个警告框,上面写着“脚本运行”。它在首先提交无效数据然后输入一些有效数据并按提交后,在某个时刻停止运行。

function onSubmit() {
    g_form.hideAllFieldMsgs('error');
    alert("script run");

    //Group Name contain letters numbers and dashes only
    var group_name = g_form.getValue('u_group_name');
    // Group name regular expression
    var regGrpName = /^([A-Za-z0-9\-]+)$/;
    // Check name against regular expression
    if (regGrpName.test(group_name) == false) {
        g_form.showFieldMsg('u_group_name', "Group Name must contain only letters, numbers or dashes. ", 'error');
        //Do not submit
        //g_form.submitted = false;
        return false;
    }

    //Check if google group already exists
    var rec = new GlideRecord('u_google_user_accounts');
    rec.addQuery('u_account_email', new_group_email);
    rec.query();

    while (rec.next()) {
        g_form.showFieldMsg('u_group_name',rec.u_account_email + " already exists as an account.",'error');
        return false;
    }

    //Group Members Email List separated by commas
    // Hide error message
    //g_form.hideErrorBox('u_group_members');
    var group_members = g_form.getValue('u_group_members');
    // Comma separate list
    var member_split = group_members.split(',');
    // Loop over list of email addresses
    for (var n = 0; n < member_split.length; n++) {
        // Trim whitespace
        var member_info = trim ? member_split[n].trim() : member_split[n];
        // Email validation regular expression
        var regEmail = /^\w+((-\w+)|(\.\w+))*\@[A-Za-z0-9]+((\.|-)[A-Za-z0-9]+)*\.[A-Za-z0-9]+$/;
        // Check each item against regular expression
        if (member_info.search(regEmail) == false) {
            g_form.showFieldMsg('u_group_members', "Group Members contains an invalid email address. " + member_info, 'error');
            //Do not submit
            //g_form.submitted = false;
            return false; 
        } else if (member_info.search(validRegExp) == true) {
            g_form.setValue('u_group_members', group_members);  
        }
    }
    return true;
}

2 个答案:

答案 0 :(得分:1)

我很高兴您找到了上面的解决方案,但我也想发表评论,询问您是否尝试过try {} catch {}块来处理无效数据?

答案 1 :(得分:0)

我想我已经解决了这个问题。我做了一个完全独立的函数来检查验证。 onSubmit调用验证函数并检查返回值。如果返回值为false,则它将停止表单。否则,即使多次尝试使用无效数据,也会提交。我认为这样做会有所帮助。如果有人能看到任何问题,请告诉我。谢谢你的帮助。

function onSubmit() {
    var isValid = checkGoogleGroup();
    if (isValid == false) {
        g_form.submitted = false;
        return false;
    }
}
function checkGoogleGroup() {
    g_form.hideAllFieldMsgs('error');
    //Group Name contain letters numbers and dashes only
    var group_name = g_form.getValue('u_group_name');
    // Group name regular expression
    var regGrpName = /^([A-Za-z0-9\-]+)$/;
    // Check name against regular expression
    validGroupName = regGrpName.test(group_name);
    if (validGroupName == false) {
        g_form.showFieldMsg('u_group_name', "Group Name must contain only letters, numbers or dashes. ", 'error');
        //Do not submit
        return false;
        }
//Check if google group already exists
    var rec = new GlideRecord('u_broad_user_accounts');
    rec.addQuery('u_account_email', new_group_email);
    rec.query();
    while (rec.next()) {
        g_form.showFieldMsg('u_group_name',rec.u_account_email + " already exists as an account.",'error');
        return false;
    }
//Group Members Email List separated by commas
    var group_members = g_form.getValue('u_group_members');
    // comma separate list
    var member_split = group_members.split(',');
    // loop over list of email addresses
    for (var n = 0; n < member_split.length; n++) {
        // trim whitespace
        var member_info = trim ? member_split[n].trim() : member_split[n];
        // validation regular expression
        var validRegExp = /^\w+((-\w+)|(\.\w+))*\@[A-Za-z0-9]+((\.|-)[A-Za-z0-9]+)*\.[A-Za-z0-9]+$/;
        // check each item against regular expression
        if (member_info.search(validRegExp) == -1) {
            g_form.showFieldMsg('u_group_members', "Group Members contains an invalid email address. " + member_info, 'error');
            return false;
        }
    }
}