在Action中使用ForEachAsync并等待时不等待

时间:2015-04-22 03:19:44

标签: c# .net entity-framework asynchronous async-await

以下内容应返回" C",但它会返回" B"

using System.Data.Entity;
//...
var state = "A";
var qry = (from f in db.myTable select f);
await qry.ForEachAsync(async (myRecord) => {
   await DoStuffAsync(myRecord);
   state = "B";
});
state = "C";
return state;

它不等待DoStuffAsync完成,state="C"运行,然后state="B"执行(因为它内部仍在等待)。

2 个答案:

答案 0 :(得分:8)

那是因为ForEachAsync的实现不等待委托行动

moveNextTask = enumerator.MoveNextAsync(cancellationToken);
action(current);

请参阅https://github.com/mono/entityframework/blob/master/src/EntityFramework/Infrastructure/IDbAsyncEnumerableExtensions.cs#L19

但那是因为,你不能等待一个动作,委托需要是一个返回任务的Func - 见How do you implement an async action delegate method?

因此,在Microsoft提供包含Func委托并使用await调用它的签名之前,您必须滚动自己的扩展方法。我现在正在使用以下内容。

public static async Task ForEachAsync<T>(
    this IQueryable<T> enumerable, Func<T, Task> action, CancellationToken cancellationToken) //Now with Func returning Task
{
    var asyncEnumerable = (IDbAsyncEnumerable<T>)enumerable;
    using (var enumerator = asyncEnumerable.GetAsyncEnumerator())
    {

        if (await enumerator.MoveNextAsync(cancellationToken).ConfigureAwait(continueOnCapturedContext: false))
        {
            Task<bool> moveNextTask;
            do
            {
                var current = enumerator.Current;
                moveNextTask = enumerator.MoveNextAsync(cancellationToken);
                await action(current); //now with await
            }
            while (await moveNextTask.ConfigureAwait(continueOnCapturedContext: false));
        }
    }
}

有了这个,OP中的原始测试代码将按预期工作。

答案 1 :(得分:0)

由于 DbSet 实现了 IAsyncEnumerable,请考虑使用以下扩展方法:

public async static Task ForEachAsync<T>(this IAsyncEnumerable<T> source, Func<T, Task> action, CancellationToken cancellationToken = default)
{
    if (source == null) return;
    await foreach (T item in source.WithCancellation(cancellationToken).ConfigureAwait(false))
    {
        await action(item);
    }
}

用法:

var qry = (from f in db.myTable select f);
await qry
     .AsAsyncEnumerable()
     .ForEachAsync(async arg =>
     {
         await DoStuffAsync(arg);
     });