我试图弄清楚如何报告下面代码中的任务列表引发的所有异常。
此代码段的基本思想是:用户向处理程序发送请求,处理程序创建消息tasks
并将它们发送到将它们发送到外部系统的类。我包括了下面涉及的方法。
我必须要有一些东西,因为我正在调试异常处理程序,并且任务Exception总是为null,因为看起来它们的状态为Waiting for Activiation
,除非我在断点处呆得足够长。
// Handle the user request
public async void Handle(WriteScanToSys settings)
{
_successfulScanIds = new List<int>();
// create the messages as tasks
var tasks = _factory.CreateMessage(settings).Select(msg => SendScans(msg));
try
{
// wait for all of them to complete
await Task.WhenAll(tasks); // I had ConfigureAwait(false) here, but took it off
}
catch (Exception)
{
foreach (var task in tasks.Where(t => t.Exception != null))
{
// ELMAH
var errorLog = ErrorLog.GetDefault(null);
errorLog.Log(new Error(task.Exception));
}
}
// save to repository
}
// the task to perform
private async Task<IDictionary<string, object>> SendScans(IDictionary<string, object> data)
{
object sysMsg = null;
var response = await _msgCenter.SendMessage(data);
response.TryGetValue("SystemMessage", out sysMsg);
_successfulScanIds.Add(Convert.ToInt32(data["Id"]));
return response;
}
// the communication with the external system (The message center class)
private async Task<IDictionary<string, object>> SendMessage(IDictionary<string, object> msg)
{
var response = new Dictionary<string, object>();
var response = await _client.sendAsync(
new BodyOfRequest(
// Compose Object
));
if (response.ScreenMessage != "SUCCESSFUL")
throw new CustomException("The transaction for job " + job + " failed with msg: " + body.ScreenMessage);
response.Add("SystemMessage", body.ScreenMessage);
return response;
}
答案 0 :(得分:8)
你已经厌倦了懒惰的评估 - Select
的结果会在你每次迭代时创建一组新的任务。您只需拨打ToList()
:
var tasks = _factory.CreateMessage(settings)
.Select(msg => SendScans(msg))
.ToList();
这样,您正在等待的任务集将与使用foreach
循环检查的任务相同。
答案 1 :(得分:2)
不是迭代所有任务,而是从Task.WhenAll
- 任务:
var taskResult = Task.WhenAll(tasks);
try
{
await taskResult;
}
catch (Exception e)
{
if (taskResult.IsCanceled)
{
// Cancellation is most likely due to a shared cancellation token. Handle as needed, possibly check if ((TaskCanceledException)e).CancellationToken == token etc.
}
else if (taskResult.IsFaulted)
{
// use taskResult.Exception which is an AggregateException - which you can iterate over (it's a tree! .Flatten() might help)
// caught exception is only the first observed exception
}
else
{
// Well, this should not really happen because it would mean: Exception thrown, not faulted nor cancelled but completed
}
}