Question

我有一个线程调用静态方法来使用WindowsAPICodePack ShellPropertyWriter和BackgroundWorker更新文件属性。该线程为1000多个文件的文件夹中的每个文件调用以下方法，并在第700次更新之后挂起在ShellPropertyWriter.close（）上。

与文件本身无关，尝试使用之前成功更新过的不同文件。

    public static bool ShellPropertyUpdate(VideoEntry mediaEntry)
    {
        try
        {
            ShellFile mediafile = ShellFile.FromFilePath(mediaEntry.FilePath);
            ShellPropertyWriter pw = mediafile.Properties.GetPropertyWriter();
            pw.WriteProperty(SystemProperties.System.Music.Artist, mediaEntry.Actor);
            pw.WriteProperty(SystemProperties.System.Music.Genre, mediaEntry.Genre);
            pw.WriteProperty(SystemProperties.System.Rating, mediaEntry.Rating);
            pw.Close();
        }
        catch (Exception ex)
        {
           return false;
        }
        return true;
    }

    private void mnuWriteMetadataToFiles_Click(object sender, EventArgs ev)
    {
        this.WorkerThread = new BackgroundWorker();
        this.WorkerThread.DoWork += new DoWorkEventHandler(WorkerThread_WriteMetadataToFiles);
        this.WorkerThread.ProgressChanged += new ProgressChangedEventHandler(WorkerThread_ProgressChanged);
        this.WorkerThread.RunWorkerCompleted += (s, e) => WorkerThread_Completed("Writing metadata to files", s, e);
        this.WorkerThread.WorkerReportsProgress = true;
        this.WorkerThread.WorkerSupportsCancellation = true;
        this.WorkerThread.RunWorkerAsync(WMPlayer);
    }

    private void WorkerThread_WriteMetadataToFiles(object sender, DoWorkEventArgs e)
    {
        int counter = 0;
        BackgroundWorker worker = (BackgroundWorker)sender;
        MediaPlayer wmp = (MediaPlayer)e.Argument;

        // ... Loop with the foreach video in the library and write it to file.
        foreach (VideoEntry entry in wmp.Videos)
        {
            if (worker.CancellationPending)
            {
                e.Cancel = true;
            }
            else
            {
                worker.ReportProgress(counter, "Updating '" + entry.Filename + "'" + Environment.NewLine + "Processing file");
                if (VideoToFile.ShellPropertyUpdate(entry))
                {
                    result &= true;
                }
                counter++;
            }
        }
        e.Result = result;
    }

Answer 1

之前从未听说过这个装配，但它闻起来像是让我疲惫不堪。试试这个：

using (ShellFile mediafile = ShellFile.FromFilePath(mediaEntry.FilePath))
{
    ShellPropertyWriter pw = mediafile.Properties.GetPropertyWriter();
    pw.WriteProperty(SystemProperties.System.Music.Artist, mediaEntry.Actor);
    pw.WriteProperty(SystemProperties.System.Music.Genre, mediaEntry.Genre);
    pw.WriteProperty(SystemProperties.System.Rating, mediaEntry.Rating);
    pw.Close();
}

此处每个文件句柄都会立即关闭，而不是由垃圾收集器自行决定。 ShellFile必须实现IDisposable才能生效，否则此代码将无法编译。我确信ShellFile实现了它。

Answer 2

显然它确实与文件本身有关。我拿出了一些问题文件，线程继续处理，直到下一个问题文件。我不知道该文件有什么问题，但是我愿意传递更新问题文件。有没有办法停止/杀死线程？我不能使用DoWorkEventArgs.cancel（）因为线程挂起而不回来。

C＃thread挂在关闭文件上

2 个答案: