Java迭代过度集合,将无法正常工作

时间:2014-08-06 17:32:08

标签: java

我目前正在开发一个Java项目,

以下是我到目前为止的编码尝试:

import java.util.*;
import java.io.*;
import javax.swing.*;
import java.awt.*;
import java.util.ArrayList;
import java.util.List;
import java.util.Iterator;
import java.util.HashMap;
import java.util.TreeMap;
import java.util.Collection;
import java.util.Map;

/**
 *
 * This class models a zoo. It allows a single animal to be added to the zoo, a
 * batch of animals to be "imported" by reading data from a text file and for all
 * the animals to be listed in a terminal window.  It also ensures that all animals
 * in the zoo have a unique identifier.
 *
 * @author Jacov
 * @version Version 1, 01 August 2014
 */

public class MyZoo
{
   // zoo identifier
   private String zooId;
   // a number used in generating a unique identifier for the next animal to be added to the zoo
   private int nextAnimalIdNumber;
   // zstorage for the Animal objects
   private TreeMap<String, Animal> animals;

   /**
    * Create an "empty" zoo.
    *
    * @param zooId an identifier for the zoo, at least three characters long.
    */
   public MyZoo(String zooId)
   {
      this.zooId = zooId.trim().substring(0,3).toUpperCase();
      nextAnimalIdNumber = 0;
      animals = new TreeMap<String, Animal>(animals);
   }

   /**
    * Returns a unique identifier, for an <tt>Animal</tt> object, based on the
    * zoo identifier and the field <tt>nextAnimalIdNumber</tt> which is incremented
    * ready for next time the method is called.
    *
    * @return a unique identifier.
    */
   public String allocateId()
   {
      // increment nextAnimalIdNumber and then construct a six digit string from it
      nextAnimalIdNumber++;
      String s = Integer.toString(nextAnimalIdNumber);
      while ( s.length()<6 )
        s = "0" + s;
      return zooId + "_" +  s;
   }

   /**
    * Adds an animal to the zoo.
    *
    * @param animal the Animal object to be added.
    */
   public void addAnimal(Animal animal)
   {
      animals.put(animal.getName(), animal);
   }

   /**
    * Reads <tt>Animal</tt> data from a text file and adds them to the zoo.  The
    * format of the data is specified in the MyZoo coursework assignment.
    *
    * @param animal the Animal object to be added.
    */
   public void readDataFromFile()
   {
      int noOfAnimalsRead = 0;

      // set up an owner for the FileDialog
      JFrame jframe = new JFrame();
      jframe.setVisible(true);
      // use a Filedialog to select a file to read from
      FileDialog fDialog = new FileDialog(jframe, "Read from", FileDialog.LOAD);
      fDialog.setFile("import001.txt");
      fDialog.setDirectory(".");
      fDialog.setVisible(true);
      String fname = fDialog.getFile();
      jframe.dispose();

       File inFile = new File(fname);

    String fileName = "import002.txt";

        // This will reference one line at a time
        String line = null;


        try {
            // FileReader reads text files in the default encoding.
            FileReader fileReader = 
                new FileReader(fileName);

            // Always wrap FileReader in BufferedReader.
            BufferedReader bufferedReader = 
                new BufferedReader(fileReader);

            while((line = bufferedReader.readLine()) != null) {
                System.out.println(line);
            }   

            // Always close files.
            bufferedReader.close();         
        }
        catch(FileNotFoundException ex) {
            System.out.println(
                "Unable to open file '" + 
                fileName + "'");                
        }
        catch(IOException ex) {
            System.out.println(
                "Error reading file '" 
                + fileName + "'");                  

        }

      addAnimal( new Animal("golden eagle", "Eddie", this) );               //
      addAnimal( new Animal("tiger", "Tommy", this) );            
      addAnimal( new Animal("lion", "Leo", this) );         
      addAnimal( new Animal("parrot", "Polly", this) );             
      addAnimal( new Animal("cobra", "Collin", this) );       

      noOfAnimalsRead = 5;                                       

      // this next line should be retained
      System.out.println("no of animals read from file was " + noOfAnimalsRead + "\n");
   }

   /**
    * Prints out details of all animal in the zoo.
    *
    */
   public void printAllAnimals()
   {

      System.out.println("\nDetails for all animals in Zoo " + zooId);
      System.out.println(  "==================================");

      Collection<Animal> c = animals.values();
    // The name of the file to open.
        String fileName = "import001.txt";

        // This will reference one line at a time
        String line = null;

        for(Object s: animals.keySet()) {

       // Yeah, I hate this too.
       String k = (String) s;

       // Now you can get the MailItems.  This is the part you were missing.
       List<Animal> listOfAnimals = animals.get(s);

       for(Animal animal: listOfAnimals) {
          System.out.println(animalItem.getSomething());
          }
        }
        }
    }

我目前无法使printAllAnimals()方法正常工作。

当执行方法printAllAnimals()时,它不会做任何事情而且不会,但它应该使用Collection对象c,以便可以轻松检查存储在动物园中的动物

任何帮助都会非常感激,因为我一直试图让这个工作几个小时,因此我很困惑。

1 个答案:

答案 0 :(得分:0)

此代码存在许多问题,我注意到的第一件事是你的构造函数使用动物Map来初始化它自己。只需使用空构造函数初始化地图。即。

animals = new TreeMap<String, Animal>();

然后调用方法从文件中读取也填充地图的文件。

readDataFromFile();

最后,如果你想迭代地图并显示内容,你需要做这样的事情:

for (Map.Entry<String, Animal> animalEntry : animals.entrySet())
{
    System.out.println(animalEntry.getKey() + "/" + ((Animal)animalEntry.getValue()).getName());
}