Question

我有这个巨大的头文件average.h，其中包含4个数组。我想通过使用线程分别计算4个数组的平均值来计算头文件的平均值。运行时我遇到了分段错误，所以我猜计算数组的长度有问题。有人告诉我，计算float**的大小是不可能的，那我该怎么办？

这是我的代码：

/*
 * File:   main.c
 * Author: thomasvanhelden
 *
 * Created on June 15, 2014, 5:34 AM
 */

#include <stdio.h>
#include <stdlib.h>
#include <pthread.h>
#include "average.h"

void* calc(void* param) {
    float** array = (float**) param;
    int size = sizeof(*array) / sizeof(float*);
    int i;
    float sum = 0;
    float* average;

    for (i = 0; i < size; i++) {
        sum += *array[i];
    }

    *average = sum/size;

    return average;
}

/*
 *
 */
int main(int argc, char** argv) {

    pthread_t t1, t2, t3, t4;   // thread handlers
    int res1, res2, res3, res4; // results of creating/joining the threads
    void *avg1, *avg2, *avg3, *avg4; // results of the threads as void*
    float *result1, *result2, *result3, *result4;   // results of the threads as flaot*

    // create the threads
    res1 = pthread_create(&t1, NULL, calc, a1);
    res2 = pthread_create(&t2, NULL, calc, a2);
    res3 = pthread_create(&t3, NULL, calc, a3);
    res4 = pthread_create(&t4, NULL, calc, a4);

    // check for errors creating the threads
    if (res1 || res2 || res3 || res4) {
        printf("Something went wrong creating the threads!\n");
        return 1;
    }

    // wait for the threads to finish and get the result
    res1 = pthread_join(t1, &avg1);
    res2 = pthread_join(t2, &avg2);
    res3 = pthread_join(t3, &avg3);
    res4 = pthread_join(t4, &avg4);

    // check for errors joining the threads
    if (res1 || res2 || res3 || res4) {
        printf("Something went wrong joining the threads!\n");
        return 1;
    }

    // void* to float*
    result1 = (float*) avg1;
    result2 = (float*) avg2;
    result3 = (float*) avg3;
    result4 = (float*) avg4;

    // print the result, should be
    printf("The average is: %f", (*result1 + *result2 + *result3 + *result4));


    return (EXIT_SUCCESS);
}

Answer 1

正如您所说，无法从指针中检索数组的大小。您必须将参数打包在结构中（您的float**，加上数组的大小以及任何其他相关信息），并将指向此结构的指针传递给pthread_create()。

请注意，您的worker函数必须返回指针，因此需要分配内存。如果你想避免动态分配，这里有一个模式重用参数struct作为返回值：

#include <stdio.h>
#include <string.h>
#include <pthread.h>

#define ARRAY_COUNT(arr) (sizeof (arr) / sizeof *(arr))

typedef union {
    struct {    // Function parameters
        float *array;
        size_t size;
    };
    struct {    // Function return value
        float result;
    };
} arrayAverageParam_u;

void *arrayAverage(void *param) {
    arrayAverageParam_u *_param = param;
    // From now on we can use _param to access the struct

    int i;
    float avg = 0.0f;
    for(i = 0; i < _param->size; ++i)
        avg += _param->array[i];

    if(i)
        avg /= i;

    // Store the result, overwriting the parameters
    _param->result = avg;

    return NULL;
}

main()
{
    float array[] = {1.0f, 2.0f, 3.0f, 4.0f};

    // Fill the struct with parameters
    arrayAverageParam_u param = {
        .array = array,
        .size = ARRAY_COUNT(array),
    };

    pthread_t thread;
    pthread_create(&thread, NULL, arrayAverage, &param);

    pthread_join(thread, NULL);

    // Retrieve the result from the struct
    printf("The average is %g\n", param.result);

    return 0;
}

计算数组的大小以使用线程计算平均值

1 个答案: