Question

代码：

public class FeatureBuilder implements IFeatureBuilder {

   private final Map< java.awt.Shape, ShapeAttributes > shapes = new HashMap<>();

   [...]

   @Override
   public void addToContainer( java.awt.Shape shape ) {
      System.err.println( shape.getClass());
      shapes.put( shape, new ShapeAttributes( ... ));
   }

   @Override
   public void removeFromContainer( double x, double y ) {
      final Set< Shape > rm  = new HashSet<>();
      final Point2D      loc = new Point2D.Double( x, y );
      for( final Shape shape : shapes.keySet()) {
         if( shape.contains( loc )) {
            System.err.println( "shapes.containsKey( shape ): " +
               shapes.containsKey( shape ));
            rm.add( shape );
         }
      }
      System.err.println( "cardinality before removal : " + shapes.size());
      shapes.keySet().removeAll( rm );
      System.err.println( "cardinality after  removal : " + shapes.size());
   }

输出：

class java.awt.geom.Rectangle2D$Double
shapes.containsKey( shape ): false      <<<<<<< This is unexpected!
cardinality before removal : 1
rm cardinality             : 1
cardinality after  removal : 1

我很惊讶：for上的Map.keySet()迭代器检索到的实例不是Map中的关键字！

这怎么可能？

此方法的主要错误是rm中放置的所选Shape实例未从shapes中删除。

阅读完答案后，代码变为：

public class DecoratedShape {

   public final Shape _shape;
   public /* */ Color _stroke      = Color.BLACK;
   public /* */ float _strokeWidth = 3.0f;
   public /* */ Color _fill        = Color.BLACK;

   public DecoratedShape( Shape shape, Color stroke, float strokeWidth, Color fill ) {
      _shape       = shape;
      _stroke      = stroke;
      _strokeWidth = strokeWidth;
      _fill        = fill;
   }

   public boolean contains( Point2D loc ) {
      return _shape.contains( loc );
   }

   public void paint( Graphics2D g ) {
      g.setStroke( new BasicStroke( _strokeWidth ));
      g.setColor( _fill );
      g.fill( _shape );
      g.setColor( _stroke );
      g.draw( _shape );
   }
}

public class FeatureBuilder implements IFeatureBuilder {

   private final List< DecoratedShape > _shapes = new LinkedList<>();
   [...]

   @Override
   public void addToContainer( Object o ) {
      _shapes.add( new DecoratedShape((Shape)o, _stroke, _strokeWidth, _fill ));
   }

   @Override
   public void removeFromContainer( double x, double y ) {
      final Set<DecoratedShape> rm = new HashSet<>();
      final Point2D loc = new Point2D.Double( x, y );
      for( final DecoratedShape shape : _shapes ){
         if( shape.contains( loc ) ){
            rm.add( shape );
         }
      }
      _shapes.removeAll( rm );
   }

   public void paint( Graphics2D g ) {
      for( final DecoratedShape shape : _shapes ) {
         shape.paint( g );
      }
   }
}

现在，它按预期工作......非常感谢！

Answer 1

跟进@ RohitJain的评论，这是一个重现行为的简单例子：

Map<Shape, Object> map = new HashMap<>();
java.awt.geom.Rectangle2D.Double shape = new java.awt.geom.Rectangle2D.Double(1, 1, 1, 1);
map.put(shape, null);
System.out.println(map.size()); //1
shape.setRect(2, 2, 2, 2); //mutate
System.out.println(map.size()); //still 1
map.keySet().remove(shape);
System.out.println(map.size()); //still 1

潜在的问题是Shape在地图中发生了变异。

Answer 2

这并不能解释为什么您的代码不起作用，但它会解决您的问题并使该方法更有效，因为没有分配临时集：

public void removeFromContainer(double x, double y) {
    final Point2D loc = new Point2D.Double(x, y);
    Iterator<Shape> iter = shapes.keySet().iterator();
    while (iter.hasNext()) {
        if (iter.next().contains(loc))
            iter.remove();
    }
}

编辑：我怀疑你在将它们添加到地图后修改了形状，因此检查containsKey时的哈希码与将形状添加到的时使用的哈希码不匹配地图。

java Map删除意外行为

2 个答案: