使用。fore在foreach循环中使用lambda表达式获取无效参数时出错

时间:2013-10-18 01:46:19

标签: c# linq lambda

我正忙于在VS2010(学院作业)中创建索引Windows窗体应用程序的文件/文件夹。出于测试目的,文件/文件夹索引类位于控制台应用程序中

我使用以下内容来浏览文件夹,它运行正常并写入文件指定驱动器中的所有文件夹名称。我主要是从msdn资源(使用递归方法)抛出这个,并修改,因为它不包括获取文件夹名称。

我想排除某些文件夹,并决定使用lambda表达式,List和单词列表将是最快的,虽然我可以放置一个循环,通过一个数组与if比较,但在我看来,这会要慢一些(不是我对c#中错综复杂的工作方式了解得太多)。我已经简要介绍了lambda表达式,看看我是否自己无法修复它。

这是我的代码在没有任何文件夹排除的情况下工作

class Program
{
    static System.Collections.Specialized.StringCollection log = new System.Collections.Specialized.StringCollection();
    private static List<string> _excludedDirectories = new List<string>() { "Windows", "AppData", "$WINDOWS.~BT", "MSOCache", "ProgramData", "Config.Msi", "$Recycle.Bin", "Recovery", "System Volume Information", "Documents and Settings", "Perflogs" };

    //method to check
    static bool isExcluded(List<string> exludedDirList, string target)
    {
        return exludedDirList.Any(d => new DirectoryInfo(target).Name.Equals(d));
    }

    static void Main()
    {

        string[] drives = {"C:\\"};

        foreach (string dr in drives)
        {
            DriveInfo di = new System.IO.DriveInfo(dr);

            // Here we skip the drive if it is not ready to be read. 
            if (di.IsReady)
            {
                DirectoryInfo rootDir = di.RootDirectory;
                WalkDirectoryTree(rootDir);
            }
            else
            {
                Console.WriteLine("The drive {0} could not be read", di.Name);
                continue;
            }
        }

        // Write out all the files that could not be processed.
        Console.WriteLine("Files with restricted access:");
        foreach (string s in log)
        {
            Console.WriteLine(s);
        }
        // Keep the console window open in debug mode.
        Console.WriteLine("Press any key");
        Console.ReadKey();
    }

    static void WalkDirectoryTree(System.IO.DirectoryInfo root)
    {
        FileInfo[] files = null;
        DirectoryInfo[] subDirs = null;
        StreamWriter filex = new System.IO.StreamWriter("test.txt", true);

        if (filex != null)
        {
            filex.Close();
        }

        // Process all the folders directly under the root 
        try
        {
            subDirs = root.GetDirectories();
        }// This is thrown if even one of the folders requires permissions greater than the application provides. 
        catch (UnauthorizedAccessException e)
        {
            log.Add(e.Message);
        }
        catch (System.IO.DirectoryNotFoundException e)
        {
            Console.WriteLine(e.Message);
        }
        catch (Exception e)
        {
            Console.WriteLine(e.Message);
        }

        // Process all the files directly under the root 
        try
        {
            files = root.GetFiles("*.*");
        }// This is thrown if even one of the files requires permissions greater than the application provides. 
        catch (UnauthorizedAccessException e)
        {
            log.Add(e.Message);
        }
        catch (System.IO.DirectoryNotFoundException e)
        {
            Console.WriteLine(e.Message);
        }
        catch(Exception e)
        {
            Console.WriteLine(e.Message);
        }

        if (files != null)
        {
            filex = new StreamWriter("test.txt", true);
            foreach (FileInfo fi in files)
            {
                // In this example, we only access the existing FileInfo object. If we 
                // want to open, delete or modify the file, then 
                // a try-catch block is required here to handle the case 
                // where the file has been deleted since the call to TraverseTree().
                Console.WriteLine(fi.FullName);
                filex.WriteLine(fi.FullName);
            }
            filex.Close();
        }

        if (subDirs != null)
        {
            //var filteredDirs = Directory.GetDirectories(root.Name).Where(d => !isExcluded(_excludedDirectories, d));
            foreach (DirectoryInfo subds in subDirs)
            {
                filex = new StreamWriter("test.txt", true);
                Console.WriteLine(subds.FullName);
                filex.WriteLine(subds.FullName);
                filex.Close();

                foreach (DirectoryInfo dirInfo in subDirs)
                {
                    // Resursive call for each subdirectory.
                    WalkDirectoryTree(dirInfo);
                }
            }
            filex.Close();// Because at end filestream needs to close
        }
    }
}

所以我尝试将.Where(d =&gt;!isExcluded(_excludedDirectories,d))合并到我的循环中:

if (subDirs != null)
        {
            //var filteredDirs = Directory.GetDirectories(root.Name).Where(d => !isExcluded(_excludedDirectories, d));
            foreach (DirectoryInfo subds in subDirs.Where(d => !isExcluded(_excludedDirectories, d)))
            {
                filex = new StreamWriter("test.txt", true);
                Console.WriteLine(subds.FullName);
                filex.WriteLine(subds.FullName);
                filex.Close();

                foreach (DirectoryInfo dirInfo in subDirs)
                {
                    // Resursive call for each subdirectory.
                    WalkDirectoryTree(dirInfo);
                }
            }
            filex.Close();// Because at end filestream needs to close
        }

问题:我从感叹号中得到一个错误,说“最好的重载方法匹配有一些无效的args ...”我应该做什么/改变,我应该采用更简单的路由并使用循环和if语句在我的写入文件夹名称的循环?因为我也明白该怎么做。并记住我目前正在做的方式(至少尝试)是因为我认为它会更优化/更快。如果它没有产生如此大的差异,请告诉我,我会按照我所知的方式使用。

我的猜测是,通过尝试在foreach中放置一个地方,我做了一件坏事,我意识到它为什么或可能是。

我也试过了:

if (subDirs != null)
        {
            //var filteredDirs = Directory.GetDirectories(root.Name).Where(d => !isExcluded(_excludedDirectories, d));
            foreach (DirectoryInfo subds in subDirs)
            {
              if ((d => !isExcluded(_excludedDirectories, d)))
              {
                filex = new StreamWriter("test.txt", true);
                Console.WriteLine(subds.FullName);
                filex.WriteLine(subds.FullName);
                filex.Close();

                foreach (DirectoryInfo dirInfo in subDirs)
                {
                    // Resursive call for each subdirectory.
                    WalkDirectoryTree(dirInfo);
                }
              } 

            }
            filex.Close();// Because at end filestream needs to close
        }

但是得到一个错误,无法将lamba表达式转换为bool类型,因为它不是委托

如果您想查看其他代码,请告诉我,然后我会添加它,只是看起来有点多。

2 个答案:

答案 0 :(得分:4)

d此处不是string,而是DirectoryInfo。更改isExcluded方法签名以正确处理d的类型。

您的签名是:

static bool isExcluded(List<string> exludedDirList, string target)

应该是:

static bool isExcluded(List<string> exludedDirList, DirectoryInfo target)

你的方法将最终成为:

//method to check
static bool isExcluded(List<string> exludedDirList, DirectoryInfo target)
{
    return exludedDirList.Any(d => target.Name.Equals(d));
}

答案 1 :(得分:3)

问题在于:

foreach (DirectoryInfo subds in subDirs.Where(d => !isExcluded(_excludedDirectories, d)))

subDirs属于DirectoryInfo类型,您的isExcluded将字符串作为第二个参数。

你想:

foreach (DirectoryInfo subds in subDirs.Where(d => !isExcluded(_excludedDirectories, d.Name)))