关闭for循环后结构中的值发生变化

时间:2013-05-16 11:34:24

标签: c for-loop struct

简短版本:为什么(compounds+k)->spectra->peaksfor循环迭代后发生变化(在~2500种化合物中有4种)?

长版本:我有一个功能可以检查我的所有数据(在结构色谱图中(chrom))并将type == 1的数据直接添加到新结构(compounds),如果剩余数据中的色谱图高度相似,并且将type == 2的1个条目求和/平均,则检查compounds的色谱图。当我最初使用我当时使用的数据集编写它时,这个程序工作得很好但是最近的数据我遇到了一个错误,其中追踪多少'值'的整数在某种程度上被重置为0在包含{{1结束。我希望在阅读我的代码后会更清楚一些(特别注意最后的2个打印件,以证明问题)。

for loop

我知道4种化合物给出了我之前解释过的奇怪行为,所以这里是输出中匹配的行:

chromatogram*
spectral_matcher(chromatogram* chrom, arguments* args) {
   int i, j, k = 0, l, m, size, counter = 0;
   float low_mass, high_mass, low_time, high_time;
   chromatogram* compounds;
   compounds = calloc(MAX_SPECTRA,sizeof(chromatogram));
   for (i = 0; i < chrom->hits-1; i++) {
       if ( (chrom+i)->type == 1) {
           /* Adding the MS1 spectrum to output set */
           chrom_copy(chrom, compounds, i, k);
           k++;
       } else if ((chrom+i)->used != 1 && (chrom+i)->type == 2) {
           /* Adding the MSn spectrum to output set */
           chrom_copy(chrom, compounds, i, k);
           /* Acquiring search paramenters */
           low_mass = (chrom+i)->precursor - args->mass_tolerance;
           high_mass = (chrom+i)->precursor + args->mass_tolerance;
           low_time = (chrom+i)->time - args->time_tolerance;
           high_time = (chrom+i)->time + args->time_tolerance;
           /* Performing search for matching spectra */
           for (j = i+1; j < chrom->hits; j++) {
               if ( (chrom+j)->type == 2 && (chrom+j)->precursor > low_mass && (chrom+j)->precursor < high_mass && (chrom+j)->time > low_time && (chrom+j)->time < high_time && (chrom+i)->spectra->peaks > 10 && (chrom+j)->spectra->peaks > 10 && (chrom+j)->used != 1) {
                   /* the KS test can only be performed if the previous if statement was true */
                   if (pdf_ks((chrom+i)->pdf,(chrom+j)->pdf, 1.0) == 1) {
                       if (args->verbose == 1) {
                           printf("Matching spectrum %i with %i into %i\n",i, j, k);
                       }
                       // De magicks - Photo Finish
                       counter++;
                       l = (compounds+k)->spectra->peaks;
                       size = (compounds+k)->spectra->peaks + (chrom+j)->spectra->peaks;
                       (compounds+k)->spectra->peaks = size;
                       m = 0;
                       /* `l` is at the end of original spectra, append values starting from `l` */
                       for (; l < size; l++) {
                           ((compounds+k)->spectra+l)->mz_value = ((chrom+j)->spectra+m)->mz_value;
                           ((compounds+k)->spectra+l)->int_value = ((chrom+j)->spectra+m)->int_value;
                           m++;
                       }
                       // set the 'matched' spectrum to NULL so there will be no duplicates
                       (chrom+j)->used = 1;
                   }
               }
           }
           k++;
       }
       /* k was incremented in either the if or else if so doing -1 here */
       printf("%i: values [ %i ] contains a value set [ %f - %f ]\n", k-1, (compounds+k-1)->spectra->peaks, ((compounds+k-1)->spectra+5000)->mz_value,((compounds+k-1)->spectra+5000)->int_value);
   }
   printf("BREAKPOINT\n");
   printf("%i spectra summed\n",counter);
   compounds->hits = k;
   for (i = 0; i < compounds->hits; i++) {
       printf("%i: values [ %i ] contains a value set [ %f - %f ]\n", i, (compounds+i)->spectra->peaks, ((compounds+i)->spectra+5000)->mz_value,((compounds+i)->spectra+5000)->int_value);
   }
   exit(0);
   return(compounds);
}

根据结果,数组中的值似乎也会发生变化。

然而,4种奇特的值仍然是正确的:

736: values [ 16481 ] contains a value set [ 765.000000 - 0.000000 ]
847: values [ 16481 ] contains a value set [ 765.000000 - 5843.000000 ]
1810: values [ 16481 ] contains a value set [ 765.000000 - 0.000000 ]
2212: values [ 16481 ] contains a value set [ 765.000000 - 0.000000 ]
BREAKPOINT
736: values [ 0 ] contains a value set [ 765.000000 - 905.625000 ]
847: values [ 0 ] contains a value set [ 765.000000 - 905.625000 ]
1810: values [ 0 ] contains a value set [ 765.000000 - 905.625000 ]
2212: values [ 0 ] contains a value set [ 765.000000 - 905.625000 ]

如果有人对接下来要检查的内容有任何点击或提示,我将非常感激。

- 5月16日(4:20) -

我尝试通过在代码中添加735: values [ 44801 ] contains a value set [ 556.250000 - 0.000000 ] 736: values [ 16481 ] contains a value set [ 765.000000 - 0.000000 ] 737: values [ 131848 ] contains a value set [ 765.000000 - 0.000000 ] BREAKPOINT 735: values [ 44801 ] contains a value set [ 556.250000 - 0.000000 ] 736: values [ 0 ] contains a value set [ 765.000000 - 905.625000 ] 737: values [ 131848 ] contains a value set [ 765.000000 - 0.000000 ] 来手动打破特定i值的for循环来查看数据更改的位置。这产生了:

if (i == 806) { break; }

- 5月17日 -

我还检查了i和k计数器是否做了一些奇怪的事情,但它们似乎完全正常(在for循环中):

736: values [ 16481 ] contains a value set [ 765.000000 - 0.000000 ]
BREAKPOINT
736: values [ 0 ] contains a value set [ 765.000000 - 905.625000 ]

3 个答案:

答案 0 :(得分:2)

看看这个:

chromatogram* compounds;
compounds = calloc(MAX_SPECTRA,sizeof(compound));

你的意思是sizeof(chromatogram)吗?或compound *compounds

答案 1 :(得分:0)

是否可以更改(compounds+k)->spectra->peaks的价值?

size = (compounds+k)->spectra->peaks + (chrom+j)->spectra->peaks;
(compounds+k)->spectra->peaks = size;

size变量是int,可能与您的问题有关。

答案 2 :(得分:0)

我超出了分配给光谱的空间(在照片完成评论的部分中),我本来期望valgrind给出写过去缓冲区的消息,但我得到的错误后来没有无效指针。

通过增加MAX_PEAKS

的值来解决问题