Rspec测试失败了

时间:2013-04-23 19:19:03

标签: ruby-on-rails rspec tdd railstutorial.org

所以我在这里看到的几个问题与我的有些相似,但不够接近,无法帮我弄清楚我的问题是什么......所以对我做错的任何帮助都会受到赞赏:(我我正在关注Michael Hartl的教程,所以关于我如何偏离他的例子的信息会特别有用)... thx

I'm throwing the following 2 errors:

Failures:

  1) Authentication authorization as wrong user submitting a PUT request to the Users#update action 
 Failure/Error: before { put user_path(wrong_user) }
 NoMethodError:
   undefined method `put' for #<RSpec::Core::ExampleGroup::Nested_1::Nested_3::Nested_2::Nested_2:0x007f8943728688>
 # ./spec/features/authentication_pages_spec.rb:78:in `block (5 levels) in <top (required)>'

2) Authentication authorization for non-signed-in users in the Users controller submitting  to the update action 
 Failure/Error: before { put user_path(user) }
 NoMethodError:
   undefined method `put' for #<RSpec::Core::ExampleGroup::Nested_1::Nested_3::Nested_1::Nested_1::Nested_2:0x007f8944a85ff0>
 # ./spec/features/authentication_pages_spec.rb:61:in `block (6 levels) in <top (required)>'

Finished in 3.06 seconds
56 examples, 2 failures

Failed examples:

rspec ./spec/features/authentication_pages_spec.rb:79 # Authentication authorization as     wrong user submitting a PUT request to the Users#update action 
rspec ./spec/features/authentication_pages_spec.rb:62 # Authentication authorization for non- signed-in users in the Users controller submitting to the update action 

我的代码如下:

规格/特征/ authentication_pages_spec.rb

require 'spec_helper'

describe "Authentication" do

  subject { page }

  # FOR STATIC SIGN IN PAGE
  describe "signin page" do
    before { visit signin_path }

    it { should have_selector('h1',    text: 'Sign in') }
    it { should have_title('Sign in') }
  end

  # FOR SIGNIN PROCESS
  describe "signin" do
    before { visit signin_path }

    describe "with invalid information" do
      before { click_button "Sign in" }

      it { should have_title('Sign in') }
      it { should have_error_message }

      describe "after visiting another page" do
        before { click_link "Home" }
        it { should_not have_error_message }
      end
    end

    describe "with valid information" do
      let(:user) { FactoryGirl.create(:user) }
      before { sign_in user }

      it { should have_title(user.name) }
      it { should have_link('Profile',     href: user_path(user)) }
      it { should have_link('Sign out',    href: signout_path) }
      it { should have_link('Settings',    href: edit_user_path(user)) }
      it { should_not have_link('Sign in', href: signin_path) }

      describe "followed by signout" do
        before { click_link "Sign out" }
        it { should have_link('Sign in') }
      end
    end
  end

  # FOR AUTHORIZING WHICH ACCOUNTS CAN DO WHAT
  describe "authorization" do

    describe "for non-signed-in users" do
      let(:user) { FactoryGirl.create(:user) }

      describe "in the Users controller" do
        describe "visiting the edit page" do
          before { visit edit_user_path(user) }
          it { should have_title('Sign in') }
        end

        describe "submitting to the update action" do
          before { put user_path(user) }
          specify { response.should redirect_to(signin_path) }
        end
      end
    end

    describe "as wrong user" do
      let(:user) { FactoryGirl.create(:user) }
      let(:wrong_user) { FactoryGirl.create(:user, email: "wrong@example.com") }
      before { sign_in user }

      describe "visiting Users#edit page" do
        before { visit edit_user_path(wrong_user) }
        it { should_not have_selector('title', text: full_title('Edit user')) }
      end

      describe "submitting a PUT request to the Users#update action" do
        before { put user_path(wrong_user) }
        specify { response.should redirect_to(root_path) }
      end
    end

  end
end

我的规格/功能/ user_pages_spec.rb

require 'spec_helper'

describe "User pages" do

  subject { page }

  # TESTING STATIC PROFILE PAGE
  describe "profile page" do
    let(:user) { FactoryGirl.create(:user) } # Code to make a user variable
    before { visit user_path(user) }

    it { should have_selector('h1',    text: user.name) }
    it { should have_title(user.name) }
  end

  # TESTING STATIC SIGNUP PAGE
  describe "signup page" do
    before { visit signup_path }

    it { should have_selector('h1',    text: 'Sign up') }
    it { should have_title("Sign up") }
  end

  # TESTING SIGN UP PROCESS
  describe "signup" do
    before { visit signup_path }

    let(:submit) { "Create my account" }

    describe "with invalid information" do
      it "should not create a user" do
        expect { click_button submit }.not_to change(User, :count)
      end

      describe "after submission" do
        before { click_button submit }

        it { should have_title('Sign up') }
        it { should have_content('error') }
      end
    end

    describe "with valid information" do
      before do
        fill_in "Name",         with: "Example User"
        fill_in "Email",        with: "user@example.com"
        fill_in "Password",     with: "foobar"
        fill_in "Confirmation", with: "foobar"
      end

      it "should create a user" do
        expect { click_button submit }.to change(User, :count).by(1)
      end

      describe "after saving the user" do
        before { click_button submit }
        let(:user) { User.find_by_email('user@example.com') }

        it { should have_title(user.name) }
        it { should have_selector('div.alert.alert-success', text: 'Welcome') }
        it { should have_link('Sign out') }
      end

    end
  end

  # TESTING EDITING FUNCTIONALITY
  describe "edit" do
    let(:user) { FactoryGirl.create(:user) }
    before do 
      sign_in user
      visit edit_user_path(user)
    end

    describe "page" do
      it { should have_selector('h1',    text: "Update your profile") }
      it { should have_title("Edit user") }
      # it { should have_link('change', href: 'http://gravatar.com/emails') }
      # needed if using gravatar
    end

    describe "with invalid information" do
      before { click_button "Save changes" }

      it { should have_content('error') }
    end

    describe "with valid information" do
      let(:new_name)  { "New Name" }
      let(:new_email) { "new@example.com" }
      before do
        fill_in "Name",             with: new_name
        fill_in "Email",            with: new_email
        fill_in "Password",         with: user.password
        fill_in "Confirm Password", with: user.password
        click_button "Save changes"
      end

      it { should have_title(new_name) }
      it { should have_selector('div.alert.alert-success') }
      it { should have_link('Sign out', href: signout_path) }
      specify { user.reload.name.should  == new_name }
      specify { user.reload.email.should == new_email }
    end

  end

end

我的规范/ support / utilities.rb

include ApplicationHelper

RSpec::Matchers.define :have_error_message do |message|
  match do |page|
    page.has_selector?('div.alert.alert-error', text: 'Invalid')
  end
end

def sign_in(user)
  visit signin_path
  fill_in "Email",    with: user.email
  fill_in "Password", with: user.password
  click_button "Sign in"
  # Sign in when not using Capybara.
  # cookies[:remember_token] = user.remember_token
end

我的controllers / users_controller.rb

class UsersController < ApplicationController
  before_filter :signed_in_user, only: [:edit, :update]


  def new
    @user = User.new
  end

  def show
     @user = User.find(params[:id])
  end

  def create
    @user = User.new(params[:user])
    if @user.save
      sign_in @user
      flash[:success] = "Welcome to Authentication App..."
      redirect_to @user
    else
      render 'new'
    end
  end

  def edit
    @user = User.find(params[:id])
  end

  def update
    @user = User.find(params[:id])
    if @user.update_attributes(params[:user])
      sign_in @user
      flash[:success] = "Profile updated"
      redirect_to @user
    else
      render 'edit'
    end
  end

  def destroy
    User.find(params[:id]).destroy
    flash[:success] = "User destroyed"
    redirect_to users_path
  end

  private

    def signed_in_user
      redirect_to signin_url, notice: "Please sign in." unless signed_in?
    end

end

&安培;最后我的观点/ users / edit.html.erb

<% provide(:title, "Edit user") %> 
<h1>Update your profile</h1>

<div class="row">
  <div class="span6 offset3">
    <%= form_for(@user) do |f| %>
      <%= render 'shared/error_messages' %>

      <%= f.label :name %>
      <%= f.text_field :name %>

      <%= f.label :email %>
      <%= f.text_field :email %>

      <%= f.label :password %>
      <%= f.password_field :password %>

      <%= f.label :password_confirmation, "Confirm Password" %>
      <%= f.password_field :password_confirmation %>

      <%= f.submit "Save changes", class: "btn btn-large btn-primary" %>
    <% end %>

  </div>
</div>

非常感谢任何有关正确修复的帮助。感谢,

3 个答案:

答案 0 :(得分:1)

put, get, post, delete和用于控制器测试的那些方法在功能测试中不可用。

您应该通过按钮操作/ ajax / etc等“提交”put,而不是在编写功能测试时将其作为控制器测试发布到控制器。

答案 1 :(得分:1)

问题是:您通过功能测试弄乱请求(capybara)测试

capybara中,您应该描述用户步骤

require 'spec_helper'

describe "Website access" do
  context "when I am a registered user" do
    it "should let me in" do
      page.fill_in 'Email',    with: 'vader@deathstar.com'
      page.fill_in 'Password', with: 'mydearluke'
      page.click_link 'Let me in'

      page.should have_content('Welcome, cheif!')
    end
  end

  context "when I am not a registered user" do
    it "should not let me in" do
      page.fill_in 'Email',    with: 'jabba.h@tatooine.com'
      page.fill_in 'Password', with: 'wormsarmageddon'
      page.click_link 'Let me in'

      page.should have_content('Incorrect credentials!')
    end
  end      
end

功能测试在较低级别运行,因为您需要使用HTTP动词作为putgetpostdelete与您正在使用的应用程序进行通信测试

require 'spec_helper'

describe SessionsController do
  context "when I am registered user" do
    it "should let me in" do
      post :create, email: 'vader@deathstar.com', password: 'mydearluke'

      response.should be_success
    end
  end

  context "when I am not a registered user" do
    it "should not let me in" do
      post :create, email: 'jabba.h@tatooine.com', password: 'wormsarmageddon'

      response.should_not be_success
    end
  end      
end

这里有一些注意事项:

  1. 我正在使用post,而不是put
  2. 我在describe块中指定了控制器名称,而不像像水豚测试那样简单的英语解释。
  3. 功能测试指定SessionController应该如何响应不同的用户凭据(它应该为好用户创建会话,并在未注册的用户上回显)。
  4. 您要做的是在请求(capybara)测试中使用来自功能测试的动词。这是错误的。

    回顾:

    1. visit测试中使用click_linkclick_button / capybara
    2. 在功能测试中使用HTTP动词(putgetpostdelete
    3. 使用devise gem进行用户身份验证。

答案 2 :(得分:0)

如果您正在关注Rails教程,则需要将Capybara版本降级到1.1.2并将规范移至spec/requests目录。更新您的Gemfile:

gem 'capybara', '1.1.2'

如果您计划使用Capybara 2.0,我建议您阅读:

http://alindeman.github.io/2012/11/11/rspec-rails-and-capybara-2.0-what-you-need-to-know.html