Question

此代码用于分配。但是，在计算pi pi monte carlo函数中有一个错误。错误统计信息无效，从int转换为unsigned int。我不确定这是否有意，但我无法纠正这个问题。如果您想知道，此函数是线程示例的一部分。任何建议都非常感谢

void *compute_pi( void *s )   
{
int seed;
int ii;
int *hit_pointer;
int local_hits;
double rand_no_x;
double rand_no_y;

hit_pointer = (int *) s;
seed = *hit_pointer;
local_hits = 0;

for( ii=0; ii < sample_points_per_thread; ii++ )
{
  rand_no_x = (double) (rand_r( &seed ))/(double)RAND_MAX;//*error is these lines
  rand_no_y = (double) (rand_r( &seed ))/(double)RAND_MAX;//*error is these lines
  if(((rand_no_x - 0.5) * (rand_no_x - 0.5) +
  (rand_no_y - 0.5) * (rand_no_y - 0.5)) < 0.25)//*error 
local_hits++;
  seed *= ii;
 }

*hit_pointer = local_hits;
 pthread_exit(0); 
 }

我做了一些调试，现在看看错误的位置。生病后现在调用计算pi的主要功能。我相信它是将参数解析为样本点和线程数的地方。当我运行程序时，它要求输入后它失败并出现分段故障。有什么建议吗？

  #include <pthread.h>
  #include <stdlib.h>
  #include <stdio.h>

  #define MAX_THREADS 512

  void *compute_pi( void * );


  int sample_points;
  int total_hits;
  int total_misses;
  int hits[ MAX_THREADS ];
  int sample_points_per_thread;
  int num_threads;



  int main( int argc, char *argv[] )
  {
  /* local variables */
  int ii;
  int retval;
  pthread_t p_threads[MAX_THREADS];
  pthread_attr_t attr;
  double computed_pi;

  /* initialize local variables */
  retval = 0;


  pthread_attr_init( &attr );
  pthread_attr_setscope( &attr, PTHREAD_SCOPE_SYSTEM );

  printf( "Enter number of sample points: " );
  scanf( "%d", &sample_points );
  printf( "Enter number of threads: " );
  scanf( "%d%", &num_threads );

  /* parse command line arguments into sample points and number of threads */
  /* there is no error checking here!!!!! */
  sample_points = atoi(argv[1]);
  num_threads = atoi(argv[2]);


  total_hits = 0;
  sample_points_per_thread = sample_points / num_threads;

  for( ii=0; ii<num_threads; ii++ )
  {
  hits[ii] = ii;
  pthread_create( &p_threads[ ii ], &attr, compute_pi, (void *) &hits[ii] );
  }

  for( ii=0; ii<num_threads; ii++ )
  {
   pthread_join( p_threads[ ii ], NULL );
   total_hits += hits[ ii ];
    }

   computed_pi = 4.0 * (double) total_hits / ((double) (sample_points));


   printf( "Computed PI = %lf\n", computed_pi );


   /* return to calling environment */
   return( retval );
   }

Answer 1

来自rand_r(3) man page：

int
rand_r(unsigned *ctx);

正如您所看到的，它需要一个unsigned指针 - 如果您传递int并且您在编译器中打开了相应的警告/错误（似乎您已经这样做了），会得到那个错误。更改seed的类型，您将被设置。

int转换为unsigned int无效

1 个答案: