清理TCL清单&产量

时间:2012-12-14 05:10:01

标签: coding-style tcl code-cleanup

您好我正在处理一个允许我从输入中解析信息的小脚本。这是有效的,但我知道有更好的方法来做到这一点。拜托,我正在努力学习[自学成才]所以撕毁我。输入内容如下:

C7-0-4-U1   36.5 mHz    IN7-0-4-0   567 mHz 00:15:d0:e3:b0:41   online(pt)  10.106.156.129  42.0    -0.5    35.1    -3.0    38.7    0.0E+000    0.0E+000    9   0    12:20:32 AM    rZ5 1       


C7-0-4-U1   36.5 mHz    IN7-0-4-0   567 mHz 2c:9e:5f:de:ed:36   w-online(pt)    10.113.52.11    36.5    0.0 35.1    -5.0    37.7    4.9E-006    0.0E+000    9   0    12:20:32 AM    r4G 0       


C7-0-4-U1   36.5 mHz    IN7-0-4-0   567 mHz e4:83:99:6d:57:ad   w-online(pt)    10.113.45.239   43.5    0.0 35.1    -4.6    39.5    5.8E-006    0.0E+000    8   0    12:20:34 AM    r4G 0       


C7-0-4-U1   36.5 mHz    IN7-0-4-0   567 mHz 3c:75:4a:9c:7b:92   w-online(pt)    10.109.238.61   42.2    -0.5    33.9    -14.4   34.6    4.9E-006    0.0E+000    199 4    12:20:33 AM    rC2 0       

期望输出如下:

00:15:D0:E3:B0:41 10.106.156.129
2C:9E:5F:DE:ED:36 10.113.52.11
E4:83:99:6D:57:AD 10.113.45.239
3C:75:4A:9C:7B:92 10.109.238.61

我所拥有的守则如下:

#GET INPUT FROM CLIPBOARD
set Input [sh_set clipboard]
#REMOVE ALL EXCESSIVE WHITESPACE
regsub -all {\s{3,}} $Input "\n" CleanInput
#SET THE INPUT AS LIST
set List [split $CleanInput "\n"]
#GET LIST ITEMS
set Cust1 [lindex $List 1]
set Cust2 [lindex $List 2]
set Cust3 [lindex $List 3]
set Cust4 [lindex $List 4]
regexp -all {(?:[[:xdigit:]]{2}([.-:]))(?:[[:xdigit:]]{2}\1){4}[[:xdigit:]]{2}} $Cust1 C1MacAddress
regexp -all {10\.(?:(?:25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\.){2}(?:25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)} $Cust1 C1IpAddress
regexp -all {(?:[[:xdigit:]]{2}([.-:]))(?:[[:xdigit:]]{2}\1){4}[[:xdigit:]]{2}} $Cust2 C2MacAddress
regexp -all {10\.(?:(?:25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\.){2}(?:25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)} $Cust2 C2IpAddress
regexp -all {(?:[[:xdigit:]]{2}([.-:]))(?:[[:xdigit:]]{2}\1){4}[[:xdigit:]]{2}} $Cust3 C3MacAddress
regexp -all {10\.(?:(?:25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\.){2}(?:25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)} $Cust3 C3IpAddress
regexp -all {(?:[[:xdigit:]]{2}([.-:]))(?:[[:xdigit:]]{2}\1){4}[[:xdigit:]]{2}} $Cust4 C4MacAddress
regexp -all {10\.(?:(?:25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\.){2}(?:25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)} $Cust4 C4IpAddress
return "$C1MacAddress\t$C1IpAddress\n$C2MacAddress\t$C2IpAddress\n$C3MacAddress\t$C3IpAddress\n$C4MacAddress\t$C4IpAddress"

2 个答案:

答案 0 :(得分:2)

这是我的解决方案:

# read entire file
set fid [open file.txt r]
set txt [read $fid]
close $fid

# split into lines
set lines0 [split $txt \n]

# take only non-empty lines
set lines {}
foreach line $lines0 {
    if {[string trim $line] ne ""} {
        lappend lines $line
    }
}

# extract the required data from each line
foreach line $lines {
    set data [regexp -inline {(\w{2}:\w{2}:\w{2}:\w{2}:\w{2}:\w{2})\s+\S+\s+ (\d+.\d+.\d+.\d+)} $line]
    foreach {dummy x y} $data {
        puts "$x\t$y"
    }
}

我使用正则表达式搜索由冒号分隔的六个2-chars单词的模式,然后是一个空格后跟一个单词后跟一个空格(\ s + \ S + \ s +)然后是ip的模式 地址。

regexp返回一个trios列表(它是flat,而不是列表列表),其中每个trio由整个匹配组成,然后是第一个parnthesis匹配,然后是scond one。因此虚拟变量。

或者,您可以使用正则表达式,因为每行具有相同数量的单词。因为在tcl中你可以将字符串视为alist,其项目由空格分隔,你可以更简单地通过以下方式提取数据:

foreach line $lines {
    set x [lindex $line 6]
    set y [lindex $line 8]
    puts "$x\t$y"
}

答案 1 :(得分:0)

好吧,假设我们从txt文件加载它,那就是我要做的:

set input [open "file.txt" r]
set output [open "output.txt" w]
set count 1

while {[gets $input line] != -1} {
    if {$line == ""} {continue} #Skip empty lines
    regexp -all {(\w{2}:\w{2}:\w{2}:\w{2}:\w{2}:\w{2})} $line - MacAddress #trap the mac address and store into $MacAddress
    regexp -all {(\d+\.\d+\.\d+\.\d+)} $line - IpAddress #trap the IP address and store into $IpAddress
    puts $output "Customer $count: $MacAddress $IpAddress"
    incr count
}

close $input
close $output

如果你能说哪个顾客是哪个^^,我认为这可能很奇特。如果您不需要额外的功能,可以删除零件'客户$ count'以及任何涉及'$ count'的行。

或者如果输入数据是表格形式(意味着您需要的信息在同一列中,我会选择:

set input [open "file.txt" r]
set output [open "output.txt" w]
set count 1

while {[gets $input line] != -1} {
    if {$line == ""} {continue} #Skip empty lines
    regsub -all { +} $line " " newline #trims excess spaces
    set MacAddress [lindex [split $line " "] 6]
    set MIpAddress [lindex [split $line " "] 8]
    puts $output "Customer $count: $MacAddress $IpAddress"
    incr count
}

close $input
close $output