我的代码中的一个条件无效。这种情况是第一个文件变为4行而第二个文件变为5行。两个文件的前4行是相同的,但第二个文件的第5行可能不同或相同。我的输出必须显示“是的,在第5行有不同的”,但它说这些文件是相同的。我该如何修复此代码?
第一个文件:
one
two
three
four
第二档:
one
two
three
four
five
我的代码:
void diff(char* fileptr1, char* fileptr2)
{
int maxlinelen=BUFF; //maximum line length buffer size
/** string arrays pointers **/
char *linebuffer1;
char *linebuffer2;
/** file pointers **/
FILE *fp1;
FILE *fp2;
int line=0; //line counter
int counter=0; //identical flag
linebuffer1=(char*)malloc(maxlinelen * sizeof(char*)); //memory allocation for linebuffers
linebuffer2=(char*)malloc(maxlinelen * sizeof(char*));
if((linebuffer1==NULL) || (linebuffer2==NULL)) //check memory allocating process
{
fprintf(stderr,"Command:diff :Memory allocating failed!\n");
exit(1);
}
if(((fp1=fopen(fileptr1,"r"))!=NULL)&&((fp2=fopen(fileptr2,"r"))!=NULL)) //make sure both files open?
{
//read both files lines till end of line
while(((fgets(linebuffer1,maxlinelen,fp1))!=NULL)&&((fgets(linebuffer2,maxlinelen,fp2))!=NULL))
{
while(strlen(linebuffer1)==maxlinelen-1) // perfect time for memory reallocating
{
maxlinelen*=DOUBLE; //grow size
linebuffer1=realloc(linebuffer1,maxlinelen * sizeof(char)); //reallocate memory to new size
if(linebuffer1==NULL) //make sure allocation is succesfull
{
fprintf(stderr,"Command : diff :Memory reallocating failed for linebuffer1\n");
exit(1);
}
fgets(linebuffer1+(maxlinelen/DIV-1),(maxlinelen/DIV)+1,fp1); //continue read line after reallocation
}
while(strlen(linebuffer2)==maxlinelen-1)
{
maxlinelen*=DOUBLE;
linebuffer2=realloc(linebuffer2,maxlinelen * sizeof(char));
if(linebuffer2==NULL)
{
fprintf(stderr,"Memory reallocating failed for linebuffer2\n");
exit(2);
}
fgets(linebuffer2+(maxlinelen/DIV-1),(maxlinelen/DIV)+1,fp2); //
}
line++; //increae line counter
if(strcmp(linebuffer1,linebuffer2)!=0) //compare both line string arrays if not
{
printf("The files are different.The first difference is in line %d\n",line); //diff. here
exit(1);
}
if(strcmp(linebuffer1,linebuffer2)==0) //compare both line string arrays if same
{
counter++; //increase identical counter
}
}
if(counter==line) //if identical counter equal total line
{
printf("The files are identical.\n");
}
}
else {
fprintf(stderr,"Command: diff :File open failed!\n");
}
//fclose(fp1);fclose(fp2);
}
答案 0 :(得分:0)
在这里,你正在使用“&&”为两个文件的fgets结果。 因此,当任一文件达到EOF时,比较结束。
你的第5行永远不会被比较。
while(((fgets(linebuffer1,maxlinelen,fp1))!=NULL)&&((fgets(linebuffer2,maxlinelen,fp2))!=NULL)
更改此while循环条件并修改相对逻辑将帮助您更正代码。
答案 1 :(得分:0)
我相信当文件结束时,读取文件循环的退出比较失败。这导致您不读取文件中的最后一行,从而增加行计数器变量。
您需要帮助变量来记录每行的fgets结果。