SQL查询和强制关闭挑战

时间:2012-08-11 05:21:52

标签: android nullpointerexception android-sqlite

在这里,如果用户已经有帐户,我会尝试从数据库中获取名称和密码,或者通过输入他的数据来注册他。

这是第一个通过单击第一个按钮登录数据库来强制关闭的活动

public class SelesMeter2Activity extends Activity implements OnClickListener {
    EditText ed1;
    EditText ed2;
    Button b1;
    Button b2;
    SQLiteDatabase sql;
    Cursor c;
    Intent in;

    /** Called when the activity is first created. */
    @Override
    public void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.main);
        ed1 = (EditText) findViewById(R.id.ed1);
        ed2 = (EditText) findViewById(R.id.ed2);
        b1 = (Button) findViewById(R.id.bt1);
        b2 = (Button) findViewById(R.id.bt2);
        b1.setOnClickListener(this);
        b2.setOnClickListener(this);
        sql = openOrCreateDatabase("db", 0, null);
        sql.execSQL("CREATE TABLE if not exists "
                + "Employee2 (password integer NOT NULL PRIMARY KEY,name text NOT NULL)");
    }

    @Override
    public void onClick(View arg0) {
        // log in
        if (arg0.getId() == R.id.bt1) {
            int p = 0;
            String name = ed1.getText().toString();
            String sp = ed2.getText().toString();
            try {
                // Attempt to parse the number as an integer
                p = Integer.parseInt(sp);
            } catch (NumberFormatException nfe) {
                // parseInt failed, so tell the user it's not a number
                Toast.makeText(this,
                        "Sorry, " + sp + " is not a number. Please try again.",
                        Toast.LENGTH_LONG).show();
            }
            if (c.getCount() != 0) {
                c = sql.rawQuery("select * from Employee", null);
                while (c.moveToNext()) {
                    if (name.equals("c.getString(1)") && p == c.getInt(0)) {
                        in = new Intent(this, secondview.class);
                        startActivity(in);
                        break;
                    }
                }
            }

            else {
                Toast.makeText(this,
                        "please sign up first or enter " + "correct data", 2000)
                        .show();
            }

        } else if (arg0.getId() == R.id.bt2) {
            // sign up
            Intent in2 = new Intent(this, signup.class);

            startActivity(in2);

        }
    }
}

进入新用户但未按预期工作的第二个类, 吐司不起作用:

public class signup extends Activity implements OnClickListener {
    EditText e1;
    EditText e2;
    SQLiteDatabase sql;
    Button b;

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        // TODO Auto-generated method stub
        super.onCreate(savedInstanceState);
        setContentView(R.layout.singupx);
        Intent in = getIntent();
        e1 = (EditText) findViewById(R.id.ed1s);
        e2 = (EditText) findViewById(R.id.ed2s);
        b = (Button) findViewById(R.id.bt1s);
        b.setOnClickListener(this);
    }

    @Override
    public void onClick(View v) {
        String n = e1.getText().toString();
        String sp = e2.getText().toString();
        try {
            // Attempt to parse the number as an integer
            int p = Integer.parseInt(sp);
            // This insertion will *only* execute if the parseInt was successful
            // sql.execSQL("insert into Employee2(password,name)values('"+n+"',"+p+")");
            ContentValues values = new ContentValues();
            values.put("password", p);
            values.put("name", n);
            sql.insert("Employee2", null, values);
            Toast.makeText(this, "Data inserted", Toast.LENGTH_LONG).show();
            Intent in2 = new Intent(this, secondview.class);
            startActivity(in2);
        } catch (NumberFormatException nfe) {
            // parseInt failed, so tell the user it's not a number
            Toast.makeText(this,
                    "Sorry, " + sp + " is not a number. Please try again.",
                    Toast.LENGTH_LONG).show();
        }
    }
}

2 个答案:

答案 0 :(得分:0)

这就是你收到错误的原因

// you are calling the `c.getCount();` before you are assigning
// It will throw null pointer exception
if (c.getCount() != 0) {
    c = sql.rawQuery("select * from Employee", null);
    while (c.moveToNext()) {
        if (name.equals(c.getString(1)) && p == c.getInt(0)) {
            in = new Intent(this, secondview.class);
            startActivity(in);
            break;
        }
    }
}

改变逻辑,如

c = sql.rawQuery("select * from Employee", null);
c.moveToFirst();
if(!c.isAfterLast()) {
    do {
        if (name.equals(c.getString(1)) && p == c.getInt(0)) {
            in = new Intent(this, secondview.class);
            startActivity(in);
            break;
        }
    } while (c.moveToNext());
}

name.equals("c.getString(1)")应为name.equals(c.getString(1))

修改

插入方法示例

ContentValues values = new ContentValues();
values.put("password", n);
values.put("name", p);
database.insert("Employee2", null, values);

答案 1 :(得分:0)

SelesMeter2Activity中,您会在NullPointerException行:

if (c.getCount() != 0) {

因为你没有在该行之前初始化Cursor。在上一行之前移动查询:

c = sql.rawQuery("select * from Employee", null);
if (c.getCount() != 0) {
     // ...

您应该发布从logcat获得的异常。

另外,对于您的signup活动,请不要实例化第一个活动来访问其中的字段。在second活动中再次打开数据库并插入值。