我的程序分析大量文档,偶尔会得到一个导致无限或很长循环的页面。这是不可预先分析的。我想杀死特定页面并继续下一个页面(丢弃任何违规页面的结果)。我已阅读SO答案such as this How to stop execution after a certain time in Java?,并编写了以下代码:
// main program
private void runThread() throws InterruptedException {
long timeout = 15000L;
RunPageAnalyzer runPageAnalyzer = new RunPageAnalyzer(this);
Thread t = new Thread(runPageAnalyzer);
long startTime = System.currentTimeMillis();
t.start();
while (t.isAlive()) {
t.join(1000);
long delta = System.currentTimeMillis() - startTime;
LOG.debug("delta: "+delta);
if (delta > timeout && t.isAlive()) {
t.interrupt();
t.join;
break;
}
}
}
线程调用的同一类中的方法
void runActions() {
// variable length calculation which should be abandoned if too long
}
和Runnable:
class RunPageAnalyzer implements Runnable {
private PageAnalyzerAction pageAnalyzerAction;
public RunPageAnalyzer(PageAnalyzerAction pageAnalyzerAction) {
this.pageAnalyzerAction = pageAnalyzerAction;
}
public void run() {
try {
pageAnalyzerAction.runActions();
} catch (Exception e) {
LOG.debug("Exception running thread ", e);
}
}
runActions()正常终止的输出似乎没问题:
=========== page 1 =============
13863 [main] DEBUG org.xmlcml.graphics.control.page.PageAnalyzerAction - pageActions: 24 on page 0
14863 [main] DEBUG org.xmlcml.graphics.control.page.PageAnalyzerAction - delta: 1000
15864 [main] DEBUG org.xmlcml.graphics.control.page.PageAnalyzerAction - delta: 2001
16864 [main] DEBUG org.xmlcml.graphics.control.page.PageAnalyzerAction - delta: 3001
16975 [main] DEBUG org.xmlcml.graphics.control.page.PageAnalyzerAction - delta: 3112
16975 [main] DEBUG org.xmlcml.graphics.control.page.PageAnalyzerAction - finished page
但是当超出时间限制时,该过程会在t.join()
中挂起。
=========== page 2 =============
16975 [main] DEBUG org.xmlcml.graphics.control.page.PageAnalyzerAction - pageActions: 24 on page 0
17976 [main] DEBUG org.xmlcml.graphics.control.page.PageAnalyzerAction - delta: 1001
18976 [main] DEBUG org.xmlcml.graphics.control.page.PageAnalyzerAction - delta: 2001
// ...
30976 [main] DEBUG org.xmlcml.graphics.control.page.PageAnalyzerAction - delta: 14001
31976 [main] DEBUG org.xmlcml.graphics.control.page.PageAnalyzerAction - delta: 15001
如果我省略了t.join()
,那么这个过程的行为就像我期望的那样,但我担心这可能只会构建大量的线程,以后会出现问题。
更新:
到目前为止的答案表明这是非平凡的(我没有发现标准的Java示例/教程非常有用)。关键点是runActions()
必须明确知道它可能被中断。 join()
不是主要问题,因为线程一直在继续。
进一步的问题:
我是否必须在Thread.currentThread().isInterrupted()
中的所有位置插入runActions()
,我希望这些位置处于不可预测的长循环中?
答案 0 :(得分:3)
我在这里假设pageAnalyzerAction.runActions();
可以被中断(即它通过相当快的速度退出来处理中断)。
如果您对低级线程API不满意,可以使用java.concurrent包中的executor和future来为您处理线程管理和超时策略:
一个人为的例子是:
//declare an executor somewhere in your code, at a high level to recycle threads
ExecutorService executor = Executors.newFixedThreadPool(10); //number of threads: to be adjusted
private void runThread() throws InterruptedException {
long timeout = 15000L;
RunPageAnalyzer runPageAnalyzer = new RunPageAnalyzer(this);
Future future = executor.submit(runPageAnalyzer);
try {
future.get(timeout, TimeUnit.MILLISECONDS);
} catch (ExecutionException e) {
//the runnable threw an exception: handle it
} catch (TimeoutException e) {
//the task could not complete before the timeout
future.cancel(true); //interrrupt it
}
}
答案 1 :(得分:2)
听起来你的runActions
- 方法不会对正在设置的线程的中断状态做出反应。后者join
- 调用interrupt
后调用没有超时,并将无限期地等待线程t
死亡。您应检查runActions
- 方法中的中断状态,并在设置中断状态时终止操作(Thread.interrupted()
返回true)。
答案 2 :(得分:2)
这里的答案还没有提到其他的东西。如果要取消从线程完成的I / O,则无法“取消”它并期望实际的I / O被取消。您基本上必须处理“任务”中的中断异常并相应地处理它,甚至可能关闭套接字连接。我有一个small snippet致力于“停止”使用线程运行的任务,你可能会发现它们很有帮助(如果它有拼写错误而道歉,那是很久以前写的)。
public class ThreadStopTest {
public static void main(String[] args) {
testSqlThreadStop();
}
private static void testSocketReadStop() {
ExecutorService executor = Executors.newFixedThreadPool(2);
SocketTask task = new SocketTask("http://www.yahoo.com", 80);
Future<Integer> future = executor.submit(task);
try {
Integer result = future.get(1, TimeUnit.SECONDS);
System.out.println("Computation complete; result: " + result);
} catch(TimeoutException te) {
future.cancel(true);
task.cleanupAfterCancel();
System.out.println("Computation cancelled");
} catch(Exception e) {
e.printStackTrace();
}
executor.shutdown();
}
}
class SocketTask implements CleanableTask<Integer> {
private final String host;
private final int port;
private Socket socket;
public SocketTask(final String host, final int port) {
this.host = host;
this.port = port;
}
@Override
public Integer call() throws Exception {
InputStream in = null;
// TODO: Actually update the count and cleanly handle exceptions
int bytesRead = 0;
try {
this.socket = new Socket(this.host, this.port);
in = this.socket.getInputStream();
byte[] bytes = new byte[1000000];
System.out.println("Started reading bytes");
// The below behavior of waiting for a forceful close can be avoided
// if we modify the FutureTask class (the default Future impl)
// by passing in a CleanupHandler whose cleanup() method would be
// invoked after invoking the `cancel` method or by making all
// your tasks implement a CancelledTask interface which has a
// `cleanupAfterCancel` method to do the same. :)
try {
in.read(bytes);
} catch(SocketException se) {
if(Thread.currentThread().isInterrupted()) {
System.out.println("All OK; this socket was forcefully closed");
} else {
se.printStackTrace(); // something was seriously wrong
}
}
} catch(Exception e) {
e.printStackTrace();
} finally {
if(in != null) in.close();
}
return Integer.valueOf(bytesRead);
}
@Override
public void cleanupAfterCancel() {
try {
this.socket.close();
} catch (IOException e) {
e.printStackTrace();
}
}
}