如何编写确保发送电子邮件的Rspec控制器测试?

时间:2012-06-04 15:59:00

标签: ruby-on-rails ruby-on-rails-3 controller actionmailer rspec-rails

目前在我的控制器规范中我有:

require 'spec_helper'

describe CustomerTicketsController do
  login_user

  describe "POST /create (#create)" do
    # include EmailSpec::Helpers
    # include EmailSpec::Matchers
    it "should deliver the sales alert email" do
      # expect
      customer_ticket_attributes = FactoryGirl.attributes_for(:customer_ticket)
      customer_mailer = mock(CustomerMailer)
      customer_mailer.should_receive(:deliver).
        with(CustomerTicket.new(customer_ticket_attributes))
      # when
      post :create, :customer_ticket => customer_ticket_attributes
    end
  end
end

在我的控制器中我有:

  # POST /customer_tickets
  # POST /customer_tickets.xml
  def create
    respond_to do |format|
      if @customer_ticket.save
        CustomerMailer.sales_alert(@customer_ticket).deliver
        format.html { redirect_to @customer_ticket, notice: 'Customer ticket was successfully created.' }
        format.xml { render xml: @customer_ticket, status: :created, location: @customer_ticket }
      else
        format.html { render action: "new" }
        format.xml { render xml: @customer_ticket.errors, status: :unprocessable_entity }
      end
    end
  end

我的测试目前产生以下输出:

Failures:

  1) CustomerTicketsController POST /create (#create) should deliver the sales alert email
     Failure/Error: customer_mailer.should_receive(:deliver).
       (Mock CustomerMailer).deliver(#<CustomerTicket id: nil, first_name: "firstname1", last_name: "lastname1", company: nil, referral: nil, email: "firstname1@example.com", phone: "555-5555", fax: nil, country: nil, address1: "555 Rodeo Dr.", address2: nil, city: "Beverly Hills", state: "CA", postcode: "90210", question: "The answer to the universe is 4.", type: nil, status: nil, priority: nil, number: nil, cs_rep_id: nil, created_at: nil, updated_at: nil>)
           expected: 1 time
           received: 0 times
     # ./spec/controllers/customer_ticket_controller_spec.rb:13:in `block (3 levels) in <top (required)>'

Finished in 0.52133 seconds
1 example, 1 failure

Failed examples:

rspec ./spec/controllers/customer_ticket_controller_spec.rb:9 # CustomerTicketsController POST /create (#create) should deliver the sales alert email

感谢您的关注。

3 个答案:

答案 0 :(得分:18)

您可以检查ActionMailer :: Base.deliveries.count以确保它增加1。

像这样(未经测试)

expect {custom_mailer.deliver}.to change { ActionMailer::Base.deliveries.count }.by(1)

答案 1 :(得分:1)

您正在设置的模拟与实际执行的模拟不匹配。你必须在你正在创建的那个模拟器上调用deliver

这样的东西
message = mock('Message')
CustomerMailer.should_receive(:sales_alert).and_return(message)
message.should_receive(:deliver)

应该通过。

如果你想检查传递给sales_alert的内容你正在做什么将无法工作 - 活动记录只会按主键相等比较对象,所以你在规范中创建的客户票证' t等于控制器中创建的那个。

你可以做的一件事是

CustomerMailer.should_receive(:sales_alert) do |arg|
  ...
end.and_return(message)

rspec会产生调用的sales_alert,你可以做任何你想要的检查

另一种方法是将CustomerTicket.new存根,然后再控制它返回的内容,例如

mock_ticket = mock(CustomerTicket)
CustomerTicket.should_receive(:new).with(customer_ticket_attributes).and_return(mock_ticket)
mock_ticket.should_receive(:save).and_return(true)
CustomerMailer.should_receive(:sales_alert).with(mock_ticket).and_return(message)

最后,您可能会认为此警报发送应该属于CustomerTicket的实例方法,在这种情况下,您的控制器规范只能检查是否在故障单上调用了send_sales_alert方法。

答案 2 :(得分:0)

这是如何测试使用正确参数调用Mailer的方法。

delivery = double
expect(delivery).to receive(:deliver_now).with(no_args)

expect(CustomerMailer).to receive(:sales_alert)
  .with(customer_ticket)
  .and_return(delivery)