我必须连接到一些使用嵌套数组的旧代码,因此我必须将嵌套的Lists转换为嵌套数组。
我心里想,这个功能应该已经在一些现有的库中实现了。我在Google / StackOverflow上搜索但没有任何浮出水面。我检查过Apache Commons和Guava,但我找不到相同的功能。
这是我的代码,我关心的是这可以用更简单的方式完成。任何想法,建议和改进都受到热烈欢迎。
@SuppressWarnings("rawtypes")
public static <E> Class getNestedListClass(List<List<E>> list){
if (list == null) {
return null;
}
for (final List<E> innerList: list) {
if (innerList == null || innerList.isEmpty()) {
continue;
}
return innerList.get(0).getClass();
}
return null;
}
@SuppressWarnings({ "unchecked", "rawtypes" })
public static <E> E[][] convertNestedList(List<List<E>> list){
final Class<?> clazz = getNestedListClass(list);
if (clazz == null) {
return null;
}
final E[][] result = (E[][]) Array.newInstance(clazz, list.size(), 0);
for (int i = 0; i < list.size(); i++) {
final List<E> innerList = list.get(i);
if (innerList == null) {
continue;
}
result[i] = innerList.toArray((E[]) Array.newInstance(clazz, innerList.size()));
}
return result;
}
@Test
public void testConvertNestedList() {
final List<List<String>> list = new ArrayList<List<String>>();
list.add(new ArrayList<String>());
list.get(list.size() - 1).add("0.0");
list.get(list.size() - 1).add("0.1");
list.get(list.size() - 1).add("0.2");
list.add(new ArrayList<String>());
list.get(list.size() - 1).add("1.0");
list.get(list.size() - 1).add("1.1");
list.get(list.size() - 1).add("1.2");
list.get(list.size() - 1).add("1.3");
list.add(new ArrayList<String>());
list.get(list.size() - 1).add("2.0");
list.get(list.size() - 1).add("2.1");
final String[][] array = convertNestedList(list);
final String[][] expected = new String[][] {
{ "0.0", "0.1", "0.2" },
{ "1.0", "1.1", "1.2", "1.3" },
{ "2.0", "2.1" } };
assertArrayEquals(expected, array);
}
编辑添加了一些测试用例:
@Test
public void testConvertNestedListCaseNull() throws NetLineMarketException {
List<List<Object>> list = null;
Object[][] array = ArrayUtils.convertNestedList(list);
Object[][] expected = null;
assertArrayEquals(expected, array);
}
@Test
public void testConvertNestedListCaseNullElement() throws NetLineMarketException {
List<List<Object>> list = new ArrayList<List<Object>>();
list.add(null);
Object[][] array = ArrayUtils.convertNestedList(list);
Object[][] expected = new Object[][] { null };
assertArrayEquals(expected, array);
}
@Test
public void testConvertNestedListCaseNullElement2() throws NetLineMarketException {
List<List<Object>> list = new ArrayList<List<Object>>();
list.add(new ArrayList<Object>());
list.get(0).add(null);
Object[][] array = ArrayUtils.convertNestedList(list);
Object[][] expected = new Object[][] { { null } };
assertArrayEquals(expected, array);
}
@Test
public void testConvertNestedListCaseEmpty() throws NetLineMarketException {
List<List<Object>> list = new ArrayList<List<Object>>();
Object[][] array = ArrayUtils.convertNestedList(list);
Object[][] expected = new Object[][] { };
assertArrayEquals(expected, array);
}
@Test
public void testConvertNestedListCaseString() throws NetLineMarketException {
final String string = "string";
List<List<Object>> list = new ArrayList<List<Object>>();
list.add(new ArrayList<Object>());
list.get(0).add(string);
Object[][] array = ArrayUtils.convertNestedList(list);
Object[][] expected = new Object[][] { { string } };
assertArrayEquals(expected, array);
}
@Test(expected=MyException.class)
public void testConvertNestedListCaseMix() throws NetLineMarketException {
final String string = "string";
List<List<Object>> list = new ArrayList<List<Object>>();
list.add(new ArrayList<Object>());
list.get(0).add(string);
list.get(0).add(Boolean.TRUE);
Object[][] array = ArrayUtils.convertNestedList(list);
}
答案 0 :(得分:1)
您的代码存在一些问题。例如:
List<Object>(null)
已转换为null
而非Object[] { null }
List<Object>("string")
已转换为String[] { "string" }
而非Object[] { "string" }
List<Object>("string", Boolean.TRUE)
会产生运行时错误。我的建议:
public static <T> T[][] toArray(List<List<T>> list, Class<T> clazz) {
if (list == null) {
return null;
}
List<T[]> temp = new ArrayList<>();
@SuppressWarnings("unchecked")
T[] inner = (T[]) Array.newInstance(clazz, 0);
for (List<T> sublist : list) {
temp.add(sublist == null ? null : sublist.toArray(inner));
}
@SuppressWarnings("unchecked")
T[][] outer = (T[][]) Array.newInstance(inner.getClass(), temp.size());
return temp.toArray(outer);
}