Question

我有json请求，显示汽车列表。我使用计时器每隔10秒刷新一次请求以及列表。问题是数据不断添加到数组并使我的应用程序崩溃。如何在添加新数据之前清除数据？我该怎么办？

    let list = listdevices[indexPath.row] // error 

    if list.statusxe == "run" {
        cell?.devnameLabel?.text = list.devname
        cell?.addressLabel?.text = list.address
        cell?.statusxeLabel?.textColor = UIColor(red: 1/255, green: 117/255, blue: 0/255, alpha: 1)
        cell?.statusxeLabel?.text = "Đang chạy"
        cell?.speedLabel?.text = "\(list.speed) km/h"

    }
   else if  list.statusxe == "stop"{
        cell?.devnameLabel?.text = list.devname
        cell?.addressLabel?.text = list.address
        cell?.statusxeLabel?.textColor = UIColor(red: 230/255, green: 6/255, blue: 6/255, alpha: 1)

        cell?.statusxeLabel?.text = "Đang dừng"
        cell?.speedLabel?.text = ""

    }
    else if list.statusxe == "expired"{
        cell?.devnameLabel?.text = list.devname
        cell?.addressLabel?.text = list.address
        cell?.statusxeLabel?.textColor = UIColor.black
        cell?.speedLabel?.textColor = UIColor.black

        cell?.statusxeLabel.text = " "
        cell?.speedLabel?.text = "hết hạn dịch vụ"
    }
    else if list.statusxe == "lost_gprs"{
        cell?.devnameLabel?.text = list.devname
        cell?.addressLabel?.text = list.address
        cell?.statusxeLabel?.textColor = UIColor.red
        cell?.statusxeLabel?.text = "Mất GPRS"
        cell?.speedLabel?.text = ""
    }
    cell?.accessoryType = UITableViewCellAccessoryType.disclosureIndicator

    return cell!
}

我有json请求，显示汽车列表。我使用计时器每隔10秒刷新一次请求以及列表。问题是数据不断添加到数组并使我的应用程序崩溃。如何在添加新数据之前清除数据？我该怎么办？

    let url = "http://api.vnetgps.com:8000/tracking"

    var request = URLRequest(url: URL(string: url)!)
    request.httpMethod = "GET"
    request.setValue(token , forHTTPHeaderField: "token")
    request.setValue(username, forHTTPHeaderField: "username")
    request.setValue("-1", forHTTPHeaderField: "devid")
    let configuration = URLSessionConfiguration.default
    let session = URLSession(configuration: configuration, delegate: nil, delegateQueue: OperationQueue.main)

    let task = session.dataTask(with: request, completionHandler: {(data, response, error) in

        if (error != nil ) {
            print("Error")

        }
        else {
            self.listdevices.removeAll()


            if let json = try? JSONSerialization.jsonObject(with: data!, options: []) as? [String: Any],

                let items = json?["units"] as? [[String: Any]] {


                for item in items {

                    var lat = item["latitude"] as? String
                    UserDefaults.standard.set(lat, forKey: "latitude")

                    var long = item["longitude"] as? String
                    UserDefaults.standard.set(long, forKey: "longitude")

                   // print("long", long)
                    var devid = item["devid"] as? String
                    UserDefaults.standard.set(devid, forKey: "devid")
                    var devname = item["devname"] as? String
                    UserDefaults.standard.set(devname, forKey: "devname")

                    var speed = item["speed"] as? String
                    UserDefaults.standard.set(speed, forKey: "speed")

                    var statustt = item["status"] as? String
                    UserDefaults.standard.set(statustt, forKey: "statusxe")
                    var drivername = item["drivername"] as? String
                    UserDefaults.standard.set(drivername, forKey: "drivername")
                    var address = item["address"] as? String
                    UserDefaults.standard.set(address, forKey: "address")
                     var direction = item["direction"] as? String


                    self.listdevices.append(Listdevices(statusxe: statustt! , speed: speed!, devid: devid!, devname: devname!, address: address!, latitude: lat!, longitude: long!, drivername: drivername!, direction: direction!))
                    // print("list",self.listdevices)

                }

                DispatchQueue.main.async {
                self.tableView.reloadData()
                }


            }
        }

    })
    task.resume()
}

Answer 1

我认为这可能是由于代码的异步性质造成的。请尝试避免self.listdevices.append并使用类似：

的内容

// declare listdevices with var instead of let
let temp = [Listdevices]()
for item in items {
    ...

    temp.append(Listdevices(statusxe: statustt! , speed: speed!, devid: devid!, devname: devname!, address: address!, latitude: lat!, longitude: long!, drivername: drivername!, direction: direction!))
} 


self.listdevices = temp

Answer 2

问题可能是在tableview使用数组时清空数组。

而是使用map将旧数组内容替换为新内容。这样你就不需要先清空数组了。

类似的东西：

self.listDevices = items.map { Listdevices($0) }

然后为ListDevices实现这样的初始化：

init(device: [String: Any]) { ... }

一些未经请求的代码审核评论：

对UserDefaults的所有写入都是毫无意义的，因为每次迭代都会覆盖前一次迭代，因此您应该删除整个循环。
将statusxe设为enum StatusXE
使用基于新StatusXE枚举的开关替换长条件
注意命名。变量列表不是列表，因此请不要将其称为，而是将其称为设备。变量 listdevices 应该只被称为设备，或者如果您坚持使用单词列表，则它应该是 deviceList 。还记得正确的camelCasing。
避免强行打开。可能使用nil coalescing运算符为null的设备属性提供默认值。
避免不必要地重复代码。在长条件中，在每种情况下都重复前两行代码。只需将这两行移出条件。

请求新的json响应时清除数组中的数据（致命错误：索引超出范围swift 3）

2 个答案: