为什么DelegateCommand对Button和MenuItem的工作方式不一样?

时间:2009-06-05 09:48:54

标签: mvvm delegatecommand

此代码显示Delegate Command from the Visual Studio MVVM template与MenuItem和Button一起使用时的工作方式不同:

  • 使用Button,命令方法可以访问ViewModel上已更改的OnPropertyChanged值
  • 使用MenuItem时,命令方法无法访问更改的OnPropertyChanged值

有谁知道为什么会这样?

MainView.xaml:

<Window x:Class="TestCommand82828.Views.MainView"
    xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
    xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
    xmlns:c="clr-namespace:TestCommand82828.Commands"
    Title="Main Window" Height="400" Width="800">

    <DockPanel>
        <Menu DockPanel.Dock="Top">
            <MenuItem Header="_File">
                <MenuItem Command="{Binding DoSomethingCommand}" Header="Do Something" />
            </MenuItem>
        </Menu>
        <StackPanel HorizontalAlignment="Left" VerticalAlignment="Top">
            <Button Command="{Binding DoSomethingCommand}" Content="test"/>
            <TextBlock Text="{Binding Output}"/>
            <TextBox Text="{Binding TheInput}"/>
        </StackPanel>

    </DockPanel>
</Window>

MainViewModel.cs:

using System;
using System.Windows;
using System.Windows.Input;
using TestCommand82828.Commands;

namespace TestCommand82828.ViewModels
{
    public class MainViewModel : ViewModelBase
    {
        #region ViewModelProperty: TheInput
        private string _theInput;
        public string TheInput
        {
            get
            {
                return _theInput;
            }

            set
            {
                _theInput = value;
                OnPropertyChanged("TheInput");
            }
        }
        #endregion

        #region DelegateCommand: DoSomething
        private DelegateCommand doSomethingCommand;

        public ICommand DoSomethingCommand
        {
            get
            {
                if (doSomethingCommand == null)
                {
                    doSomethingCommand = new DelegateCommand(DoSomething, CanDoSomething);
                }
                return doSomethingCommand;
            }
        }

        private void DoSomething()
        {
            Output = "did something, the input was: " + _theInput;
        }

        private bool CanDoSomething()
        {
            return true;
        }
        #endregion            

        #region ViewModelProperty: Output
        private string _output;
        public string Output
        {
            get
            {
                return _output;
            }

            set
            {
                _output = value;
                OnPropertyChanged("Output");
            }
        }
        #endregion

    }
}

1 个答案:

答案 0 :(得分:3)

我认为你所看到的是因为MenuItems没有将焦点从TextBox中移开,并且默认情况下,当焦点偏离它时,TextBox仅将更改推回到其绑定源。因此,当您单击按钮时,焦点将转移到按钮,将TextBox的值写回_theInput。但是,当您单击MenuItem时,焦点仍保留在TextBox中,因此不会写入值。

尝试将TextBox声明更改为:

<TextBox Text="{Binding TheInput,UpdateSourceTrigger=PropertyChanged}"/>

或者,尝试切换到可以接收参数的DelegateCommand<t>,并将TextBox的文本传递给它:

<MenuItem Command="{Binding DoSomethingCommand}" 
          CommandParameter="{Binding Text,ElementName=inputTextBox}" />
...
<TextBox x:Name="inputTextBox" Text="{Binding TheInput}" />