Question

我想要一个计时器类，可以在1/2/3秒内将消息发布给委托。

我的测试目标一直崩溃。

iOS逻辑单元测试目标。
使用重复的NSTimer
一次没有断言的测试。测试通过，但随后目标崩溃：

/Developer/Tools/RunPlatformUnitTests.include: line 415: 770 Bus error "${THIN_TEST_RIG}" "${OTHER_TEST_FLAGS}" "${TEST_BUNDLE_PATH}"

在我看来，这是某种内存分配错误，但我无法弄清楚我错过了什么。该问题以某种方式与停止计时器例程相关联。只有当计时器用完时，目标才会崩溃。

我尝试过的事情

构建和分析 - 未报告错误
从链接器标志中删除-framework和UIKit
删除dealloc - 这没有效果

测试代码

-(void)testGivenThreeSecondDurationAtOneSecondDelegateShouldBeToldToShowGreenCard {
    JGTimerController *timer = [JGTimerController timerWithDurationValue:1 delegate:nil];
    [timer startTimer];

    [[NSRunLoop currentRunLoop] runUntilDate:[NSDate dateWithTimeIntervalSinceNow:1.1]];
}

类代码

@interface JGTimerController : NSObject {
    NSNumber    *duration;
    NSTimer     *timer;
    id <NSObject, JGTimerControllerDelegate> _delegate;
}
@property (nonatomic, retain) NSNumber *duration;
... public methods...
@end


@implementation JGTimerController

@synthesize duration;

+(JGTimerController *)timerWithDurationValue:(NSUInteger)durationValue delegate:(id <JGTimerControllerDelegate>)delegate_ {
    JGTimerController *instance = [[[JGTimerController alloc] initWithDurationValue:durationValue delegate:delegate_] autorelease];
    return instance;
}

-(JGTimerController *)initWithDurationValue:(NSUInteger)durationValue delegate:(id <JGTimerControllerDelegate>)delegate_ {
    self = [super init];
    timer = nil;
    [self setDurationValue:durationValue];
    _delegate = delegate_;
    return self;
}

-(NSUInteger)durationValue {
    NSNumber *result = [self duration];
    return result ? [result intValue] : 0;
}

-(void)setDurationValue:(NSUInteger)value_ {
    [self setDuration:[NSNumber numberWithInt:value_]];
}

-(BOOL)stopTimerAtZeroDuration:(NSTimer *)timer_ {
    if ([self durationValue] == 0) {
        [self stopTimer];
        return YES;
    }
    return NO;
}

-(void)startTimer {
    if ([self stopTimerAtZeroDuration:nil])
        return;

    timer = [NSTimer scheduledTimerWithTimeInterval:1 target:self selector:@selector(timerDidCountDownByASecond:) userInfo:nil repeats:YES];
}

-(void)stopTimer {
    if ([self durationValue] == 0 && [_delegate conformsToProtocol:@protocol(JGTimerControllerDelegate)])
        [_delegate showRedCard];

    [timer invalidate];
    [timer release];
}

-(BOOL)timerIsRunning {
    return (timer != nil);
}

-(void)timerDidCountDownByASecond:(NSTimer *)timer_ {
    [self setDurationValue:[self durationValue] - 1];
    [self stopTimerAtZeroDuration:timer_];
}

-(void)dealloc {
    [_delegate release];
    [timer release];
    [duration release];
    [super dealloc];
}

@end

Answer 1

[_delegate release]中应该没有dealloc，因为您没有保留它。

Answer 2

同样，不应该释放计时器。 NSTimer就像其他NSObject一样，如果你没有分配，复制或保留，你就不需要发布。

iOS逻辑单元测试目标在单元测试通过NSTimer后崩溃

2 个答案: