Question

我已经搜遍了整个地方，似乎没有其他人有这个'加密'方法的问题导致他们的测试失败，虽然看起来很多其他人在第7章遇到了一些困难。没有进一步的说法，

的链接

用户模型文件中的代码和相应的spec文件看起来与他编写的内容完全一致，但仍然无法通过测试。错误？

Failures:
1) User should create a new instance given valid attributes
Failure/Error: User.Create!(@attr)
NoMethodError: undefined method 'encrypt' for #<User:asdf>
#./app/models/user.rb:22:in 'has_password?'
#./app/models/user.rb:28:in 'encrypt_password'
#./spec/models/user_spec.rb:15:in 'block (2 levels) in <top (required)>'

2) User should not allow duplicate email addresses
Failure/Error: User.Create!(@attr)
NoMethodError: undefined method 'encrypt' for #<User:asdf>
#./app/models/user.rb:22:in 'has_password?'
#./app/models/user.rb:28:in 'encrypt_password'
#./spec/models/user_spec.rb:15:in 'block (2 levels) in <top (required)>'

3) User should reject email addresses identical up to case
Failure/Error: User.Create!(@attr)
NoMethodError: undefined method 'encrypt' for #<User:asdf>
#./app/models/user.rb:22:in 'has_password?'
#./app/models/user.rb:28:in 'encrypt_password'
#./spec/models/user_spec.rb:15:in 'block (2 levels) in <top (required)>'

...

7) User has_password? method should be false if passwords do not match
Failure/Error: User.Create!(@attr)
NoMethodError: undefined method 'encrypt' for #<User:asdf>
#./app/models/user.rb:22:in 'has_password?'
#./app/models/user.rb:28:in 'encrypt_password'
#./spec/models/user_spec.rb:15:in 'block (3 levels) in <top (required)>'

所以我为每次测试都收到了相同的错误消息，我很想找到原因！

这是我的user.rb：

require 'digest'
class User < ActiveRecord::Base
  attr_accessor :password
  attr_accessible :name, :email, :password, :password_confirmation

  email_regex = /\A[\w+\-.]+@[a-z\d\-.]+\.[a-z]+\z/i

  validates :name,  :presence => true,
                    :length   => { :maximum => 50 }
  validates :email, :presence => true,
                    :format   => { :with => email_regex },
                    :uniqueness => { :case_sensitive => false }
#automatically create the virtual attribute for 'password_confirmation'
  validates :password, :presence => true,
                       :confirmation => true,
                       :length => { :within => 6..40 }

  before_save :encrypt_password

  #returns true if the users password matches the submitted one
  def has_password?(submitted_password)
  encrypted_password == encrypt(submitted_password)
  end

  private

  def encrypt_password
    self.salt = make_salt unless has_password?(password)
    self.encrypted_password = encrypt(password)
  end

  def encrypt_string
    secure_hash("#{salt}--#{string}")
  end

  def make_salt
    secure_hash("#{Time.now.utc}--#{password}")
  end

  def secure_hash(string)
    Digest::SHA2.hexdigest(string)
  end
end

和我的user_spec.rb文件：

require 'spec_helper'
require 'digest'

describe User do
  before(:each) do
@attr = {
  :name => "User Name",
  :email => "example@email.com",
  :password => "password",
  :password_confirmation => "password"
}
  end

  it "should create a new instance given valid attributes" do
User.create!(@attr)
  end

  it "should require a name" do
no_name_user = User.new(@attr.merge(:name => ""))
no_name_user.should_not be_valid
  end

  it "should require an email" do
no_email_user = User.new(@attr.merge(:email => ""))
no_email_user.should_not be_valid
  end

  it "should reject names that are too long" do
long_name = "a" * 51
long_name_user = User.new(@attr.merge(:name => long_name))
long_name_user.should_not be_valid
  end

  it "should accept valid email addresses" do
addresses = %w[user@foo.com THE_USER@foo.bar.org first.last@foo.jp]
addresses.each do |address|
  valid_email_user = User.new(@attr.merge(:email => address))
  valid_email_user.should be_valid
end
  end

  it "should reject invalid email addresses" do
addresses = %w[user@foo,com user_at_foo.org example.user@foo.]
    addresses.each do |address|
  invalid_email_user = User.new(@attr.merge(:email => address))
  invalid_email_user.should_not be_valid
    end
  end

  it "should not allow duplicate email addresses" do 
User.create!(@attr)
user_with_duplicate_email = User.new(@attr)
user_with_duplicate_email.should_not be_valid
  end

  it "should reject email addresses identical up to case" do
upcased_email = @attr[:email].upcase
User.create!(@attr.merge(:email => upcased_email))
user_with_duplicate_email = User.new(@attr)
user_with_duplicate_email.should_not be_valid
  end

  describe "password validations" do
it "should require a password" do
  User.new(@attr.merge(:password => "", :password_confirmation => ""))
  should_not be_valid
end

it "should require password to match the password confirmation" do
  User.new(@attr.merge(:password_confirmation => "invalid"))
  should_not be_valid
end

it "should reject short passwords" do
  short = "a" * 5
  hash = @attr.merge(:password => short, :password_confirmation => short)
  User.new(hash).should_not be_valid
end

it "should reject long passwords" do
  long = "a" * 41
  hash = @attr.merge(:password => long, :password_confirmation => long)
  User.new(hash).should_not be_valid
    end
  end

  describe "password encryption" do

before(:each) do
  @user = User.create!(@attr)
end

it "should have an encrypted password attribute" do
  @user.should respond_to(:encrypted_password)
end

it "should not allow a blank encrypted password" do
  @user.encrypted_password.should_not be_blank
    end
  end

  describe "has_password? method" do

    before(:each) do
  @attr = User.create!(@attr)
    end

  it "should be true if the passwords match" do
    @user.has_password?(@attr[:password]).should be_true
  end

  it "should be false if the passwords don't match" do
        @user.has_password?("invalid").should be_false
      end 
  end
end

非常感谢任何帮助。我倾注了其他问题，我的代码，并改变了各个方面，试图让测试工作，一切都无济于事。我希望这不是真正愚蠢的东西，我还没有看到。

Answer 1

您的错误在这里：

  def encrypt_string
    secure_hash("#{salt}--#{string}")
  end

您在以下 encrypt_password 方法中呼叫encrypt但上述方法名为encrypt_string：

  def encrypt_password
    self.salt = make_salt unless has_password?(password)
    self.encrypted_password = encrypt(password)
  end

只需在方法定义中将encrypt_string更改为encrypt，就可以了。

RoR教程，第7章 - rspec测试失败：NoMethodError'加密'

1 个答案: