如何修复jQuery插件中的单选按钮验证?

时间:2011-11-25 15:39:30

标签: javascript jquery jquery-validate radio-button

我正在使用一个名为Stepy的jQuery插件,它基于FormToWizard插件,允许用户完成一个10步的表单。 Stepy与jQuery Validation插件集成。

我遇到了一个问题,如果表单上有多个单选按钮,它会抛出并出错,并且不会让用户继续。这只发生在第一个单选按钮(第一个单选按钮验证正常)之后,并且仅当单选按钮后面有步骤时(如果单选按钮在最后一步它工作正常)。

FireBug显示“a is undefined”。此外,这似乎只在激活Validation插件时发生(“validate:true”)。

通过Stepy和jQuery Validate代码,我似乎无法弄清楚为什么会发生这种情况。

我发布了一个工作示例:http://jsfiddle.net/5Rd7A/3/

有什么想法吗?

使用Javascript:

$(function() {

    $('#custom').stepy({
      backLabel: 'Backward',
      block: true,
      errorImage: true,
      nextLabel: 'Forward',
      titleClick: true,
      validate: true
    });

});

HTML:

<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
  <body>
    <form id="custom" name="custom">
      <fieldset title="Thread 1">
        <legend>description one</legend>
        <label>Question A:</label> <input type="text" id="question_a" name="question_a" class="required">
        <label>Question B:</label> <input type="text" id="question_b" name="question_b">
      </fieldset>
      <fieldset title="Thread 2">
        <legend>description two</legend>
        <label>Question C:</label> <input type="text" id="question_c" name="question_c" class="required">
        <label>Question D:</label>
        <input id="answer_d1" type="radio" name="question_d" class="required"> Answer D1
        <input id="answer_d2" type="radio" name="question_d" class="required"> Answer D2
      </fieldset>
      <fieldset title="Thread 3">
        <legend>description three</legend>
        <label>Question E:</label> <input type="text" id="question_e" name="question_e" class="required">
        <label>Question F:</label>
        <input id="answer_f1" type="radio" name="question_f" class="required"> Answer F1
        <input id="answer_f2" type="radio" name="question_f" class="required"> Answer F2
      </fieldset>
      <fieldset title="Thread 4">
        <legend>description four</legend>
        <label>Question G:</label> <input type="text" id="question_g" name="question_g" class="required">
        <label>Question H:</label> <input type="text" id="question_h" name="question_h" class="required">
      </fieldset>
      <input type="submit" class="finish" value="Finish!">
    </form><br>
  </body>
</html>

stepy.js

;(function($) {

    var methods = {
        init: function(options) {
            return this.each(function() {

                var opt     = $.extend({}, $.fn.stepy.defaults, options),
                    $this   = $(this).data('options', opt),
                    id      = $this.attr('id');

                if (id === undefined) {
                    id = 'stepy-' + $this.index();
                    $this.attr('id', id); 
                }

                var $titlesWrapper = $('<ul/>', { id: id + '-titles', 'class': 'stepy-titles' });

                if (opt.titleTarget) {
                    $(opt.titleTarget).html($titlesWrapper);
                } else {
                    $titlesWrapper.insertBefore($this);
                }

                if (opt.validate) {
                    $this.append('<div class="stepy-error"/>');
                }

                var $steps      = $this.children('fieldset'),
                    $step       = undefined,
                    $legend     = undefined,
                    description = '',
                    title       = '';

                $steps.each(function(index) {
                    $step = $(this);

                    $step
                    .addClass('step')
                    .attr('id', id + '-step-' + index)
                    .append('<p id="' + id + '-buttons-' + index + '" class="' + id + '-buttons"/>');

                    $legend = $step.children('legend');

                    if (!opt.legend) {
                        $legend.hide();
                    }

                    description = '';

                    if (opt.description) {
                        if ($legend.length) {
                            description = '<span>' + $legend.html() + '</span>';
                        } else {
                            $.error(id + ': the legend element of the step ' + (index + 1) + ' is required to set the description!');
                        }
                    }

                    title = $step.attr('title');
                    title = (title != '') ? '<div>' + title + '</div>': '--';

                    $titlesWrapper.append('<li id="' + id + '-title-' + index + '">' + title + description + '</li>');

                    if (index == 0) {
                        if ($steps.length > 1) {
                            methods.createNextButton.call($this, index);
                        }
                    } else {
                        methods.createBackButton.call($this, index);

                        $step.hide();

                        if (index < $steps.length - 1) {
                            methods.createNextButton.call($this, index);
                        }
                    }
                });

                var $titles = $titlesWrapper.children();

                $titles.first().addClass('current-step');

                var $finish = $this.children('.finish');

                if (opt.finishButton) {
                    if ($finish.length) {
                        var isForm      = $this.is('form'),
                            onSubmit    = undefined;

                        if (opt.finish && isForm) {
                            onSubmit = $this.attr('onsubmit');
                            $this.attr('onsubmit', 'return false;');
                        }

                        $finish.click(function(evt) {
                            if (opt.finish && !methods.execute.call($this, opt.finish, $steps.length - 1)) {
                                evt.preventDefault();
                            } else {
                                if (isForm) {
                                    if (onSubmit) {
                                        $this.attr('onsubmit', onSubmit);
                                    } else {
                                        $this.removeAttr('onsubmit');
                                    }

                                    var isSubmit = $finish.attr('type') == 'submit';

                                    if (!isSubmit && (!opt.validate || methods.validate.call($this, $steps.length - 1))) {
                                        $this.submit();
                                    }
                                }
                            }
                        });

                        $finish.appendTo($this.find('p:last'));
                    } else {
                        $.error(id + ': element with class name "finish" missing!');
                    }
                }

                if (opt.titleClick) {
                    $titles.click(function() {
                        var array   = $titles.filter('.current-step').attr('id').split('-'), // TODO: try keep the number in an attribute.
                            current = parseInt(array[array.length - 1], 10),
                            clicked = $(this).index();

                        if (clicked > current) {
                            if (opt.next && !methods.execute.call($this, opt.next, clicked)) {
                                return false;
                            }
                        } else if (clicked < current) {
                            if (opt.back && !methods.execute.call($this, opt.back, clicked)) {
                                return false;
                            }
                        }

                        if (clicked != current) {
                            methods.step.call($this, (clicked) + 1);
                        }
                    });
                } else {
                    $titles.css('cursor', 'default');
                }

                $steps.delegate('input[type="text"], input[type="password"]', 'keypress', function(evt) {
                    var key = (evt.keyCode ? evt.keyCode : evt.which);

                    if (key == 13) {
                        evt.preventDefault();

                        var $buttons = $(this).parent().children('.' + id + '-buttons');

                        if ($buttons.length) {
                            var $next = $buttons.children('.button right-aligned');

                            if ($next.length) {
                                $next.click();
                            } else {
                                var $finish = $buttons.children('.finish');

                                if ($finish.length) {
                                    $finish.click();
                                }
                            }
                        }
                    }
                });

                $steps.first().find(':input:visible:enabled').first().select().focus();
            });
        }, createBackButton: function(index) {
            var $this   = this,
                id      = this.attr('id'),
                opt     = this.data('options');

            $('<a/>', { id: id + '-back-' + index, href: 'javascript:void(0);', 'class': 'button left-aligned', html: opt.backLabel }).click(function() {
                if (!opt.back || methods.execute.call($this, opt.back, index - 1)) {
                    methods.step.call($this, (index - 1) + 1);
                }
            }).appendTo($('#' + id + '-buttons-' + index));
        }, createNextButton: function(index) {
            var $this   = this,
                id      = this.attr('id'),
                opt     = this.data('options');

            $('<a/>', { id: id + '-next-' + index, href: 'javascript:void(0);', 'class': 'button right-aligned', html: opt.nextLabel }).click(function() {
                if (!opt.next || methods.execute.call($this, opt.next, index + 1)) {
                    methods.step.call($this, (index + 1) + 1);
                }
            }).appendTo($('#' + id + '-buttons-' + index));
        }, execute: function(callback, index) {
            var isValid = callback.call(this, index + 1);

            return isValid || isValid === undefined;
        }, step: function(index) {
            index--;

            var $steps = this.children('fieldset');

            if (index > $steps.length - 1) {
                index = $steps.length - 1;
            }

            var opt = this.data('options');
                max = index;

            if (opt.validate) {
                var isValid = true;

                for (var i = 0; i < index; i++) {
                    isValid &= methods.validate.call(this, i);

                    if (opt.block && !isValid) {
                        max = i;
                        break;
                    }
                }
            }

            $steps.hide().eq(max).show();

            var $titles = $('#' + this.attr('id') + '-titles').children();

            $titles.removeClass('current-step').eq(max).addClass('current-step');

            if (this.is('form')) {
                var $fields = undefined;

                if (max == index) {
                    $fields = $steps.eq(max).find(':input:enabled:visible');
                } else {
                    $fields = $steps.eq(max).find('.error').select().focus();
                }

                $fields.first().select().focus();
            }

            if (opt.select) {
                opt.select.call(this, max + 1);
            }

            return this;
        }, validate: function(index) {
            if (!this.is('form')) {
                return true;
            }

            var $step   = this.children('fieldset').eq(index),
                isValid = true,
                $title  = $('#' + this.attr('id') + '-titles').children().eq(index),
                opt     = this.data('options'),
                $this   = this;

            $($step.find(':input:enabled').get().reverse()).each(function() {

                var fieldIsValid = $this.validate().element($(this));

                if (fieldIsValid === undefined) {
                    fieldIsValid = true;
                }

                isValid &= fieldIsValid;

                if (isValid) {
                    if (opt.errorImage) {
                        $title.removeClass('error-image');
                    }
                } else {
                    if (opt.errorImage) {
                        $title.addClass('error-image');
                    }

                    $this.validate().focusInvalid();
                }
            });

            return isValid;
        }
    };

    $.fn.stepy = function(method) {
        if (methods[method]) {
            return methods[method].apply(this, Array.prototype.slice.call(arguments, 1));
        } else if (typeof method === 'object' || !method) {
            return methods.init.apply(this, arguments);
        } else {
            $.error('Method ' + method + ' does not exist!');
        } 
    };

    $.fn.stepy.defaults = {
        back:           undefined,
        backLabel:      '&lt; Back',
        block:          false,
        description:    true,
        errorImage:     false,
        finish:         undefined,
        finishButton:   true,
        legend:         true,
        next:           undefined,
        nextLabel:      'Next &gt;',
        titleClick:     false,
        titleTarget:    undefined,
        validate:       false,
        select:         undefined
    };

})(jQuery);

2 个答案:

答案 0 :(得分:4)

Hi Michale和graphicdivine,

jQuery Validation 1.9中的一个问题是,默认情况下忽略:hidden 字段作为新功能,但返回undefined。然后在代码中使用undefined并在使用时中断。 关于未定义的返回我们有很多问题,这次尝试避免破解jQuery Stepy并在jQuery Validation 1.9上修复它[1]。

现在无论这个错误修复如何,我们都必须删除忽略选项(jQuery Validation)的隐藏字段,因为选项titleClick(jQuery Stepy)也会验证隐藏的步骤,因为您可以跳过步骤而不显示它们。

你可以使用之前的版本[2]没有这个bug,或使用固定版本[3],而不是官方版本。

[1] https://github.com/jzaefferer/jquery-validation/pull/263
[2] http://ajax.aspnetcdn.com/ajax/jquery.validate/1.8/jquery.validate.js
[3] github.com/wbotelhos/jquery-validation

答案 1 :(得分:1)

我不知道,但是通过切换问题的顺序,错误仍然存​​在于第二组无线电上。所以看起来你的代码很好,而且它是错误的Stepy或Validator(或它们之间的连接)。

http://jsfiddle.net/yBEsM/

修改

似乎错误是通过输入第4个字段集触发的,而不是通过离开第3个字段集来触发。

修改

...并且关闭所有“必需”仍会产生错误,因此我猜测Stepy是问题所在。

http://jsfiddle.net/4KEsg/

修改

...尽管如此,转向FALSE stepy的VALIDATE选项也可以解决问题。

修改

启用验证后,单个单选按钮就足以打破它:http://jsfiddle.net/5n5BA/1/