Question

您好我正在为一个气象站上课，要求用户输入变量并将小时数传递给数组：计算平均值，高点和低点的值。我让它工作，但想让数组[元素]私有化。有可能这样做吗？

到目前为止，这是我的代码。提前感谢您的帮助。

布赖恩

#include <iostream>
#include <iomanip>

using namespace std;

class WeatherStation
{
public:
    WeatherStation();
    void GetATemperatures(int[], int);
    void DisplayATemperatures( int[], int);
    void arrayCalcs(int[], int);

private:
    static const int aTemps = 24;
    static const int atemps[aTemps];
};

WeatherStation::WeatherStation()
{
    int atemps[aTemps];
}

void WeatherStation::GetATemperatures(int atemps[], int aTemps)
{
    for (int i = 0; i < aTemps; i++ )
    {
        cout << "Please enter the temperature for " << i  << ":00 ";

        while(true)
        {
            cin >> atemps[i];

            if(atemps[i] >= -50 && atemps[i] <= 130)
            {
                break;
            } else {
                cout << "This temperature is not valid\n";
                cout << "Please enter a temperature between -50 and 130 degrees F \n";
                cout << "Please enter a new temperature: ";
            }
        }
    }
}

void WeatherStation::DisplayATemperatures( int atemps[], int aTemps)
{
    cout << setw (5) << "Hour" << setw(24)<< "Temperature \n";
    cout << "\n";

    for (int k = 0; k < aTemps; k++)
    {
        cout << setw (3) << k << ":00" << setw (16) << atemps[k]<<endl;
    }

    cout <<"\n";
}

void WeatherStation::arrayCalcs(int atemps[], int aTemps)
{
    int sumA = 0;

    double average = 0.0;
    int minA = atemps[0];

    int maxA = atemps[0];

    int lowest = 0;
    int highest = 0;

    //Sum of the AM temps
    for (int kk = 0; kk < aTemps; kk++)
    {
        sumA = sumA + atemps[kk];
    }

    //calculation for average

    average = sumA  / aTemps;

    //Figuring out the Min and Max AM temps

    for (int MM = 0; MM < aTemps; MM++)
    {
        if(minA > atemps[MM])
        {
            minA = atemps[MM];
        }
        else if(maxA < atemps[MM])
        {
            maxA = atemps[MM];
        }

        lowest = minA;
        highest = maxA;
    }


    //Display of the Calculation results
    cout << "This is the average of todays temperatures: " << average <<endl;
    cout <<endl;
    cout << "Todays High temperature is: " << highest <<endl;
    cout <<endl;
    cout << "Todays Low temperature is: " << lowest <<endl;
}

int main()
{
    cout <<"Welcome to the weather station.\n";
    cout <<"Please enter Ferenheit temperatures for calculations: \n";

    WeatherStation alpha;
    alpha.GetATemperatures(atemps, aTemps);
    alpha.DisplayATemperatures(temps, Temps);
    alpha.arrayCalcs(temps,Temps);

    cout << "\n";

    system("pause");
    return 0;
}

Answer 1

1）数组是atemps[]吗？如果是这样，它已经是私有的...问题是什么？

2）为什么你的数组类成员是静态的？如果没有这么好的理由，不要这样做（因为这似乎是一个家庭作业，我几乎可以肯定你没有一个该死的理由）。

3）你的构造函数中有一行无用的代码 - 这是函数中唯一的一行。

4）您的教授不接受您命名变量atemps和aTemps - 如果他们忽略了它，我将非常关注您所接受的教育质量。并不是变量名称本身就是一个大问题，而是你将它们命名为类似，因为这是维护噩梦的一个秘诀，如果它发生在实际代码中。

编辑 - 基于我们的评论聊天，这是我的建议。我没有尝试编译这个并且我没有声称这是编写程序的最佳（甚至建议）方式...我的建议仅限于将数据保留在对象中（以一种有空间的方式）增长超出这个问题/讨论）。

#include <iostream>
#include <iomanip>

using namespace std;

class WeatherStation
{
public:
    WeatherStation();
    void GetATemperatures();
    void DisplayATemperatures();
    void arrayCalcs();

private:
    static const int aTemps = 24;
    int atemps[aTemps];
};

WeatherStation::WeatherStation()
{
}

void WeatherStation::GetATemperatures()
{
    for (int i = 0; i < aTemps; i++ )
    {
        cout << "Please enter the temperature for " << i  << ":00 ";

        while(true)
        {
            cin >> atemps[i];

            if(atemps[i] >= -50 && atemps[i] <= 130)
            {
                break;
            } else {
                cout << "This temperature is not valid\n";
                cout << "Please enter a temperature between -50 and 130 degrees F \n";
                cout << "Please enter a new temperature: ";
            }
        }
    }
}

void WeatherStation::DisplayATemperatures()
{
    cout << setw (5) << "Hour" << setw(24)<< "Temperature \n";
    cout << "\n";

    for (int k = 0; k < aTemps; k++)
    {
        cout << setw (3) << k << ":00" << setw (16) << atemps[k]<<endl;
    }

    cout <<"\n";
}

void WeatherStation::arrayCalcs()
{
    int sumA = 0;

    double average = 0.0;
    int minA = atemps[0];

    int maxA = atemps[0];

    int lowest = 0;
    int highest = 0;

    //Sum of the AM temps
    for (int kk = 0; kk < aTemps; kk++)
    {
        sumA = sumA + atemps[kk];
    }

    //calculation for average

    average = sumA  / aTemps;

    //Figuring out the Min and Max AM temps

    for (int MM = 0; MM < aTemps; MM++)
    {
        if(minA > atemps[MM])
        {
            minA = atemps[MM];
        }
        else if(maxA < atemps[MM])
        {
            maxA = atemps[MM];
        }

        lowest = minA;
        highest = maxA;
    }


    //Display of the Calculation results
    cout << "This is the average of todays temperatures: " << average <<endl;
    cout <<endl;
    cout << "Todays High temperature is: " << highest <<endl;
    cout <<endl;
    cout << "Todays Low temperature is: " << lowest <<endl;
}

int main()
{
    cout <<"Welcome to the weather station.\n";
    cout <<"Please enter Ferenheit temperatures for calculations: \n";

    WeatherStation alpha;
    alpha.GetATemperatures();
    alpha.DisplayATemperatures();
    alpha.arrayCalcs();

    cout << "\n";

    system("pause");
    return 0;
}

C ++设置类中数组元素的数量

1 个答案: