Question

我有一个带有byte []的内存泄漏，我想了解更多有关此问题，以防止它在将来发生。

这是我的java代码：

package server.world;

import java.io.RandomAccessFile;
import java.nio.MappedByteBuffer;
import java.nio.channels.FileChannel;

public class WalkingHandler {

    public static final int WIDTH = 12000;
    public static final int HEIGHT = 9900;

    private final TiledMap map;

    private WalkingHandler() {
        this.map = new TiledMap(WIDTH, HEIGHT);
    }

    private static class SingletonContainer {
        private static final WalkingHandler SINGLETON = new WalkingHandler();
    }

    public static WalkingHandler getSingleton() {
        return SingletonContainer.SINGLETON;
    }

    public boolean traversable(int x, int y, int direction) {
        int flag = map.getFlag(x, y);
        //System.out.println(direction);
        if (direction == 0 && (flag == 1 || flag == 4 || flag == 6 || flag == 7 || flag == 9 || flag == 11 || flag == 13 || flag == 14)) {
            return false;
        } else if (direction == 4 && (flag == 1 || flag == 7 || flag == 15 || flag == 10 || flag == 11 || flag == 12 || flag == 14 || flag == 5)) {
            return false;
        } else if (direction == 8 && (flag == 1 || flag == 2 || flag == 3 || flag == 4 || flag == 5 || flag == 6 || flag == 7 || flag == 12)) {
            return false;
        } else if (direction == 12 && (flag == 1 || flag == 3 || flag == 6 || flag == 9 || flag == 10 || flag == 11 || flag == 12 || flag == 8)) {
            return false;
        } else if(flag > 0 && flag < 15) {
            return false;
        }
        return true;
    }

    public void initialize() throws Exception {
        long delta = System.currentTimeMillis();
        RandomAccessFile raf = new RandomAccessFile("data/lolmap.bin", "r");
        FileChannel channel = raf.getChannel();
        MappedByteBuffer buffer = channel.map(FileChannel.MapMode.READ_ONLY, 0, channel.size());
        int length = buffer.getInt();
        for(int i = 0; i < length; i++) {
            int x = buffer.getShort();
            int y = buffer.getShort();
            byte flag = buffer.get();
            map.flag(x, y, flag);
        }
        System.out.println("Loaded clipmap in " + (System.currentTimeMillis() - delta) + "ms.");
    }

    private static class TiledMap {

        private final byte[] plane;

        public TiledMap(int width, int height) {
            this.plane = new byte[width * 10000 + height];
        }

        public int getFlag(int x, int y) {
            return plane[x * 10000 + y];
        }

        public void flag(int x, int y, byte flag) {
            this.plane[x * 10000 + y] = flag;
        }

    }

}

有人会介意我做错了什么吗？

Answer 1

你正在创建一个大小为12000 * 10000 + 9900的数组，即120_009_900字节（这甚至被错误地初始化：你应该分配12000 * 9900个空格并用x * height + y得到它们）

private static class TiledMap {

    private final byte[] plane;
    private final int width,height;

    public TiledMap(int width, int height) {
        this.plane = new byte[width * height];
        this.width = width;
        this.height = height;
    }

    public int getFlag(int x, int y) {
        return plane[x * height + y];
    }

    public void flag(int x, int y, byte flag) {
        this.plane[x * height + y] = flag;
    }

}

然而，您最好先从文件中获取所需的空间，然后再分配

如何避免byte []内存泄漏？

1 个答案: